bump version to 0.91

[gitmo/Moose.git] / t / 030_roles / 017_extending_role_attrs.t

diff --git a/t/030_roles/017_extending_role_attrs.t b/t/030_roles/017_extending_role_attrs.t
index 55d1410..e960a67 100644 (file)
--- a/t/030_roles/017_extending_role_attrs.t
+++ b/t/030_roles/017_extending_role_attrs.t
@@ -3,16 +3,14 @@
 use strict;
 use warnings;
 
-use Test::More tests => 29;
+use Test::More tests => 27;
 use Test::Exception;
 
-BEGIN {
-    use_ok('Moose');
-}
+
 
 =pod
 
-This basically just makes sure that using +name 
+This basically just makes sure that using +name
 on role attributes works right.
 
 =cut
@@ -20,21 +18,21 @@ on role attributes works right.
 {
     package Foo::Role;
     use Moose::Role;
-    
+
     has 'bar' => (
         is      => 'rw',
-        isa     => 'Int',   
+        isa     => 'Int',
         default => sub { 10 },
     );
-    
+
     package Foo;
     use Moose;
-    
+
     with 'Foo::Role';
-    
+
     ::lives_ok {
         has '+bar' => (default => sub { 100 });
-    } '... extended the attribute successfully';  
+    } '... extended the attribute successfully';
 }
 
 my $foo = Foo->new;
@@ -42,6 +40,7 @@ isa_ok($foo, 'Foo');
 
 is($foo->bar, 100, '... got the extended attribute');
 
+
 {
     package Bar::Role;
     use Moose::Role;
@@ -63,7 +62,6 @@ is($foo->bar, 100, '... got the extended attribute');
     } "... narrowed the role's type constraint successfully";
 }
 
-
 my $bar = Bar->new(foo => 42);
 isa_ok($bar, 'Bar');
 is($bar->foo, 42, '... got the extended attribute');
@@ -73,13 +71,14 @@ is($bar->foo, 100, "... can change the attribute's value to an Int");
 throws_ok { $bar->foo("baz") } qr/^Attribute \(foo\) does not pass the type constraint because: Validation failed for 'Int' failed with value baz at /;
 is($bar->foo, 100, "... still has the old Int value");
 
+
 {
     package Baz::Role;
     use Moose::Role;
 
     has 'baz' => (
         is      => 'rw',
-        isa     => 'Str | Int | ArrayRef',
+        isa     => 'Value',
     );
 
     package Baz;
@@ -89,22 +88,20 @@ is($bar->foo, 100, "... still has the old Int value");
 
     ::lives_ok {
         has '+baz' => (
-            isa => 'Int | ArrayRef',
+            isa => 'Int | ClassName',
         )
     } "... narrowed the role's type constraint successfully";
 }
 
-
 my $baz = Baz->new(baz => 99);
 isa_ok($baz, 'Baz');
 is($baz->baz, 99, '... got the extended attribute');
-$baz->baz(100);
-is($baz->baz, 100, "... can change the attribute's value to an Int");
-$baz->baz(["hi"]);
-is_deeply($baz->baz, ["hi"], "... can change the attribute's value to an ArrayRef");
+$baz->baz('Foo');
+is($baz->baz, 'Foo', "... can change the attribute's value to a ClassName");
+
+throws_ok { $baz->baz("zonk") } qr/^Attribute \(baz\) does not pass the type constraint because: Validation failed for 'ClassName\|Int' failed with value zonk at /;
+is_deeply($baz->baz, 'Foo', "... still has the old ClassName value");
 
-throws_ok { $baz->baz("quux") } qr/^Attribute \(baz\) does not pass the type constraint because: Validation failed for 'Int \| ArrayRef' failed with value quux at /;
-is_deeply($baz->baz, ["hi"], "... still has the old ArrayRef value");
 
 {
     package Quux::Role;
@@ -132,7 +129,6 @@ is_deeply($baz->baz, ["hi"], "... still has the old ArrayRef value");
     } "... narrowed the role's type constraint successfully";
 }
 
-
 my $quux = Quux->new(quux => 99);
 isa_ok($quux, 'Quux');
 is($quux->quux, 99, '... got the extended attribute');
@@ -141,37 +137,39 @@ is($quux->quux, 100, "... can change the attribute's value to an Int");
 $quux->quux(["hi"]);
 is_deeply($quux->quux, ["hi"], "... can change the attribute's value to an ArrayRef");
 
-throws_ok { $quux->quux("quux") } qr/^Attribute \(quux\) does not pass the type constraint because: Validation failed for 'Positive \| ArrayRef' failed with value quux at /;
+throws_ok { $quux->quux("quux") } qr/^Attribute \(quux\) does not pass the type constraint because: Validation failed for 'ArrayRef\|Positive' failed with value quux at /;
 is_deeply($quux->quux, ["hi"], "... still has the old ArrayRef value");
 
-throws_ok { $quux->quux({a => 1}) } qr/^Attribute \(quux\) does not pass the type constraint because: Validation failed for 'Positive \| ArrayRef' failed with value HASH\(\w+\) at /;
+throws_ok { $quux->quux({a => 1}) } qr/^Attribute \(quux\) does not pass the type constraint because: Validation failed for 'ArrayRef\|Positive' failed with value HASH\(\w+\) at /;
 is_deeply($quux->quux, ["hi"], "... still has the old ArrayRef value");
 
+
 {
     package Err::Role;
     use Moose::Role;
 
-    has "err" => (
-        isa => 'Str | Int',
-    );
+    for (1..3) {
+        has "err$_" => (
+            isa => 'Str | Int',
+            is => 'bare',
+        );
+    }
 
     package Err;
     use Moose;
 
     with 'Err::Role';
 
-    my $error = qr/New type constraint setting must be a subtype of inherited one, or included in the inherited constraint/;
-
-    ::throws_ok {
-        has '+err' => (isa => 'Defined');
-    } $error, "must get more specific, not less specific";
+    ::lives_ok {
+        has '+err1' => (isa => 'Defined');
+    } "can get less specific in the subclass";
 
-    ::throws_ok {
-        has '+err' => (isa => 'Bool');
-    } $error, "the type has to be a part of the union";
+    ::lives_ok {
+        has '+err2' => (isa => 'Bool');
+    } "or change the type completely";
 
-    ::throws_ok {
-        has '+err' => (isa => 'Str | ArrayRef');
-    } $error, "can't add new types to the union";
+    ::lives_ok {
+        has '+err3' => (isa => 'Str | ArrayRef');
+    } "or add new types to the union";
 }