use strict;
use warnings;
use Test::More;
+use Test::Exception;
+use SQL::Abstract::Test import => ['is_same_sql_bind'];
-plan tests => 24;
-
+use Data::Dumper;
use SQL::Abstract;
# Make sure to test the examples, since having them break is somewhat
# embarrassing. :-(
+my $not_stringifiable = bless {}, 'SQLA::NotStringifiable';
+
my @handle_tests = (
{
where => {
},
{
+ where => [
+ status => 'completed',
+ user => 'nwiger',
+ ],
+ stmt => " WHERE ( status = ? OR user = ? )",
+ bind => [qw/completed nwiger/],
+ },
+
+ {
where => {
user => 'nwiger',
status => 'completed'
completion_date => { 'between', ['2002-10-01', '2003-02-06'] },
},
order => \'ticket, requestor',
- stmt => " WHERE ( completion_date BETWEEN ? AND ? AND status = ? ) ORDER BY ticket, requestor",
+#LDNOTE: modified parentheses
+# stmt => " WHERE ( completion_date BETWEEN ? AND ? AND status = ? ) ORDER BY ticket, requestor",
+ stmt => " WHERE ( ( completion_date BETWEEN ? AND ? ) AND status = ? ) ORDER BY ticket, requestor",
bind => [qw/2002-10-01 2003-02-06 completed/],
},
requestor => { 'like', undef },
},
order => \'requestor, ticket',
- stmt => " WHERE ( priority BETWEEN ? AND ? AND requestor IS NULL ) ORDER BY requestor, ticket",
+#LDNOTE: modified parentheses
+# stmt => " WHERE ( priority BETWEEN ? AND ? AND requestor IS NULL ) ORDER BY requestor, ticket",
+ stmt => " WHERE ( ( priority BETWEEN ? AND ? ) AND requestor IS NULL ) ORDER BY requestor, ticket",
bind => [qw/1 3/],
},
'>' => 10,
},
},
- stmt => " WHERE ( id = ? AND num <= ? AND num > ? )",
+# LDNOTE : modified test below, just parentheses differ
+# stmt => " WHERE ( id = ? AND num <= ? AND num > ? )",
+ stmt => " WHERE ( id = ? AND ( num <= ? AND num > ? ) )",
bind => [qw/1 20 10/],
},
wix => {'in' => [qw/zz yy/]},
wux => {'not_in' => [qw/30 40/]}
},
- stmt => " WHERE ( ( ( foo NOT LIKE ? ) OR ( foo NOT LIKE ? ) OR ( foo NOT LIKE ? ) ) AND ( ( fum LIKE ? ) OR ( fum LIKE ? ) ) AND nix BETWEEN ? AND ? AND nox NOT BETWEEN ? AND ? AND wix IN ( ?, ? ) AND wux NOT IN ( ?, ? ) )",
+# LDNOTE: modified parentheses for BETWEEN (trivial).
+# Also modified the logic of "not_like" (severe, same reasons as #14 in 00where.t)
+# stmt => " WHERE ( ( ( foo NOT LIKE ? ) OR ( foo NOT LIKE ? ) OR ( foo NOT LIKE ? ) ) AND ( ( fum LIKE ? ) OR ( fum LIKE ? ) ) AND nix BETWEEN ? AND ? AND nox NOT BETWEEN ? AND ? AND wix IN ( ?, ? ) AND wux NOT IN ( ?, ? ) )",
+ stmt => " WHERE ( ( foo NOT LIKE ? AND foo NOT LIKE ? AND foo NOT LIKE ? ) AND ( ( fum LIKE ? ) OR ( fum LIKE ? ) ) AND ( nix BETWEEN ? AND ? ) AND ( nox NOT BETWEEN ? AND ? ) AND wix IN ( ?, ? ) AND wux NOT IN ( ?, ? ) )",
bind => [7,8,9,'a','b',100,200,150,160,'zz','yy','30','40'],
},
+ {
+ where => {
+ id => [],
+ bar => {'!=' => []},
+ },
+ stmt => " WHERE ( 1=1 AND 0=1 )",
+ bind => [],
+ },
+
+
+ {
+ where => {
+ foo => \["IN (?, ?)", 22, 33],
+ bar => [-and => \["> ?", 44], \["< ?", 55] ],
+ },
+ stmt => " WHERE ( (bar > ? AND bar < ?) AND foo IN (?, ?) )",
+ bind => [44, 55, 22, 33],
+ },
+ {
+ where => { -and => [{}, { 'me.id' => '1'}] },
+ stmt => " WHERE ( ( me.id = ? ) )",
+ bind => [ 1 ],
+ },
+
+ {
+ where => { foo => $not_stringifiable, },
+ stmt => " WHERE ( foo = ? )",
+ bind => [ $not_stringifiable ],
+ },
+
+ {
+ where => \[ 'foo = ?','bar' ],
+ stmt => " WHERE (foo = ?)",
+ bind => [ "bar" ],
+ },
+
+ {
+ where => [ \[ 'foo = ?','bar' ] ],
+ stmt => " WHERE (foo = ?)",
+ bind => [ "bar" ],
+ },
);
-for (@handle_tests) {
- local $" = ', ';
- #print "creating a handle with args ($_->{args}): ";
- my $sql = SQL::Abstract->new;
+# add extra modifier tests, based on 2 outcomes
+my $mod_and = {
+ stmt => 'WHERE ( foo = ? OR bar = ? ) AND baz = ? ',
+ bind => [qw/1 2 3/],
+};
+my $mod_or = {
+ stmt => 'WHERE ( foo = ? OR bar = ? ) OR baz = ?',
+ bind => [qw/1 2 3/],
+};
+
+push @handle_tests, (
+ # test modifiers within hashrefs
+ {
+ where => { -or => [
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]},
+ %$mod_or,
+ },
+ {
+ where => { -and => [
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]},
+ %$mod_and,
+ },
- # run twice
- for (my $i=0; $i < 2; $i++) {
- my($stmt, @bind) = $sql->where($_->{where}, $_->{order});
- my $bad = 0;
- for(my $i=0; $i < @{$_->{bind}}; $i++) {
- $bad++ unless $_->{bind}[$i] eq $bind[$i];
- }
-
- ok($stmt eq $_->{stmt} && @bind == @{$_->{bind}} && ! $bad) or
- print "got\n",
- "[$stmt] [@bind]\n",
- "instead of\n",
- "[$_->{stmt}] [@{$_->{bind}}]\n\n";
- }
+ # test modifiers within arrayrefs
+ {
+ where => [ -or => [
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]],
+ %$mod_or,
+ },
+ {
+ where => [ -and => [
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]],
+ %$mod_and,
+ },
+
+ # test conflicting modifiers within hashrefs (last one should win?)
+ {
+ where => { -and => [ -or =>
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]},
+ %$mod_or,
+ },
+ {
+ where => { -or => [ -and =>
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]},
+ %$mod_and,
+ },
+
+ # test conflicting modifiers within arrayrefs (last one should win?)
+ {
+ where => [ -and => [ -or =>
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]],
+ %$mod_or,
+ },
+ {
+ where => [ -or => [ -and =>
+ [ foo => 1, bar => 2 ],
+ baz => 3,
+ ]],
+ %$mod_and,
+ },
+);
+
+plan tests => ( @handle_tests * 2 ) + 1;
+
+for my $case (@handle_tests) {
+ local $Data::Dumper::Terse = 1;
+ my $sql = SQL::Abstract->new;
+ my($stmt, @bind);
+ lives_ok (sub {
+ ($stmt, @bind) = $sql->where($case->{where}, $case->{order});
+ is_same_sql_bind($stmt, \@bind, $case->{stmt}, $case->{bind})
+ || diag "Search term:\n" . Dumper $case->{where};
+ });
}
+dies_ok {
+ my $sql = SQL::Abstract->new;
+ $sql->where({ foo => { '>=' => [] }},);
+};