-#!/usr/bin/perl
-
use strict;
use warnings;
use Test::More;
+use Test::Warn;
use Test::Exception;
-use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where) ];
+use SQL::Abstract::Test import => [qw(is_same_sql_bind diag_where dumper) ];
use SQL::Abstract;
-# Make sure to test the examples, since having them break is somewhat
-# embarrassing. :-(
-
my $not_stringifiable = bless {}, 'SQLA::NotStringifiable';
my @handle_tests = (
{
+ where => 'foo',
+ order => [],
+ stmt => ' WHERE foo',
+ bind => [],
+ },
+ {
where => {
requestor => 'inna',
worker => ['nwiger', 'rcwe', 'sfz'],
completion_date => { 'between', ['2002-10-01', '2003-02-06'] },
},
order => \'ticket, requestor',
-#LDNOTE: modified parentheses
-#
-# acked by RIBASUSHI
stmt => "WHERE ( ( completion_date BETWEEN ? AND ? ) AND status = ? ) ORDER BY ticket, requestor",
bind => [qw/2002-10-01 2003-02-06 completed/],
},
requestor => { 'like', undef },
},
order => \'requestor, ticket',
-#LDNOTE: modified parentheses
-#
-# acked by RIBASUSHI
stmt => " WHERE ( ( priority BETWEEN ? AND ? ) AND requestor IS NULL ) ORDER BY requestor, ticket",
bind => [qw/1 3/],
+ warns => qr/Supplying an undefined argument to 'LIKE' is deprecated/,
},
'>' => 10,
},
},
-# LDNOTE : modified test below, just parentheses differ
-#
-# acked by RIBASUSHI
stmt => " WHERE ( id = ? AND ( num <= ? AND num > ? ) )",
bind => [qw/1 20 10/],
},
{
-# LDNOTE 23.03.09 : modified test below, just parentheses differ
where => { foo => {-not_like => [7,8,9]},
fum => {'like' => [qw/a b/]},
nix => {'between' => [100,200] },
},
stmt => " WHERE ( ( ( foo NOT LIKE ? ) OR ( foo NOT LIKE ? ) OR ( foo NOT LIKE ? ) ) AND ( ( fum LIKE ? ) OR ( fum LIKE ? ) ) AND ( nix BETWEEN ? AND ? ) AND ( nox NOT BETWEEN ? AND ? ) AND wix IN ( ?, ? ) AND wux NOT IN ( ?, ? ) )",
bind => [7,8,9,'a','b',100,200,150,160,'zz','yy','30','40'],
+ warns => qr/\QA multi-element arrayref as an argument to the inequality op 'NOT LIKE' is technically equivalent to an always-true 1=1/,
},
{
# Op against random functions (these two are oracle-specific)
{
where => { timestamp => { '!=' => { -trunc => { -year => \'sysdate' } } } },
- stmt => " WHERE ( timestamp != TRUNC (YEAR sysdate) )",
+ stmt => " WHERE ( timestamp != TRUNC(YEAR(sysdate)) )",
bind => [],
},
{
where => { timestamp => { '>=' => { -to_date => '2009-12-21 00:00:00' } } },
- stmt => " WHERE ( timestamp >= TO_DATE ? )",
+ stmt => " WHERE ( timestamp >= TO_DATE(?) )",
bind => ['2009-12-21 00:00:00'],
},
stmt => " WHERE ( (NOT ( c AND (NOT ( (NOT a = ?) AND (NOT b) )) )) ) ",
bind => [ 1 ],
},
+ {
+ where => \"0",
+ stmt => " WHERE ( 0 ) ",
+ bind => [ ],
+ },
+ {
+ where => { artistid => {} },
+ stmt => '',
+ bind => [ ],
+ },
+ {
+ where => [ -and => [ {}, [] ], -or => [ {}, [] ] ],
+ stmt => '',
+ bind => [ ],
+ },
+ {
+ where => { '=' => \'bozz' },
+ stmt => 'WHERE = bozz',
+ bind => [ ],
+ },
);
for my $case (@handle_tests) {
my $sql = SQL::Abstract->new;
- my ($stmt, @bind) = $sql->where($case->{where}, $case->{order});
+ my ($stmt, @bind);
+ lives_ok {
+ warnings_exist {
+ ($stmt, @bind) = $sql->where($case->{where}, $case->{order});
+ } $case->{warns} || [];
+ };
+
is_same_sql_bind($stmt, \@bind, $case->{stmt}, $case->{bind})
- || diag_where ( $case->{where} );
+ || do { diag_where ( $case->{where} ); diag dumper($sql->_expand_expr($case->{where})) };
}
-dies_ok {
- my $sql = SQL::Abstract->new;
- $sql->where({ foo => { '>=' => [] }},);
-};
-
done_testing;