-#!/usr/bin/perl
-
use strict;
use warnings;
use Test::More;
use SQL::Abstract;
+#### WARNING ####
+#
+# -nest has been undocumented on purpose, but is still supported for the
+# foreseable future. Do not rip out the -nest tests before speaking to
+# someone on the DBIC mailing list or in irc.perl.org#dbix-class
+#
+#################
+
+
my @tests = (
{
func => 'select',
},
{
func => 'update',
-# LDNOTE : removed the "-maybe", because we no longer admit unknown ops
-#
-# acked by RIBASUSHI
-# args => ['fhole', {fpoles => 4}, [-maybe => {race => [-and => [qw(black white asian)]]},
args => ['fhole', {fpoles => 4}, [
{ race => [qw/-or black white asian /] },
{ -nest => { firsttime => [-or => {'=','yes'}, undef] } },
},
{
func => 'select',
-# LDNOTE: modified test below because we agreed with MST that literal SQL
-# should not automatically insert a '='; the user has to do it
-#
-# acked by MSTROUT
-# args => ['test', '*', { a => \["to_date(?, 'MM/DD/YY')", '02/02/02']}],
args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}],
stmt => q{SELECT * FROM test WHERE ( a = to_date(?, 'MM/DD/YY') )},
stmt_q => q{SELECT * FROM `test` WHERE ( `a` = to_date(?, 'MM/DD/YY') )},
stmt => 'INSERT INTO test (a, b, c, d, e) VALUES (?, ?, ?, ?, ?)',
stmt_q => 'INSERT INTO `test` (`a`, `b`, `c`, `d`, `e`) VALUES (?, ?, ?, ?, ?)',
bind => [qw/1 2 3 4/, { answer => 42}],
- warning_like => qr/HASH ref as bind value in insert is not supported/i,
+ warns => qr/HASH ref as bind value in insert is not supported/i,
},
{
func => 'update',
func => 'insert',
new => {bindtype => 'columns'},
args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}],
- exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
+ throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
},
{
func => 'update',
new => {bindtype => 'columns'},
args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, {a => {'between', [1,2]}}],
- exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
+ throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
},
{
func => 'select',
new => {bindtype => 'columns'},
args => ['test', '*', { a => \["= to_date(?, 'MM/DD/YY')", '02/02/02']}],
- exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
+ throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
},
{
func => 'select',
new => {bindtype => 'columns'},
args => ['test', '*', { a => {'<' => \["to_date(?, 'MM/DD/YY')", '02/02/02']}, b => 8 }],
- exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
+ throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
+ },
+ {
+ func => 'select',
+ args => ['test', '*', { foo => { '>=' => [] }} ],
+ throws => qr/\Qoperator '>=' applied on an empty array (field 'foo')/,
},
{
func => 'select',
func => 'select',
new => {bindtype => 'columns'},
args => ['test', '*', { a => {-in => \["(SELECT d FROM to_date(?, 'MM/DD/YY') AS d)", '02/02/02']}, b => 8 }],
- exception_like => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
+ throws => qr/bindtype 'columns' selected, you need to pass: \[column_name => bind_value\]/,
},
{
func => 'insert',
func => 'update',
new => {bindtype => 'columns'},
args => ['test', {a => 1, b => \["to_date(?, 'MM/DD/YY')", [{dummy => 1} => '02/02/02']], c => { -lower => 'foo' }}, {a => {'between', [1,2]}}],
- stmt => "UPDATE test SET a = ?, b = to_date(?, 'MM/DD/YY'), c = LOWER( ? ) WHERE ( a BETWEEN ? AND ? )",
- stmt_q => "UPDATE `test` SET `a` = ?, `b` = to_date(?, 'MM/DD/YY'), `c` = LOWER ( ? ) WHERE ( `a` BETWEEN ? AND ? )",
+ stmt => "UPDATE test SET a = ?, b = to_date(?, 'MM/DD/YY'), c = LOWER ? WHERE ( a BETWEEN ? AND ? )",
+ stmt_q => "UPDATE `test` SET `a` = ?, `b` = to_date(?, 'MM/DD/YY'), `c` = LOWER ? WHERE ( `a` BETWEEN ? AND ? )",
bind => [[a => '1'], [{dummy => 1} => '02/02/02'], [c => 'foo'], [a => '1'], [a => '2']],
},
{
stmt_q => 'SELECT * FROM `test` WHERE ( `Y` = ( MAX( LENGTH( MIN ? ) ) ) )',
bind => [[Y => 'x']],
},
+ {
+ func => 'select',
+ args => ['test', '*', { a => { -in => [] }, b => { -not_in => [] }, c => { -in => 42 } }],
+ stmt => 'SELECT * FROM test WHERE ( 0=1 AND 1=1 AND c IN ( ? ))',
+ stmt_q => 'SELECT * FROM `test` WHERE ( 0=1 AND 1=1 AND `c` IN ( ? ))',
+ bind => [ 42 ],
+ },
+ {
+ func => 'select',
+ args => ['test', '*', { a => { -in => [] }, b => { -not_in => [] } }],
+ stmt => 'SELECT * FROM test WHERE ( 0=1 AND 1=1 )',
+ stmt_q => 'SELECT * FROM `test` WHERE ( 0=1 AND 1=1 )',
+ bind => [],
+ },
+ {
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ func => 'select',
+ args => ['test', '*', { a => { -in => [42, undef] }, b => { -not_in => [42, undef] } } ],
+ stmt => 'SELECT * FROM test WHERE ( ( a IN ( ? ) OR a IS NULL ) AND b NOT IN ( ? ) AND b IS NOT NULL )',
+ stmt_q => 'SELECT * FROM `test` WHERE ( ( `a` IN ( ? ) OR `a` IS NULL ) AND `b` NOT IN ( ? ) AND `b` IS NOT NULL )',
+ bind => [ 42, 42 ],
+ },
+ {
+ throws => qr/
+ \QSQL::Abstract before v1.75 used to generate incorrect SQL \E
+ \Qwhen the -IN operator was given an undef-containing list: \E
+ \Q!!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based \E
+ \Qversion of SQL::Abstract will emit the logically correct SQL \E
+ \Qinstead of raising this exception)\E
+ /x,
+ func => 'select',
+ args => ['test', '*', { a => { -in => [undef] }, b => { -not_in => [undef] } } ],
+ stmt => 'SELECT * FROM test WHERE ( a IS NULL AND b IS NOT NULL )',
+ stmt_q => 'SELECT * FROM `test` WHERE ( `a` IS NULL AND `b` IS NOT NULL )',
+ bind => [],
+ },
+ {
+ func => 'select',
+ args => ['test', '*', { a => { -in => undef } }],
+ throws => qr/Argument passed to the 'IN' operator can not be undefined/,
+ },
);
-
-plan tests => scalar(grep { !$_->{warning_like} } @tests) * 2
- + scalar(grep { $_->{warning_like} } @tests) * 4;
-
for my $t (@tests) {
- local $"=', ';
-
my $new = $t->{new} || {};
- $new->{debug} = $ENV{DEBUG} || 0;
for my $quoted (0, 1) {
($stmt, @bind) = $maker->$op (@ { $t->{args} } );
};
- if ($t->{exception_like}) {
+ if (my $e = $t->{throws}) {
throws_ok(
sub { $cref->() },
- $t->{exception_like},
- "throws the expected exception ($t->{exception_like})"
+ $e,
);
- } else {
- if ($t->{warning_like}) {
- warning_like(
- sub { $cref->() },
- $t->{warning_like},
- "issues the expected warning ($t->{warning_like})"
- );
- }
- else {
- $cref->();
- }
+ }
+ else {
+ warnings_exist(
+ sub { $cref->() },
+ $t->{warns} || [],
+ );
+
is_same_sql_bind(
$stmt,
\@bind,
}
}
}
+
+done_testing;