Make sure that applied_attribute roles don't spill over to other roles to during...

[gitmo/Moose.git] / t / 010_basics / 030_deprecations.t

diff --git a/t/010_basics/030_deprecations.t b/t/010_basics/030_deprecations.t
index 211e6df..cb2eaf9 100644 (file)
--- a/t/010_basics/030_deprecations.t
+++ b/t/010_basics/030_deprecations.t
@@ -1,12 +1,16 @@
 use strict;
 use warnings;
 
+use Test::Fatal;
 use Test::More;
 
 use Test::Requires {
     'Test::Output' => '0.01',
 };
 
+# All tests are wrapped with lives_and because the stderr output tests will
+# otherwise eat exceptions, and the test just dies silently.
+
 {
     package Role;
 
@@ -20,37 +24,151 @@ use Test::Requires {
 
     use Moose;
 
-    ::stderr_like{ has foo => (
-            traits => ['String'],
-            is     => 'ro',
-            isa    => 'Str',
-        );
+    ::is( ::exception (
+        sub {
+            ::stderr_like{ has foo => (
+                    traits => ['String'],
+                    is     => 'ro',
+                    isa    => 'Str',
+                );
+                }
+                qr{\QAllowing a native trait to automatically supply a default is deprecated. You can avoid this warning by supplying a default, builder, or making the attribute required at $0 line},
+                'Not providing a default for native String trait warns';
+
+            ::stderr_is{ has bar => (
+                    traits  => ['Bool'],
+                    isa     => 'Bool',
+                    default => q{},
+                );
+                } q{}, 'No warning when _default_is is set';
+
+            ::stderr_like{ Foo->new->bar }
+                qr{\QThe bar method in the Foo class was automatically created by the native delegation trait for the bar attribute. This "default is" feature is deprecated. Explicitly set "is" or define accessor names to avoid this at $0 line},
+                'calling a reader on a method created by a _default_is warns';
+
+            ::stderr_like{ with 'Role' =>
+                    { excludes => ['thing'], alias => { thing => 'thing2' } };
+                }
+                qr/\QThe alias and excludes options for role application have been renamed -alias and -excludes (Foo is consuming Role - do you need to upgrade Foo?)/,
+                'passing excludes or alias with a leading dash warns';
+            ::ok(
+                !Foo->meta->has_method('thing'),
+                'thing method is excluded from role application'
+            );
+            ::ok(
+                Foo->meta->has_method('thing2'),
+                'thing2 method is created as alias in role application'
+            );
         }
-        qr/\QAllowing a native trait to automatically supply a default is deprecated/,
-        'Not providing a default for native String trait warns';
-
-    ::stderr_like{ has bar => (
-            traits  => ['String'],
-            isa     => 'Str',
-            default => q{},
-        );
+    ), undef );
+}
+
+{
+    package Pack1;
+
+    use Moose;
+
+    ::is( ::exception (
+        sub {
+            ::stderr_is{ has foo => (
+                    traits  => ['String'],
+                    is      => 'ro',
+                    isa     => 'Str',
+                    builder => '_build_foo',
+                );
+                } q{},
+                'Providing a builder for a String trait avoids default default warning';
+
+            has bar => (
+                traits  => ['String'],
+                reader  => '_bar',
+                isa     => 'Str',
+                default => q{},
+            );
+
+            ::ok(
+                !Pack1->can('bar'),
+                'no default is assigned when reader is provided'
+            );
+
+            ::stderr_is{ Pack1->new->_bar } q{},
+                'Providing a reader for a String trait avoids default is warning';
         }
-        qr/\QAllowing a native trait to automatically supply a value for "is" is deprecated/,
-        'Not providing a value for is with native String trait warns';
+    ), undef );
+
+    sub _build_foo { q{} }
+}
+
+{
+    package Pack2;
 
-    ::stderr_like{ with 'Role' =>
-            { excludes => ['thing'], alias => { thing => 'thing2' } };
+    use Moose;
+
+    ::is( ::exception (
+        sub {
+            ::stderr_is{ has foo => (
+                    traits   => ['String'],
+                    is       => 'ro',
+                    isa      => 'Str',
+                    required => 1,
+                );
+                } q{},
+                'Making a String trait required avoids default default warning';
+
+            has bar => (
+                traits  => ['String'],
+                writer  => '_bar',
+                isa     => 'Str',
+                default => q{},
+            );
+
+            ::ok(
+                !Pack2->can('bar'),
+                'no default is assigned when writer is provided'
+            );
+
+            ::stderr_is{ Pack2->new( foo => 'x' )->_bar('x') }
+                q{},
+                'Providing a writer for a String trait avoids default is warning';
+        }
+    ), undef );
+}
+
+{
+    package Pack3;
+
+    use Moose;
+
+    ::is( ::exception (
+        sub {
+            ::stderr_is{ has foo => (
+                    traits     => ['String'],
+                    is         => 'ro',
+                    isa        => 'Str',
+                    lazy_build => 1,
+                );
+                } q{},
+                'Making a String trait lazy_build avoids default default warning';
+
+            has bar => (
+                traits   => ['String'],
+                accessor => '_bar',
+                isa      => 'Str',
+                default  => q{},
+            );
+
+            ::ok(
+                !Pack3->can('bar'),
+                'no default is assigned when accessor is provided'
+            );
+
+            ::stderr_is{ Pack3->new->_bar }
+                q{},
+                'Providing a accessor for a String trait avoids default is warning';
         }
-        qr/\QThe alias and excludes options for role application have been renamed -alias and -excludes/,
-        'passing excludes or alias with a leading dash warns';
-    ::ok(
-        !Foo->meta->has_method('thing'),
-        'thing method is excluded from role application'
-    );
-    ::ok(
-        Foo->meta->has_method('thing2'),
-        'thing2 method is created as alias in role application'
-    );
+    ), undef );
+
+    sub _build_foo { q{} }
 }
 
 done_testing;