use strict;
use warnings;
-use Test::More tests => 38;
+use Test::Requires { 'MooseX::ConfigFromFile' => '0.06' }; # skip all if not installed
+use Test::More tests => 50;
use Test::Fatal;
-use File::Spec;
+use Path::Tiny;
use Test::NoWarnings 1.04 ':early';
-use Test::Requires 'MooseX::ConfigFromFile';
-
{
package App;
optional_from_config => 'from_config_2',
);
- my $cpath = File::Spec->canonpath('/notused/default');
- if ( $file ne $cpath ) {
+ if ( $file ne Path::Tiny::path('/notused/default') ) {
$config{config_from_override} = 1;
}
extends 'App';
has '+configfile' => (
- default => File::Spec->canonpath('/notused/default'),
+ default => Path::Tiny::path('/notused/default')->stringify,
);
}
extends 'App';
has '+configfile' => (
- default => sub { return File::Spec->canonpath('/notused/default') },
+ default => sub { return Path::Tiny::path('/notused/default') },
);
}
+{
+ package App::ConfigFileWrapped;
+
+ use Moose;
+ extends 'App';
+
+ around configfile => sub { '/notused/default' };
+}
+
+
# No config specified
{
local @ARGV = qw( --required_from_argv 1 );
- if ($Getopt::Long::Descriptive::VERSION >= 0.091) {
- like exception { App->new_with_options }, qr/Mandatory parameter 'required_from_config' missing/;
- }
- else {
- like exception { App->new_with_options }, qr/Required option missing: required_from_config/;
- }
+ like exception { App->new_with_options },
+ ($Getopt::Long::Descriptive::VERSION >= 0.091
+ ? qr/Mandatory parameter 'required_from_config' missing/
+ : qr/Required option missing: required_from_config/);
{
my $app = App::DefaultConfigFile->new_with_options;
ok( !$app->config_from_override,
'... config_from_override false as expected' );
- is( $app->configfile, File::Spec->canonpath('/notused/default'),
+ is( $app->configfile, path('/notused/default'),
'... configfile is /notused/default as expected' );
}
-}
-
-# No config specified
-{
- local @ARGV = qw( --required_from_argv 1 );
{
my $app = App::DefaultConfigFileCodeRef->new_with_options;
ok( !$app->config_from_override,
'... config_from_override false as expected' );
- is( $app->configfile, File::Spec->canonpath('/notused/default'),
+ is( $app->configfile, path('/notused/default'),
+ '... configfile is /notused/default as expected' );
+ }
+
+ {
+ my $app = App::ConfigFileWrapped->new_with_options;
+ isa_ok( $app, 'App::ConfigFileWrapped' );
+ app_ok( $app );
+
+ ok( !$app->config_from_override,
+ '... config_from_override false as expected' );
+
+ is( $app->configfile, path('/notused/default'),
'... configfile is /notused/default as expected' );
}
}
# Config specified
{
- local @ARGV = qw( --configfile /notused --required_from_argv 1 );
+ local @ARGV = qw( --configfile /notused/override --required_from_argv 1 );
{
my $app = App->new_with_options;
ok( $app->config_from_override,
'... config_from_override true as expected' );
- is( $app->configfile, File::Spec->canonpath('/notused'),
- '... configfile is /notused as expected' );
+ is( $app->configfile, path('/notused/override'),
+ '... configfile is /notused/override as expected' );
}
{
my $app = App::DefaultConfigFileCodeRef->new_with_options;
ok( $app->config_from_override,
'... config_from_override true as expected' );
- is( $app->configfile, File::Spec->canonpath('/notused'),
+ is( $app->configfile, path('/notused/override'),
+ '... configfile is /notused/override as expected' );
+ }
+ TODO: {
+ my $app = App::ConfigFileWrapped->new_with_options;
+ isa_ok( $app, 'App::ConfigFileWrapped' );
+ app_ok( $app );
+
+ ok( $app->config_from_override,
+ '... config_from_override true as expected' );
+
+# FIXME - in order for this to work, we need to fix CFF so the
+# configfile method always returns the actual value of the attribute,
+# not the default sub thingy.
+ local $TODO = 'MooseX::ConfigFromFile needs fixes';
+ is( $app->configfile, path('/notused/override'),
'... configfile is /notused as expected' );
}
}
# Required arg not supplied from cmdline
{
- local @ARGV = qw( --configfile /notused );
- if ($Getopt::Long::Descriptive::VERSION >= 0.091) {
- like exception { App->new_with_options }, qr/Mandatory parameter 'required_from_argv' missing/;
- }
- else {
- like exception { App->new_with_options }, qr/Required option missing: required_from_argv/;
- }
+ local @ARGV = qw( --configfile /notused/override );
+ like exception { App->new_with_options },
+ ($Getopt::Long::Descriptive::VERSION >= 0.091
+ ? qr/Mandatory parameter 'required_from_argv' missing/
+ : qr/Required option missing: required_from_argv/);
}
# Config file value overriden from cmdline
{
- local @ARGV = qw( --configfile /notused --required_from_argv 1 --required_from_config override );
+ local @ARGV = qw( --configfile /notused/override --required_from_argv 1 --required_from_config override );
my $app = App->new_with_options;
isa_ok( $app, 'App' );