use strict;
use warnings FATAL => 'all';
-our $VERSION = '1.001000'; # 1.1.0
+use constant _PERL_LT_5_8_4 => ($] < 5.008004) ? 1 : 0;
+
+our $VERSION = '1.002002'; # 1.2.2
sub VERSION {
for ($_[1]) {
last unless defined && !ref && int != 1;
die "Major version specified as $_ - this is strictures version 1";
}
+ # disable this since Foo->VERSION(undef) correctly returns the version
+ # and that can happen either if our caller passes undef explicitly or
+ # because the for above autovivified $_[1] - I could make it stop but
+ # it's pointless since we don't want to blow up if the caller does
+ # something valid either.
+ no warnings 'uninitialized';
shift->SUPER::VERSION(@_);
}
+my $extras_load_warned;
+
sub import {
strict->import;
warnings->import(FATAL => 'all');
- my $do_indirect = do {
+
+ my $extra_tests = do {
if (exists $ENV{PERL_STRICTURES_EXTRA}) {
- $ENV{PERL_STRICTURES_EXTRA}
- } else {
+ if (_PERL_LT_5_8_4 and $ENV{PERL_STRICTURES_EXTRA}) {
+ die 'PERL_STRICTUTRES_EXTRA checks are not available on perls older than 5.8.4, '
+ . "please unset \$ENV{PERL_STRICTURES_EXTRA}\n";
+ }
+ $ENV{PERL_STRICTURES_EXTRA};
+ } elsif (! _PERL_LT_5_8_4) {
!!($0 =~ /^x?t\/.*(?:load|compile|coverage|use_ok).*\.t$/
and (-e '.git' or -e '.svn'))
}
};
- if ($do_indirect) {
+ if ($extra_tests) {
+ my @failed;
if (eval { require indirect; 1 }) {
indirect->unimport(':fatal');
} else {
- die "strictures.pm extra testing active but couldn't load indirect.pm: $@";
+ push @failed, 'indirect';
+ }
+ if (eval { require multidimensional; 1 }) {
+ multidimensional->unimport;
+ } else {
+ push @failed, 'multidimensional';
+ }
+ if (eval { require bareword::filehandles; 1 }) {
+ bareword::filehandles->unimport;
+ } else {
+ push @failed, 'bareword::filehandles';
+ }
+ if (@failed and not $extras_load_warned++) {
+ my $failed = join ' ', @failed;
+ warn <<EOE;
+strictures.pm extra testing active but couldn't load all modules. Missing were:
+
+ $failed
+
+Extra testing is auto-enabled in checkouts only, so if you're the author
+of a strictures using module you need to run:
+
+ cpan indirect multidimensional bareword::filehandles
+
+but these modules are not required by your users.
+EOE
}
}
}
use strict;
use warnings FATAL => 'all';
no indirect 'fatal';
+ no multidimensional;
+ no bareword::filehandles;
Note that _EXTRA may at some point add even more tests, with only a minor
version increase, but any changes to the effect of 'use strictures' in
normal mode will involve a major version bump.
-Be aware: THIS MEANS INDIRECT IS REQUIRED FOR AUTHORS OF STRICTURES USING
-CODE - but not by end users thereof.
+If any of the extra testing modules are not present, strictures will
+complain loudly, once, via warn(), and then shut up. But you really
+should consider installing them, they're all great anti-footgun tools.
=head1 DESCRIPTION
Therefore, strictures turns on indirect checking only when it thinks it's
running in a compilation (or pod coverage) test - though if this causes
-undesired behaviour this can be overriden by setting the
+undesired behaviour this can be overridden by setting the
PERL_STRICTURES_EXTRA environment variable.
If additional useful author side checks come to mind, I'll add them to the
=head1 AUTHOR
-Matt S. Trout <mst@shadowcat.co.uk>
+mst - Matt S. Trout (cpan:MSTROUT) <mst@shadowcat.co.uk>
=head1 CONTRIBUTORS