Pass all expression stability tests. Verified by:

[scpubgit/Q-Branch.git] / lib / SQL / Abstract / Clauses.pm

diff --git a/lib/SQL/Abstract/Clauses.pm b/lib/SQL/Abstract/Clauses.pm
index d769abd..6f311ae 100644 (file)
--- a/lib/SQL/Abstract/Clauses.pm
+++ b/lib/SQL/Abstract/Clauses.pm
@@ -21,24 +21,13 @@ sub register_defaults {
   $self->{clauses_of}{update} = [ qw(update set where returning) ];
   $self->{expand}{update} = sub { shift->_expand_statement(@_) };
   $self->{render}{update} = sub { shift->_render_statement(update => @_) };
-  $self->{expand_clause}{'update.update'} = sub {
-    $_[0]->expand_expr($_[1], -ident)
-  };
-  $self->{expand_clause}{'update.set'} = '_expand_update_set_values';
-  $self->{expand_clause}{'update.where'} = 'expand_expr';
-  $self->{expand_clause}{'update.returning'} = sub {
-    shift->_expand_maybe_list_expr(@_, -ident);
-  };
+  $self->{expand_clause}{"update.$_"} = "_expand_update_clause_$_"
+    for @{$self->{clauses_of}{update}};
   $self->{clauses_of}{delete} = [ qw(delete_from where returning) ];
   $self->{expand}{delete} = sub { shift->_expand_statement(@_) };
   $self->{render}{delete} = sub { shift->_render_statement(delete => @_) };
-  $self->{expand_clause}{'delete.delete_from'} = sub {
-    $_[0]->_expand_maybe_list_expr($_[1], -ident)
-  };
-  $self->{expand_clause}{'delete.where'} = 'expand_expr';
-  $self->{expand_clause}{'delete.returning'} = sub {
-    shift->_expand_maybe_list_expr(@_, -ident);
-  };
+  $self->{expand_clause}{"delete.$_"} = "_expand_delete_clause_$_"
+    for @{$self->{clauses_of}{delete}};
   $self->{clauses_of}{insert} = [
     'insert_into', 'fields', 'values', 'returning'
   ];
@@ -47,6 +36,7 @@ sub register_defaults {
   $self->{expand_clause}{'insert.insert_into'} = sub {
     shift->expand_expr(@_, -ident);
   };
+  $self->{expand_clause}{'insert.values'} = '_expand_insert_clause_values';
   $self->{expand_clause}{'insert.returning'} = sub {
     shift->_expand_maybe_list_expr(@_, -ident);
   };
@@ -76,6 +66,34 @@ sub _expand_select_clause_order_by {
   +(order_by => $self->_expand_order_by($order_by));
 }
 
+sub _expand_update_clause_update {
+  my ($self, $target) = @_;
+  +(update => $self->expand_expr($target, -ident));
+}
+
+sub _expand_update_clause_set {
+  return $_[1] if ref($_[1]) eq 'HASH' and ($_[1]->{-op}||[''])->[0] eq ',';
+  +(set => shift->_expand_update_set_values(@_));
+}
+
+sub _expand_update_clause_where {
+  +(where => shift->expand_expr(@_));
+}
+
+sub _expand_update_clause_returning {
+  +(returning => shift->_expand_maybe_list_expr(@_, -ident));
+}
+
+sub _expand_delete_clause_delete_from {
+  +(delete_from => shift->_expand_maybe_list_expr(@_, -ident));
+}
+
+sub _expand_delete_clause_where { +(where => shift->expand_expr(@_)); }
+
+sub _expand_delete_clause_returning {
+  +(returning => shift->_expand_maybe_list_expr(@_, -ident));
+}
+
 sub _expand_statement {
   my ($self, $type, $args) = @_;
   my $ec = $self->{expand_clause};
@@ -153,12 +171,16 @@ sub delete {
 
 sub insert {
   my ($self, $table, $data, $options) = @_;
-  my %clauses = (insert_into => $table, %{$options||{}});
-  my ($f_aqt, $v_aqt) = $self->_expand_insert_values($data);
-  $clauses{fields} = $f_aqt if $f_aqt;
-  $clauses{values} = $v_aqt;
+  my %clauses = (insert_into => $table, values => $data, %{$options||{}});
   my ($sql, @bind) = $self->render_expr({ -insert => \%clauses });
   return wantarray ? ($sql, @bind) : $sql;
 }
 
+sub _expand_insert_clause_values {
+  my ($self, $data) = @_;
+  return $data if ref($data) eq 'HASH' and $data->{-row};
+  my ($f_aqt, $v_aqt) = $self->_expand_insert_values($data);
+  return (values => $v_aqt, ($f_aqt ? (fields => $f_aqt) : ()));
+}
+
 1;