Switch to Sub::Exporter, use meta_type in PPB

[gitmo/Perl-Critic-Dynamic-Moose.git] / lib / Perl / Critic / Policy / DynamicMoose / ProhibitPublicBuilders.pm

diff --git a/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm b/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm
index 03bb8f6..2d93702 100644 (file)
--- a/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm
+++ b/lib/Perl/Critic/Policy/DynamicMoose/ProhibitPublicBuilders.pm
@@ -2,8 +2,12 @@ package Perl::Critic::Policy::DynamicMoose::ProhibitPublicBuilders;
 use Moose;
 extends 'Perl::Critic::Policy::DynamicMoose';
 
+use Perl::Critic::Util::Moose 'meta_type';
+
 Readonly::Scalar my $EXPL => q{Prefix builder method names with an underscore};
 
+augment applies_to_metaclass => sub { 'Moose::Meta::Role' };
+
 sub violates_metaclass {
     my $self = shift;
     my $meta = shift;
@@ -15,13 +19,21 @@ sub violates_metaclass {
     my $attributes = $meta->get_attribute_map;
     for my $name (keys %$attributes) {
         my $attribute = $attributes->{$name};
+        my $builder;
 
-        next if !$attribute->has_builder;
-
-        my $builder = $attribute->builder;
+        if (blessed($attribute)) {
+            next if !$attribute->has_builder;
+            $builder = $attribute->builder;
+        }
+        else {
+            # Roles suck :(
+            next if !defined($attribute->{builder});
+            $builder = $attribute->{builder};
+        }
 
         if ($builder !~ /^_/) {
-            my $desc = "Builder method '$builder' of attribute '$attribute' of class '$classname' is public";
+            my $type = meta_type($meta);
+            my $desc = "Builder method '$builder' of attribute '$attribute' of $type '$classname' is public";
             push @violations, $self->violation($desc, $EXPL);
         }
     }