bump version to 0.73_01

[gitmo/Moose.git] / lib / Moose / Role.pm

diff --git a/lib/Moose/Role.pm b/lib/Moose/Role.pm
index 4d2bd67..5b3a8d0 100644 (file)
--- a/lib/Moose/Role.pm
+++ b/lib/Moose/Role.pm
@@ -5,17 +5,19 @@ use strict;
 use warnings;
 
 use Scalar::Util 'blessed';
-use Carp         'confess', 'croak';
+use Carp         'croak';
 
 use Data::OptList;
 use Sub::Exporter;
 
-our $VERSION   = '0.56';
+our $VERSION   = '0.73_01';
+$VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
 use Moose       ();
 use Moose::Util ();
 
+use Moose::Exporter;
 use Moose::Meta::Role;
 use Moose::Util::TypeConstraints;
 
@@ -24,23 +26,23 @@ sub extends {
 }
 
 sub with {
-    Moose::Util::apply_all_roles( shift->meta(), @_ );
+    Moose::Util::apply_all_roles( Moose::Meta::Role->initialize(shift), @_ );
 }
 
 sub requires {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
     croak "Must specify at least one method" unless @_;
     $meta->add_required_methods(@_);
 }
 
 sub excludes {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
     croak "Must specify at least one role" unless @_;
     $meta->add_excluded_roles(@_);
 }
 
 sub has {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
     my $name = shift;
     croak 'Usage: has \'name\' => ( key => value, ... )' if @_ == 1;
     my %options = @_;
@@ -49,11 +51,11 @@ sub has {
 }
 
 sub before {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
     my $code = pop @_;
 
     for (@_) {
-        croak "Moose::Role do not currently support "
+        croak "Roles do not currently support "
             . ref($_)
             . " references for before method modifiers"
             if ref $_;
@@ -62,11 +64,11 @@ sub before {
 }
 
 sub after {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
 
     my $code = pop @_;
     for (@_) {
-        croak "Moose::Role do not currently support "
+        croak "Roles do not currently support "
             . ref($_)
             . " references for after method modifiers"
             if ref $_;
@@ -75,10 +77,10 @@ sub after {
 }
 
 sub around {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
     my $code = pop @_;
     for (@_) {
-        croak "Moose::Role do not currently support "
+        croak "Roles do not currently support "
             . ref($_)
             . " references for around method modifiers"
             if ref $_;
@@ -93,20 +95,20 @@ sub super {
 }
 
 sub override {
-    my $meta = shift->meta();
+    my $meta = Moose::Meta::Role->initialize(shift);
     my ( $name, $code ) = @_;
     $meta->add_override_method_modifier( $name, $code );
 }
 
 sub inner {
-    croak "Moose::Role cannot support 'inner'";
+    croak "Roles cannot support 'inner'";
 }
 
 sub augment {
-    croak "Moose::Role cannot support 'augment'";
+    croak "Roles cannot support 'augment'";
 }
 
-my $exporter = Moose::Exporter->setup_import_methods(
+Moose::Exporter->setup_import_methods(
     with_caller => [
         qw( with requires excludes has before after around override make_immutable )
     ],
@@ -117,35 +119,44 @@ my $exporter = Moose::Exporter->setup_import_methods(
     ],
 );
 
-{
-    my %METAS;
+sub init_meta {
+    shift;
+    my %args = @_;
 
-    sub init_meta {
-        shift;
-        my %args = @_;
+    my $role = $args{for_class};
 
-        my $role = $args{for_class}
-            or confess
-            "Cannot call init_meta without specifying a for_class";
+    unless ($role) {
+        require Moose;
+        Moose->throw_error("Cannot call init_meta without specifying a for_class");
+    }
 
-        return $METAS{$role} if exists $METAS{$role};
+    my $metaclass = $args{metaclass} || "Moose::Meta::Role";
 
-        # make a subtype for each Moose class
-        role_type $role unless find_type_constraint($role);
+    # make a subtype for each Moose class
+    role_type $role unless find_type_constraint($role);
 
-        my $meta;
-        if ($role->can('meta')) {
-            $meta = $role->meta();
-            (blessed($meta) && $meta->isa('Moose::Meta::Role'))
-                || confess "You already have a &meta function, but it does not return a Moose::Meta::Role";
-        }
-        else {
-            $meta = Moose::Meta::Role->initialize($role);
-            $meta->alias_method('meta' => sub { $meta });
-        }
+    # FIXME copy from Moose.pm
+    my $meta;
+    if ($role->can('meta')) {
+        $meta = $role->meta();
 
-        return $METAS{$role} = $meta;
+        unless ( blessed($meta) && $meta->isa('Moose::Meta::Role') ) {
+            require Moose;
+            Moose->throw_error("You already have a &meta function, but it does not return a Moose::Meta::Role");
+        }
+    }
+    else {
+        $meta = $metaclass->initialize($role);
+
+        $meta->add_method(
+            'meta' => sub {
+                # re-initialize so it inherits properly
+                $metaclass->initialize( ref($_[0]) || $_[0] );
+            }
+        );
     }
+
+    return $meta;
 }
 
 1;
@@ -256,16 +267,6 @@ In most cases, this will be a non-issue; however, it is something to keep in
 mind when using method modifiers in a role. You should never assume any
 ordering.
 
-=item *
-
-The C<requires> keyword currently only works with actual methods. A method
-modifier (before/around/after and override) will not count as a fufillment
-of the requirement, and neither will an autogenerated accessor for an attribute.
-
-It is likely that attribute accessors will eventually be allowed to fufill those
-requirements, or we will introduce a C<requires_attr> keyword of some kind
-instead. This decision has not yet been finalized.
-
 =back
 
 =head1 BUGS
@@ -282,7 +283,7 @@ Christian Hansen E<lt>chansen@cpan.orgE<gt>
 
 =head1 COPYRIGHT AND LICENSE
 
-Copyright 2006-2008 by Infinity Interactive, Inc.
+Copyright 2006-2009 by Infinity Interactive, Inc.
 
 L<http://www.iinteractive.com>