more readable inlined code

[gitmo/Moose.git] / lib / Moose / Meta / TypeConstraint / DuckType.pm

diff --git a/lib/Moose/Meta/TypeConstraint/DuckType.pm b/lib/Moose/Meta/TypeConstraint/DuckType.pm
index db221a6..fa70470 100644 (file)
--- a/lib/Moose/Meta/TypeConstraint/DuckType.pm
+++ b/lib/Moose/Meta/TypeConstraint/DuckType.pm
@@ -4,26 +4,44 @@ use strict;
 use warnings;
 use metaclass;
 
+use B;
 use Scalar::Util 'blessed';
 use List::MoreUtils qw(all);
 use Moose::Util 'english_list';
 
 use Moose::Util::TypeConstraints ();
 
-our $VERSION   = '0.93_02';
-$VERSION = eval $VERSION;
-our $AUTHORITY = 'cpan:STEVAN';
-
 use base 'Moose::Meta::TypeConstraint';
 
 __PACKAGE__->meta->add_attribute('methods' => (
     accessor => 'methods',
 ));
 
+my $inliner = sub {
+    my $self = shift;
+    my $val  = shift;
+
+    return 'Scalar::Util::blessed(' . $val . ') '
+             . '&& Scalar::Util::blessed(' . $val . ') ne "Regexp" '
+             . '&& &List::MoreUtils::all('
+                 . 'sub { ' . $val . '->can($_) }, '
+                 . join(', ', map { B::perlstring($_) } @{ $self->methods })
+             . ')';
+};
+
 sub new {
     my ( $class, %args ) = @_;
 
-    $args{parent} = Moose::Util::TypeConstraints::find_type_constraint('Object');
+    $args{parent}
+        = Moose::Util::TypeConstraints::find_type_constraint('Object');
+
+    my @methods = @{ $args{methods} };
+    $args{constraint} = sub {
+        blessed( $_[0] ) ne 'Regexp'
+            && all { $_[0]->can($_) } @methods;
+    };
+
+    $args{inlined} = $inliner;
 
     my $self = $class->_new(\%args);
 
@@ -66,20 +84,6 @@ sub constraint {
     };
 }
 
-sub _compile_hand_optimized_type_constraint {
-    my $self  = shift;
-
-    my @methods = @{ $self->methods };
-
-    sub {
-        my $obj = shift;
-
-        return blessed($obj)
-            && blessed($obj) ne 'Regexp'
-            && all { $obj->can($_) } @methods;
-    };
-}
-
 sub create_child_type {
     my ($self, @args) = @_;
     return Moose::Meta::TypeConstraint->new(@args, parent => $self);
@@ -102,14 +106,12 @@ sub get_message {
 
 1;
 
+# ABSTRACT: Type constraint for duck typing
+
 __END__
 
 =pod
 
-=head1 NAME
-
-Moose::Meta::TypeConstraint::DuckType - Type constraint for duck typing
-
 =head1 DESCRIPTION
 
 This class represents type constraints based on an enumerated list of
@@ -156,20 +158,5 @@ object!
 
 See L<Moose/BUGS> for details on reporting bugs.
 
-=head1 AUTHOR
-
-Chris Prather E<lt>chris@prather.orgE<gt>
-
-Shawn M Moore E<lt>sartak@gmail.comE<gt>
-
-=head1 COPYRIGHT AND LICENSE
-
-Copyright 2006-2010 by Infinity Interactive, Inc.
-
-L<http://www.iinteractive.com>
-
-This library is free software; you can redistribute it and/or modify
-it under the same terms as Perl itself.
-
 =cut