use warnings;
use metaclass;
+use List::MoreUtils 'firstval';
use Moose::Util 'english_list';
use Scalar::Util 'weaken', 'blessed';
-our $VERSION = '0.79';
-$VERSION = eval $VERSION;
-our $AUTHORITY = 'cpan:STEVAN';
-
use base 'Moose::Meta::Role::Application';
__PACKAGE__->meta->add_attribute('role' => (
reader => 'role',
+ Class::MOP::_definition_context(),
));
__PACKAGE__->meta->add_attribute('class' => (
- reader => 'class',
+ accessor => 'class',
+ Class::MOP::_definition_context(),
));
sub apply {
my ($self, $role, $class) = @_;
+ # We're not checking for role names to support multiple instances of the
+ # same Parameterized role.
+ return if grep { $role == $_ } @{ $class->roles() };
+
# We need weak_ref in CMOP :(
weaken($self->{role} = $role);
weaken($self->{class} = $class);
my $error = '';
+ @missing = sort { $a->name cmp $b->name } @missing;
my @conflicts = grep { $_->isa('Moose::Meta::Role::Method::Conflicting') } @missing;
if (@conflicts) {
my $conflict = $conflicts[0];
- my $roles = Moose::Util::english_list( map { q{'} . $_ . q{'} } @{ $conflict->roles } );
-
- $error
- .= "Due to a method name conflict in roles "
- . $roles
- . ", the method '"
- . $conflict->name
- . "' must be implemented or excluded by '"
- . $class->name
- . q{'};
+ my $roles = $conflict->roles_as_english_list;
+
+ my @same_role_conflicts = grep { $_->roles_as_english_list eq $roles } @conflicts;
+
+ if (@same_role_conflicts == 1) {
+ $error
+ .= "Due to a method name conflict in roles "
+ . $roles
+ . ", the method '"
+ . $conflict->name
+ . "' must be implemented or excluded by '"
+ . $class->name
+ . q{'};
+ }
+ else {
+ my $methods
+ = Moose::Util::english_list( map { q{'} . $_->name . q{'} } @same_role_conflicts );
+
+ $error
+ .= "Due to method name conflicts in roles "
+ . $roles
+ . ", the methods "
+ . $methods
+ . " must be implemented or excluded by '"
+ . $class->name
+ . q{'};
+ }
}
elsif (@missing) {
my $noun = @missing == 1 ? 'method' : 'methods';
. "' requires the $noun $list "
. "to be implemented by '"
. $class->name . q{'};
+
+ if (my $meth = firstval { $class->name->can($_) } @missing) {
+ $error .= ". If you imported functions intending to use them as "
+ . "methods, you need to explicitly mark them as such, via "
+ . $class->name . "->meta->add_method($meth => \\\&$meth)";
+ }
}
$class->throw_error($error);
sub apply_attributes {
my ($self, $role, $class) = @_;
+
foreach my $attribute_name ($role->get_attribute_list) {
# it if it has one already
if ($class->has_attribute($attribute_name) &&
}
else {
$class->add_attribute(
- $attribute_name,
- $role->get_attribute($attribute_name)
+ $role->get_attribute($attribute_name)->attribute_for_class
);
}
}
}
sub apply_methods {
- my ($self, $role, $class) = @_;
- foreach my $method_name ($role->get_method_list) {
-
- unless ($self->is_method_excluded($method_name)) {
- # it if it has one already
- if ($class->has_method($method_name) &&
- # and if they are not the same thing ...
- $class->get_method($method_name)->body != $role->get_method($method_name)->body) {
- next;
- }
- else {
- # add it, although it could be overridden
- $class->add_method(
- $method_name,
- $role->get_method($method_name)
- );
- }
- }
+ my ( $self, $role, $class ) = @_;
+
+ foreach my $method ( $role->_get_local_methods ) {
+ my $method_name = $method->name;
+
+ next if $method->isa('Class::MOP::Method::Meta');
+
+ unless ( $self->is_method_excluded($method_name) ) {
+
+ my $class_method = $class->get_method($method_name);
+
+ next if $class_method && $class_method->body != $method->body;
- if ($self->is_method_aliased($method_name)) {
- my $aliased_method_name = $self->get_method_aliases->{$method_name};
- # it if it has one already
- if ($class->has_method($aliased_method_name) &&
- # and if they are not the same thing ...
- $class->get_method($aliased_method_name)->body != $role->get_method($method_name)->body) {
- $class->throw_error("Cannot create a method alias if a local method of the same name exists");
- }
$class->add_method(
- $aliased_method_name,
- $role->get_method($method_name)
+ $method_name,
+ $method,
);
}
+
+ next unless $self->is_method_aliased($method_name);
+
+ my $aliased_method_name = $self->get_method_aliases->{$method_name};
+
+ my $class_method = $class->get_method($aliased_method_name);
+
+ if ( $class_method && $class_method->body != $method->body ) {
+ $class->throw_error(
+ "Cannot create a method alias if a local method of the same name exists"
+ );
+ }
+
+ $class->add_method(
+ $aliased_method_name,
+ $method,
+ );
}
+
# we must reset the cache here since
# we are just aliasing methods, otherwise
# the modifiers go wonky.
1;
+# ABSTRACT: Compose a role into a class
+
__END__
=pod
-=head1 NAME
-
-Moose::Meta::Role::Application::ToClass - Compose a role into a class
-
=head1 DESCRIPTION
=head2 METHODS
=head1 BUGS
-All complex software has bugs lurking in it, and this module is no
-exception. If you find a bug please either email me, or add the bug
-to cpan-RT.
-
-=head1 AUTHOR
-
-Stevan Little E<lt>stevan@iinteractive.comE<gt>
-
-=head1 COPYRIGHT AND LICENSE
-
-Copyright 2006-2009 by Infinity Interactive, Inc.
-
-L<http://www.iinteractive.com>
-
-This library is free software; you can redistribute it and/or modify
-it under the same terms as Perl itself.
+See L<Moose/BUGS> for details on reporting bugs.
=cut
projects / gitmo/Moose.git / blobdiff