use metaclass;
use Moose::Util 'english_list';
-use Scalar::Util 'blessed';
+use Scalar::Util 'weaken', 'blessed';
-our $VERSION = '0.77';
+our $VERSION = '1.08';
$VERSION = eval $VERSION;
our $AUTHORITY = 'cpan:STEVAN';
__PACKAGE__->meta->add_attribute('role' => (
reader => 'role',
- writer => 'set_role',
));
__PACKAGE__->meta->add_attribute('class' => (
reader => 'class',
- writer => 'set_class',
));
sub apply {
my ($self, $role, $class) = @_;
- $self->set_role($role);
- $self->set_class($class);
+ # We need weak_ref in CMOP :(
+ weaken($self->{role} = $role);
+ weaken($self->{class} = $class);
$self->SUPER::apply($role, $class);
+
$class->add_role($role);
+ $class->add_role_application($self);
}
sub check_role_exclusions {
# attribute accessors. However I am thinking
# that maybe those are somehow exempt from
# the require methods stuff.
- foreach my $required_method_name ($role->get_required_method_list) {
+ foreach my $required_method ($role->get_required_method_list) {
+ my $required_method_name = $required_method->name;
if (!$class->find_method_by_name($required_method_name)) {
next if $self->is_aliased_method($required_method_name);
- push @missing, $required_method_name;
+ push @missing, $required_method;
}
}
my $error = '';
- if (@missing) {
+ @missing = sort { $a->name cmp $b->name } @missing;
+ my @conflicts = grep { $_->isa('Moose::Meta::Role::Method::Conflicting') } @missing;
+
+ if (@conflicts) {
+ my $conflict = $conflicts[0];
+ my $roles = $conflict->roles_as_english_list;
+
+ my @same_role_conflicts = grep { $_->roles_as_english_list eq $roles } @conflicts;
+
+ if (@same_role_conflicts == 1) {
+ $error
+ .= "Due to a method name conflict in roles "
+ . $roles
+ . ", the method '"
+ . $conflict->name
+ . "' must be implemented or excluded by '"
+ . $class->name
+ . q{'};
+ }
+ else {
+ my $methods
+ = Moose::Util::english_list( map { q{'} . $_->name . q{'} } @same_role_conflicts );
+
+ $error
+ .= "Due to method name conflicts in roles "
+ . $roles
+ . ", the methods "
+ . $methods
+ . " must be implemented or excluded by '"
+ . $class->name
+ . q{'};
+ }
+ }
+ elsif (@missing) {
my $noun = @missing == 1 ? 'method' : 'methods';
my $list
sub apply_attributes {
my ($self, $role, $class) = @_;
+ my $attr_metaclass = $class->attribute_metaclass;
+
foreach my $attribute_name ($role->get_attribute_list) {
# it if it has one already
if ($class->has_attribute($attribute_name) &&
}
else {
$class->add_attribute(
- $attribute_name,
- $role->get_attribute($attribute_name)
+ $role->get_attribute($attribute_name)->attribute_for_class($attr_metaclass)
);
}
}
sub apply_methods {
my ($self, $role, $class) = @_;
foreach my $method_name ($role->get_method_list) {
+ next if $method_name eq 'meta';
unless ($self->is_method_excluded($method_name)) {
# it if it has one already
=head1 BUGS
-All complex software has bugs lurking in it, and this module is no
-exception. If you find a bug please either email me, or add the bug
-to cpan-RT.
+See L<Moose/BUGS> for details on reporting bugs.
=head1 AUTHOR
=head1 COPYRIGHT AND LICENSE
-Copyright 2006-2009 by Infinity Interactive, Inc.
+Copyright 2006-2010 by Infinity Interactive, Inc.
L<http://www.iinteractive.com>