use Scalar::Util 'blessed', 'weaken', 'looks_like_number';
-our $VERSION = '0.61';
+our $VERSION = '0.65';
our $AUTHORITY = 'cpan:STEVAN';
use base 'Moose::Meta::Method',
return $self;
}
+sub can_be_inlined {
+ my $self = shift;
+ my $metaclass = $self->associated_metaclass;
+
+ my $expected_class = $self->_expected_constructor_class;
+
+ # If any of our parents have been made immutable, we are okay to
+ # inline our own new method. The assumption is that an inlined new
+ # method provided by a parent does not actually get used by
+ # children anyway.
+ for my $meta (
+ grep { $_->is_immutable }
+ map { ( ref $metaclass )->initialize($_) }
+ grep { $_ ne $expected_class }
+ $metaclass->linearized_isa
+ ) {
+ my $transformer = $meta->get_immutable_transformer;
+
+ # This is actually a false positive if we're in a subclass of
+ # this class, _and_ the expected class is not overridden (but
+ # should be), and the real expected class is actually
+ # immutable itself (see Fey::Object::Table for an example of
+ # how this can happen). I'm not sure how to actually handle
+ # that case, since it's effectively a bug in the subclass (for
+ # not overriding _expected_constructor_class).
+ return 1 if $transformer->inlined_constructor;
+ }
+
+ if ( my $constructor = $metaclass->find_method_by_name( $self->name ) ) {
+ my $class = $self->associated_metaclass->name;
+
+ if ( $constructor->body != $expected_class->can('new') ) {
+ my $warning
+ = "Not inlining a constructor for $class since it is not"
+ . " inheriting the default $expected_class constructor\n";
+
+ $warning .= " (constructor has method modifiers which would be lost if it were inlined)\n"
+ if $constructor->isa('Class::MOP::Method::Wrapped');
+
+ warn $warning;
+
+ return 0;
+ }
+ else {
+ return 1;
+ }
+ }
+
+ # This would be a rather weird case where we have no constructor
+ # in the inheritance chain.
+ return 1;
+}
+
+# This is here so can_be_inlined can be inherited by MooseX modules.
+sub _expected_constructor_class {
+ return 'Moose::Object';
+}
+
## accessors
sub options { (shift)->{'options'} }
$self->_generate_slot_initializer($_)
} 0 .. (@{$self->attributes} - 1));
- $source .= ";\n" . $self->_generate_triggers();
+ $source .= ";\n" . $self->_generate_triggers();
$source .= ";\n" . $self->_generate_BUILDALL();
$source .= ";\n" . 'return $instance';
$source .= ";\n" . '}';
warn $source if $self->options->{debug};
- my $code;
- {
- my $meta = $self; # FIXME for _inline_throw_error...
-
- # NOTE:
- # create the nessecary lexicals
- # to be picked up in the eval
- my $attrs = $self->attributes;
-
- # We need to check if the attribute ->can('type_constraint')
- # since we may be trying to immutabilize a Moose meta class,
- # which in turn has attributes which are Class::MOP::Attribute
- # objects, rather than Moose::Meta::Attribute. And
- # Class::MOP::Attribute attributes have no type constraints.
- # However we need to make sure we leave an undef value there
- # because the inlined code is using the index of the attributes
- # to determine where to find the type constraint
-
- my @type_constraints = map {
- $_->can('type_constraint') ? $_->type_constraint : undef
- } @$attrs;
-
- my @type_constraint_bodies = map {
- defined $_ ? $_->_compiled_type_constraint : undef;
- } @type_constraints;
-
- $code = eval $source;
- $self->throw_error("Could not eval the constructor :\n\n$source\n\nbecause :\n\n$@", error => $@, data => $source ) if $@;
- }
+ # We need to check if the attribute ->can('type_constraint')
+ # since we may be trying to immutabilize a Moose meta class,
+ # which in turn has attributes which are Class::MOP::Attribute
+ # objects, rather than Moose::Meta::Attribute. And
+ # Class::MOP::Attribute attributes have no type constraints.
+ # However we need to make sure we leave an undef value there
+ # because the inlined code is using the index of the attributes
+ # to determine where to find the type constraint
+
+ my $attrs = $self->attributes;
+
+ my @type_constraints = map {
+ $_->can('type_constraint') ? $_->type_constraint : undef
+ } @$attrs;
+
+ my @type_constraint_bodies = map {
+ defined $_ ? $_->_compiled_type_constraint : undef;
+ } @type_constraints;
+
+ my $code = $self->_compile_code(
+ code => $source,
+ environment => {
+ '$meta' => \$self,
+ '$attrs' => \$attrs,
+ '@type_constraints' => \@type_constraints,
+ '@type_constraint_bodies' => \@type_constraint_bodies,
+ },
+ ) or $self->throw_error("Could not eval the constructor :\n\n$source\n\nbecause :\n\n$@", error => $@, data => $source );
+
$self->{'body'} = $code;
}
return '$attrs->[' . $index . ']->default($instance)';
}
else {
- my $default = $attr->default;
- # make sure to quote strings ...
- return "'$default'";
-
+ return q{"} . quotemeta( $attr->default ) . q{"};
}
}
=item B<new>
+=item B<can_be_inlined>
+
=item B<attributes>
=item B<meta_instance>
=item B<associated_metaclass>
+=item B<can_be_inlined>
+
=back
=head1 AUTHORS
projects / gitmo/Moose.git / blobdiff