Never use die in generate code when throwing an error.

[gitmo/Moose.git] / lib / Moose / Meta / Method / Accessor / Native / Array / sort.pm

diff --git a/lib/Moose/Meta/Method/Accessor/Native/Array/sort.pm b/lib/Moose/Meta/Method/Accessor/Native/Array/sort.pm
index 338ad1d..4b633dc 100644 (file)
--- a/lib/Moose/Meta/Method/Accessor/Native/Array/sort.pm
+++ b/lib/Moose/Meta/Method/Accessor/Native/Array/sort.pm
@@ -9,13 +9,14 @@ our $AUTHORITY = 'cpan:STEVAN';
 
 use base 'Moose::Meta::Method::Accessor::Native::Array::Reader';
 
-sub _inline_process_arguments {
-    return 'my $func = shift if @_;';
-}
+sub _maximum_arguments { 1 }
 
 sub _inline_check_arguments {
-    return
-        q{die 'Argument must be a code reference' if $func && ( ref $func || q{} ) ne 'CODE';};
+    my $self = shift;
+
+    return $self->_inline_throw_error(
+        q{'The argument passed to sort must be a code reference'})
+        . q{if $_[0] && ( ref $_[0] || q{} ) ne 'CODE';};
 }
 
 sub _return_value {
@@ -23,7 +24,7 @@ sub _return_value {
     my $slot_access = shift;
 
     return
-        "\$func ? sort { \$func->( \$a, \$b ) } \@{ ${slot_access} } : sort \@{ $slot_access }";
+        "\$_[0] ? sort { \$_[0]->( \$a, \$b ) } \@{ ${slot_access} } : sort \@{ $slot_access }";
 }
 
 1;