add a warning for immutablizing a class with mutable ancestors

[gitmo/Moose.git] / lib / Moose / Meta / Class.pm

diff --git a/lib/Moose/Meta/Class.pm b/lib/Moose/Meta/Class.pm
index 06e2d23..1311a1f 100644 (file)
--- a/lib/Moose/Meta/Class.pm
+++ b/lib/Moose/Meta/Class.pm
@@ -11,7 +11,7 @@ use List::Util qw( first );
 use List::MoreUtils qw( any all uniq first_index );
 use Scalar::Util 'weaken', 'blessed';
 
-our $VERSION   = '0.87';
+our $VERSION   = '0.89_01';
 $VERSION = eval $VERSION;
 our $AUTHORITY = 'cpan:STEVAN';
 
@@ -140,6 +140,26 @@ sub add_role {
     push @{$self->roles} => $role;
 }
 
+sub make_immutable {
+    my $self = shift;
+
+    # we do this for metaclasses way too often to do this check for them
+    if (!$self->name->isa('Class::MOP::Object')) {
+        my @superclasses = grep { $_ ne 'Moose::Object' && $_ ne $self->name }
+                        $self->linearized_isa;
+        for my $superclass (@superclasses) {
+            my $meta = Class::MOP::class_of($superclass);
+            next unless $meta && $meta->isa('Moose::Meta::Class');
+            next unless $meta->is_mutable;
+            Carp::cluck("Calling make_immutable on "
+                    . $self->name
+                    . ", which has a mutable ancestor ($superclass)");
+            last;
+        }
+    }
+    $self->SUPER::make_immutable(@_);
+}
+
 sub role_applications {
     my ($self) = @_;
 
@@ -233,7 +253,7 @@ sub superclasses {
     foreach my $super (@supers) {
         Class::MOP::load_class($super);
         my $meta = Class::MOP::class_of($super);
-        Moose->throw_error("You cannot inherit from a Moose Role ($super)")
+        $self->throw_error("You cannot inherit from a Moose Role ($super)")
             if $meta && $meta->isa('Moose::Meta::Role')
     }
     return $self->SUPER::superclasses(@supers);
@@ -673,7 +693,7 @@ These all default to the appropriate Moose class.
 
 This overrides the parent's method in order to accept a C<roles>
 option. This should be an array reference containing one more roles
-that the class does.
+that the class does, each optionally followed by a hashref of options.
 
   my $metaclass = Moose::Meta::Class->create( 'New::Class', roles => [...] );