typo fixes

[gitmo/Moose.git] / lib / Moose / Cookbook / Basics / Recipe5.pod

diff --git a/lib/Moose/Cookbook/Basics/Recipe5.pod b/lib/Moose/Cookbook/Basics/Recipe5.pod
index d901d57..46acef4 100644 (file)
--- a/lib/Moose/Cookbook/Basics/Recipe5.pod
+++ b/lib/Moose/Cookbook/Basics/Recipe5.pod
@@ -1,3 +1,9 @@
+package Moose::Cookbook::Basics::Recipe5;
+
+# ABSTRACT: More subtypes, coercion in a B<Request> class
+
+__END__
+
 
 =pod
 
@@ -11,10 +17,6 @@ use Test::Requires {
 
 =end testing-SETUP
 
-=head1 NAME
-
-Moose::Cookbook::Basics::Recipe5 - More subtypes, coercion in a B<Request> class
-
 =head1 SYNOPSIS
 
   package Request;
@@ -65,16 +67,16 @@ C<coerce> sugar function. Coercions are attached to existing type
 constraints, and define a (one-way) transformation from one type to
 another.
 
-This is very powerful, but it's also magical, so you have to
-explicitly ask for an attribute to be coerced. To do this, you must
-set the C<coerce> attribute option to a true value.
+This is very powerful, but it can also have unexpected consequences, so
+you have to explicitly ask for an attribute to be coerced. To do this,
+you must set the C<coerce> attribute option to a true value.
 
 First, we create the subtype to which we will coerce the other types:
 
   subtype 'My::Types::HTTP::Headers' => as class_type('HTTP::Headers');
 
 We are creating a subtype rather than using C<HTTP::Headers> as a type
-directly. The reason we do this is coercions are global, and a
+directly. The reason we do this is that coercions are global, and a
 coercion defined for C<HTTP::Headers> in our C<Request> class would
 then be defined for I<all> Moose-using classes in the current Perl
 interpreter. It's a L<best practice|Moose::Manual::BestPractices> to
@@ -94,7 +96,7 @@ We could go ahead and use this new type directly:
 
   has 'headers' => (
       is      => 'rw',
-      isa     => 'HTTP::Headers',
+      isa     => 'My::Types::HTTP::Headers',
       default => sub { HTTP::Headers->new }
   );
 
@@ -104,7 +106,7 @@ L<HTTP::Headers>.
 The constructor for L<HTTP::Headers> accepts a list of key-value pairs
 representing the HTTP header fields. In Perl, such a list could be
 stored in an ARRAY or HASH reference. We want our C<headers> attribute
-to accept those data structure instead of an B<HTTP::Headers>
+to accept those data structures instead of an B<HTTP::Headers>
 instance, and just do the right thing. This is exactly what coercion
 is for:
 
@@ -168,7 +170,7 @@ return value.
 If L<Params::Coerce> didn't return a L<URI> object (for whatever
 reason), Moose would throw a type constraint error.
 
-The other coercion takes a string and converts to a L<URI>. In this
+The other coercion takes a string and converts it to a L<URI>. In this
 case, we are using the coercion to apply a default behavior, where a
 string is assumed to be an C<http> URI.
 
@@ -183,12 +185,12 @@ attributes.
 =head1 CONCLUSION
 
 This recipe showed the use of coercions to create a more flexible and
-DWIM-y API. Like any powerful magic, we recommend some
+DWIM-y API. Like any powerful feature, we recommend some
 caution. Sometimes it's better to reject a value than just guess at
 how to DWIM.
 
 We also showed the use of the C<class_type> sugar function as a
-shortcut for defining a new subtype of C<Object>
+shortcut for defining a new subtype of C<Object>.
 
 =head1 FOOTNOTES
 
@@ -199,25 +201,10 @@ shortcut for defining a new subtype of C<Object>
 This particular example could be safer. Really we only want to coerce
 an array with an I<even> number of elements. We could create a new
 C<EvenElementArrayRef> type, and then coerce from that type, as
-opposed to from a plain C<ArrayRef>
+opposed to a plain C<ArrayRef>
 
 =back
 
-=head1 AUTHORS
-
-Stevan Little E<lt>stevan@iinteractive.comE<gt>
-
-Dave Rolsky E<lt>autarch@urth.orgE<gt>
-
-=head1 COPYRIGHT AND LICENSE
-
-Copyright 2006-2010 by Infinity Interactive, Inc.
-
-L<http://www.iinteractive.com>
-
-This library is free software; you can redistribute it and/or modify
-it under the same terms as Perl itself.
-
 =begin testing
 
 my $r = Request->new;
@@ -257,25 +244,35 @@ isa_ok( $r, 'Request' );
     is( $header4->content_type, 'application/pdf',
         '... got the right content type in the header' );
 
-    dies_ok {
-        $r->headers('Foo');
-    }
-    '... dies when it gets bad params';
+    isnt(
+        exception {
+            $r->headers('Foo');
+        },
+        undef,
+        '... dies when it gets bad params'
+    );
 }
 
 {
     is( $r->protocol, undef, '... got nothing by default' );
 
-    lives_ok {
-        $r->protocol('HTTP/1.0');
-    }
-    '... set the protocol correctly';
+    is(
+        exception {
+            $r->protocol('HTTP/1.0');
+        },
+        undef,
+        '... set the protocol correctly'
+    );
+
     is( $r->protocol, 'HTTP/1.0', '... got nothing by default' );
 
-    dies_ok {
-        $r->protocol('http/1.0');
-    }
-    '... the protocol died with bar params correctly';
+    isnt(
+        exception {
+            $r->protocol('http/1.0');
+        },
+        undef,
+        '... the protocol died with bar params correctly'
+    );
 }
 
 {