use Sub::Name ();
__PACKAGE__->mk_group_accessors('simple' =>
- qw/_identity _blob_log_on_update _insert_storage _identity_method/
+ qw/_identity _blob_log_on_update _writer_storage _is_writer_storage
+ _identity_method/
);
-my @delegate_to_insert_storage = qw/
+my @also_proxy_to_writer_storage = qw/
+ connect_call_set_auto_cast auto_cast connect_call_blob_setup
+ connect_call_datetime_setup
+
disconnect _connect_info _sql_maker _sql_maker_opts disable_sth_caching
auto_savepoint unsafe cursor_class debug debugobj schema
/;
# based on LongReadLen in connect_info
$self->set_textsize if $self->using_freetds;
-# create storage for insert transactions
- $self->_insert_storage((ref $self)->new);
- $self->_insert_storage->connect_info($self->connect_info);
+# create storage for insert/(update blob) transactions,
+# unless this is that storage
+ return if $self->_is_writer_storage;
+
+ my $writer_storage = (ref $self)->new;
+
+ $writer_storage->_is_writer_storage(1);
+ $writer_storage->connect_info($self->connect_info);
+ $writer_storage->auto_cast($self->auto_cast);
- $self->_insert_storage->set_textsize if $self->using_freetds;
+ $self->_writer_storage($writer_storage);
}
-for my $method (@delegate_to_insert_storage) {
+for my $method (@also_proxy_to_writer_storage) {
no strict 'refs';
+ no warnings 'redefine';
- *{$method} = Sub::Name::subname $method => sub {
+ my $replaced = __PACKAGE__->can($method);
+
+ *{$method} = Sub::Name::subname __PACKAGE__."::$method" => sub {
my $self = shift;
- $self->_insert_storage->$method(@_) if $self->_insert_storage;
- return $self->next::method(@_);
+ $self->_writer_storage->$replaced(@_) if $self->_writer_storage;
+ return $self->$replaced(@_);
};
}
$type && $type =~ /(?:text|image|lob|bytea|binary|memo)/i;
}
+sub _is_lob_column {
+ my ($self, $source, $column) = @_;
+
+ return $self->_is_lob_type($source->column_info($column)->{data_type});
+}
+
sub _prep_for_execute {
my $self = shift;
my ($op, $extra_bind, $ident, $args) = @_;
);
}
- # otherwise use the _insert_storage to do the insert+transaction on another
+ # otherwise use the _writer_storage to do the insert+transaction on another
# connection
- my $guard = $self->_insert_storage->txn_scope_guard;
+ my $guard = $self->_writer_storage->txn_scope_guard;
- my $updated_cols = $self->_insert_storage->_insert (
+ my $updated_cols = $self->_writer_storage->_insert (
$next, $source, $to_insert, $blob_cols, $identity_col
);
- $self->_identity($self->_insert_storage->_identity);
+ $self->_identity($self->_writer_storage->_identity);
$guard->commit;
sub update {
my $self = shift;
- my ($source, $fields, $where) = @_;
+ my ($source, $fields, $where, @rest) = @_;
my $wantarray = wantarray;
+
my $blob_cols = $self->_remove_blob_cols($source, $fields);
+ my $table = $source->name;
+
+ my $identity_col = List::Util::first
+ { $source->column_info($_)->{is_auto_increment} }
+ $source->columns;
+
+ my $is_identity_update = $identity_col && defined $fields->{$identity_col};
+
if (not $blob_cols) {
+ $self->_set_identity_insert($table, 'update') if $is_identity_update;
return $self->next::method(@_);
+ $self->_unset_identity_insert($table, 'update') if $is_identity_update;
+ }
+
+# check that we're not updating a blob column that's also in $where
+ for my $blob (grep $self->_is_lob_column($source, $_), $source->columns) {
+ if (exists $where->{$blob} && exists $fields->{$blob}) {
+ croak
+'Update of TEXT/IMAGE column that is also in search condition impossible';
+ }
}
# update+blob update(s) done atomically on separate connection
- $self = $self->_insert_storage;
+ $self = $self->_writer_storage;
my $guard = $self->txn_scope_guard;
- my @res;
- if ($wantarray) {
- @res = $self->next::method(@_);
- }
- elsif (defined $wantarray) {
- $res[0] = $self->next::method(@_);
- }
- else {
- $self->next::method(@_);
- }
+# First update the blob columns to be updated to '' (taken from $fields, where
+# it is originally put by _remove_blob_cols .)
+ my %blobs_to_empty = map { ($_ => delete $fields->{$_}) } keys %$blob_cols;
+
+ $self->next::method($source, \%blobs_to_empty, $where, @rest);
+# Now update the blobs before the other columns in case the update of other
+# columns makes the search condition invalid.
$self->_update_blobs($source, $blob_cols, $where);
+ my @res;
+ if (%$fields) {
+ $self->_set_identity_insert($table, 'update') if $is_identity_update;
+
+ if ($wantarray) {
+ @res = $self->next::method(@_);
+ }
+ elsif (defined $wantarray) {
+ $res[0] = $self->next::method(@_);
+ }
+ else {
+ $self->next::method(@_);
+ }
+
+ $self->_unset_identity_insert($table, 'update') if $is_identity_update;
+ }
+
$guard->commit;
return $wantarray ? @res : $res[0];
}
+### the insert_bulk stuff stolen from DBI/MSSQL.pm
+
+sub _set_identity_insert {
+ my ($self, $table, $op) = @_;
+
+ my $sql = sprintf (
+ 'SET IDENTITY_%s %s ON',
+ (uc($op) || 'INSERT'),
+ $self->sql_maker->_quote ($table),
+ );
+
+ $self->_query_start($sql);
+
+ my $dbh = $self->_get_dbh;
+ eval { $dbh->do ($sql) };
+ my $exception = $@;
+
+ $self->_query_end($sql);
+
+ if ($exception) {
+ $self->throw_exception (sprintf "Error executing '%s': %s",
+ $sql,
+ $dbh->errstr,
+ );
+ }
+}
+
+sub _unset_identity_insert {
+ my ($self, $table, $op) = @_;
+
+ my $sql = sprintf (
+ 'SET IDENTITY_%s %s OFF',
+ (uc($op) || 'INSERT'),
+ $self->sql_maker->_quote ($table),
+ );
+
+ $self->_query_start($sql);
+
+ my $dbh = $self->_get_dbh;
+ $dbh->do ($sql);
+
+ $self->_query_end($sql);
+}
+
+# for tests
+sub _can_insert_bulk { 1 }
+
+# XXX this should use the DBD::Sybase bulk API, where possible
+sub insert_bulk {
+ my $self = shift;
+ my ($source, $cols, $data) = @_;
+
+ my $is_identity_insert = (List::Util::first
+ { $source->column_info ($_)->{is_auto_increment} }
+ (@{$cols})
+ )
+ ? 1
+ : 0;
+
+ if ($is_identity_insert) {
+ $self->_set_identity_insert ($source->name);
+ }
+
+ $self->next::method(@_);
+
+ if ($is_identity_insert) {
+ $self->_unset_identity_insert ($source->name);
+ }
+}
+
+### end of stolen insert_bulk section
+
+# Make sure blobs are not bound as placeholders, and return any non-empty ones
+# as a hash.
sub _remove_blob_cols {
my ($self, $source, $fields) = @_;
for my $col (keys %$fields) {
if ($self->_is_lob_type($source->column_info($col)->{data_type})) {
- $blob_cols{$col} = delete $fields->{$col};
- $fields->{$col} = \"''";
+ my $blob_val = delete $fields->{$col};
+ if (not defined $blob_val) {
+ $fields->{$col} = \'NULL';
+ }
+ else {
+ $fields->{$col} = \"''";
+ $blob_cols{$col} = $blob_val unless $blob_val eq '';
+ }
}
}
my (@primary_cols) = $source->primary_columns;
- croak "Cannot update TEXT/IMAGE column(s) without a primary key"
+ $self->throw_exception('Cannot update TEXT/IMAGE column(s) without a primary key')
unless @primary_cols;
# check if we're updating a single row by PK
my ($self, $source, $blob_cols, $row) = @_;
my $dbh = $self->_get_dbh;
- my $table = $source->from;
+ my $table = $source->name;
my %row = %$row;
my (@primary_cols) = $source->primary_columns;
- croak "Cannot update TEXT/IMAGE column(s) without a primary key"
+ $self->throw_exception('Cannot update TEXT/IMAGE column(s) without a primary key')
unless @primary_cols;
- if ((grep { defined $row{$_} } @primary_cols) != @primary_cols) {
- croak "Cannot update TEXT/IMAGE column(s) without primary key values";
- }
+ $self->throw_exception('Cannot update TEXT/IMAGE column(s) without primary key values')
+ if ((grep { defined $row{$_} } @primary_cols) != @primary_cols);
for my $col (keys %$blob_cols) {
my $blob = $blob_cols->{$col};
$cursor->next;
my $sth = $cursor->sth;
+ if (not $sth) {
+
+ $self->throw_exception(
+ "Could not find row in table '$table' for blob update:\n"
+ . $self->_pretty_print (\%where)
+ );
+ }
+
eval {
do {
$sth->func('CS_GET', 1, 'ct_data_info') or die $sth->errstr;
$sth->finish if $sth;
if ($exception) {
if ($self->using_freetds) {
- croak (
+ $self->throw_exception (
'TEXT/IMAGE operation failed, probably because you are using FreeTDS: '
. $exception
);
} else {
- croak $exception;
+ $self->throw_exception($exception);
}
}
}
projects / dbsrgits/DBIx-Class.git / blobdiff