=head1 NAME
-DBIx::Class::Storage::DBI::Sybase - Storage::DBI subclass for Sybase
+DBIx::Class::Storage::DBI::Sybase - Sybase support for DBIx::Class
=head1 SYNOPSIS
But your queries will be cached.
-You need at least version C<1.09> of L<DBD::Sybase> for placeholder support.
-Otherwise your storage will be automatically reblessed into C<::NoBindVars>.
+You need a version of L<DBD::Sybase> compiled with the Sybase OpenClient
+libraries, B<NOT> FreeTDS, for placeholder support. Otherwise your storage will
+be automatically reblessed into C<::NoBindVars>.
-A recommended L<DBIx::Class::Storage::DBI/connect_info> settings:
+A recommended L<DBIx::Class::Storage::DBI/connect_info> setting:
- on_connect_call => [['datetime_setup'], [blob_setup => log_on_update => 0]]
+ on_connect_call => [['datetime_setup'], ['blob_setup', log_on_update => 0]]
=head1 METHODS
} else { # real Sybase
my $no_bind_vars = 'DBIx::Class::Storage::DBI::Sybase::NoBindVars';
- if (not $self->dbh->{syb_dynamic_supported}) {
- $self->ensure_class_loaded($no_bind_vars);
- bless $self, $no_bind_vars;
- $self->_rebless;
- }
-
- if ($DBD::Sybase::VERSION < 1.09) {
+ if ($self->_using_freetds) {
carp <<'EOF';
Your version of Sybase potentially supports placeholders and query caching,
-however your version of DBD::Sybase is too old to do this properly. Please
-upgrade to at least version 1.09 if you want this feature.
+however you seem to be using FreeTDS which does not (yet?) support this.
+
+Please recompile DBD::Sybase with the Sybase OpenClient libraries if you want
+these features.
-TEXT/IMAGE column support will also not work in older versions of DBD::Sybase.
+TEXT/IMAGE column support will also not work under FreeTDS.
See perldoc DBIx::Class::Storage::DBI::Sybase for more details.
EOF
bless $self, $no_bind_vars;
$self->_rebless;
}
+
+ if (not $self->dbh->{syb_dynamic_supported}) {
+ $self->ensure_class_loaded($no_bind_vars);
+ bless $self, $no_bind_vars;
+ $self->_rebless;
+ }
+
$self->_set_maxConnect;
}
}
}
+sub _using_freetds {
+ my $self = shift;
+
+ return $self->_dbh->{syb_oc_version} =~ /freetds/i;
+}
+
sub _set_maxConnect {
my $self = shift;
Used as:
- on_connect_call => [ [ blob_setup => log_on_update => 0 ] ]
+ on_connect_call => [ [ 'blob_setup', log_on_update => 0 ] ]
Does C<< $dbh->{syb_binary_images} = 1; >> to return C<IMAGE> data as raw binary
instead of as a hex string.
sub _is_lob_type {
my $self = shift;
my $type = shift;
- $type && $type =~ /(?:text|image|lob|bytea|binary)/i;
+ $type && $type =~ /(?:text|image|lob|bytea|binary|memo)/i;
}
## This will be useful if we ever implement BLOB filehandle inflation and will
## need to use the API, but for now it isn't.
#
#sub order_columns_for_select {
-# my ($self, $source) = @_;
+# my ($self, $source, $columns) = @_;
#
# my (@non_blobs, @blobs);
#
-# for my $col ($source->columns) {
+# for my $col (@$columns) {
# if ($self->_is_lob_type($source->column_info($col)->{data_type})) {
# push @blobs, $col;
# } else {
my $updated_cols = $self->next::method($source, $to_insert, @_);
- $self->_update_blobs($source, $blob_cols, $to_insert) if %$blob_cols;
+ $self->_insert_blobs($source, $blob_cols, $to_insert) if %$blob_cols;
return $updated_cols;
}
-#sub update {
-# my ($self, $source) = splice @_, 0, 2;
-# my ($fields) = @_;
-#
-# my $blob_cols = $self->_remove_blob_cols($source, $fields);
-#
-# my @res = 1;
-#
-# if (%$fields) {
-# if (wantarray) {
-# @res = $self->next::method($source, @_);
-# } else {
-# $res[0] = $self->next::method($source, @_);
-# }
-# }
-#
-# $self->_update_blobs($source, $blob_cols, $fields) if %$blob_cols;
-#
-# return wantarray ? @res : $res[0];
-#}
+sub update {
+ my ($self, $source) = splice @_, 0, 2;
+ my ($fields, $where) = @_;
+ my $wantarray = wantarray;
+
+ my $blob_cols = $self->_remove_blob_cols($source, $fields);
+
+ my @res;
+ if ($wantarray) {
+ @res = $self->next::method($source, @_);
+ } else {
+ $res[0] = $self->next::method($source, @_);
+ }
+
+ $self->_update_blobs($source, $blob_cols, $where) if %$blob_cols;
+
+ return $wantarray ? @res : $res[0];
+}
sub _remove_blob_cols {
my ($self, $source, $fields) = @_;
}
sub _update_blobs {
- my ($self, $source, $blob_cols, $inserted) = @_;
+ my ($self, $source, $blob_cols, $where) = @_;
+
+ my (@primary_cols) = $source->primary_columns;
+
+ croak "Cannot update TEXT/IMAGE column(s) without a primary key"
+ unless @primary_cols;
+
+# check if we're updating a single row by PK
+ my $pk_cols_in_where = 0;
+ for my $col (@primary_cols) {
+ $pk_cols_in_where++ if defined $where->{$col};
+ }
+ my @rows;
+
+ if ($pk_cols_in_where == @primary_cols) {
+ my %row_to_update;
+ @row_to_update{@primary_cols} = @{$where}{@primary_cols};
+ @rows = \%row_to_update;
+ } else {
+ my $rs = $source->resultset->search(
+ $where,
+ {
+ result_class => 'DBIx::Class::ResultClass::HashRefInflator',
+ select => \@primary_cols
+ }
+ );
+ @rows = $rs->all; # statement must finish
+ }
+
+ for my $row (@rows) {
+ $self->_insert_blobs($source, $blob_cols, $row);
+ }
+}
+
+sub _insert_blobs {
+ my ($self, $source, $blob_cols, $row) = @_;
my $dbh = $self->dbh;
my $table = $source->from;
- my %inserted = %$inserted;
+ my %row = %$row;
my (@primary_cols) = $source->primary_columns;
croak "Cannot update TEXT/IMAGE column(s) without a primary key"
unless @primary_cols;
- if ((grep { defined $inserted{$_} } @primary_cols) != @primary_cols) {
+ if ((grep { defined $row{$_} } @primary_cols) != @primary_cols) {
if (@primary_cols == 1) {
my $col = $primary_cols[0];
- $inserted{$col} = $self->last_insert_id($source, $col);
+ $row{$col} = $self->last_insert_id($source, $col);
} else {
croak "Cannot update TEXT/IMAGE column(s) without primary key values";
}
$sth = $self->sth(
"select $col from $table where $search_cond"
);
- $sth->execute(map $inserted{$_}, @primary_cols);
+ $sth->execute(map $row{$_}, @primary_cols);
} else {
- my $search_cond = join ',' => map "$_ = $inserted{$_}", @primary_cols;
+ my $search_cond = join ',' => map "$_ = $row{$_}", @primary_cols;
$sth = $dbh->prepare(
"select $col from $table where $search_cond"
=head1 IMAGE AND TEXT COLUMNS
-You need at least version C<1.09> of L<DBD::Sybase> for C<TEXT/IMAGE> column
-support.
+L<DBD::Sybase> compiled with FreeTDS will B<NOT> work with C<TEXT/IMAGE>
+columns.
See L</connect_call_blob_setup> for a L<DBIx::Class::Storage::DBI/connect_info>
setting you need to work with C<IMAGE> columns.
projects / dbsrgits/DBIx-Class.git / blobdiff