__PACKAGE__->mk_group_accessors('simple' =>
qw/_identity _blob_log_on_update _writer_storage _is_extra_storage
- _bulk_storage _is_bulk_storage _began_bulk_work
+ _bulk_storage _is_bulk_storage _began_bulk_work
_bulk_disabled_due_to_coderef_connect_info_warned
_identity_method/
);
# this is why
$bulk_storage->_dbi_connect_info->[0] .= ';bulkLogin=1';
-
+
$self->_bulk_storage($bulk_storage);
}
my $is_identity_update = $identity_col && defined $fields->{$identity_col};
if (not $blob_cols) {
- $self->_set_identity_insert($table, 'update') if $is_identity_update;
+ $self->_set_session_identity(UPDATE => $table, 'ON')
+ if $is_identity_update;
+
return $self->next::method(@_);
- $self->_unset_identity_insert($table, 'update') if $is_identity_update;
- }
-# check that we're not updating a blob column that's also in $where
- for my $blob (grep $self->_is_lob_column($source, $_), $source->columns) {
- if (exists $where->{$blob} && exists $fields->{$blob}) {
- croak
-'Update of TEXT/IMAGE column that is also in search condition impossible';
- }
+ $self->_set_session_identity(UPDATE => $table, 'OFF')
+ if $is_identity_update;
}
+# If there are any blobs in $where, Sybase will return a descriptive error
+# message.
+
# update+blob update(s) done atomically on separate connection
$self = $self->_writer_storage;
my @res;
if (%$fields) {
- $self->_set_identity_insert($table, 'update') if $is_identity_update;
+ $self->_set_session_identity(UPDATE => $table, 'ON')
+ if $is_identity_update;
if ($wantarray) {
@res = $self->next::method(@_);
$self->next::method(@_);
}
- $self->_unset_identity_insert($table, 'update') if $is_identity_update;
+ $self->_set_session_identity(UPDATE => $table, 'OFF')
+ if $is_identity_update;
}
$guard->commit;
return $wantarray ? @res : $res[0];
}
-### the insert_bulk partially stolen from DBI/MSSQL.pm
-
-sub _set_identity_insert {
- my ($self, $table, $op) = @_;
+# for IDENTITY_INSERT / IDENTITY_UPDATE
+sub _set_session_identity {
+ my ($self, $op, $table, $off_on) = @_;
my $sql = sprintf (
- 'SET IDENTITY_%s %s ON',
- (uc($op) || 'INSERT'),
- $self->sql_maker->_quote ($table),
+ 'SET IDENTITY_%s %s %s',
+ uc $op,
+ $self->sql_maker->_quote($table),
+ uc $off_on,
);
$self->_query_start($sql);
my $dbh = $self->_get_dbh;
- eval { $dbh->do ($sql) };
+ eval {
+ local $dbh->{RaiseError} = 1;
+ local $dbh->{PrintError} = 0;
+ $dbh->do ($sql)
+ };
my $exception = $@;
$self->_query_end($sql);
if ($exception) {
$self->throw_exception (sprintf "Error executing '%s': %s",
$sql,
- $dbh->errstr,
+ $exception,
);
}
}
-sub _unset_identity_insert {
- my ($self, $table, $op) = @_;
-
- my $sql = sprintf (
- 'SET IDENTITY_%s %s OFF',
- (uc($op) || 'INSERT'),
- $self->sql_maker->_quote ($table),
- );
-
- $self->_query_start($sql);
-
- my $dbh = $self->_get_dbh;
- $dbh->do ($sql);
-
- $self->_query_end($sql);
-}
-
-# for tests
-sub _can_insert_bulk { 1 }
-
sub insert_bulk {
my $self = shift;
my ($source, $cols, $data) = @_;
my @source_columns = $source->columns;
my $use_bulk_api =
- $self->_bulk_storage &&
+ $self->_bulk_storage &&
$self->_get_dbh->{syb_has_blk};
if ((not $use_bulk_api) &&
if (not $use_bulk_api) {
my $blob_cols = $self->_remove_blob_cols_array($source, $cols, $data);
- my $dumb_last_insert_id =
- $identity_col
- && (not $is_identity_insert)
- && ($self->_identity_method||'') ne '@@IDENTITY';
-
($self, my ($guard)) = do {
- if ($self->{transaction_depth} == 0 &&
- ($blob_cols || $dumb_last_insert_id)) {
+ if ($self->{transaction_depth} == 0 && $blob_cols) {
($self->_writer_storage, $self->_writer_storage->txn_scope_guard);
}
else {
}
};
- $self->_set_identity_insert ($source->name) if $is_identity_insert;
$self->next::method(@_);
- $self->_unset_identity_insert ($source->name) if $is_identity_insert;
if ($blob_cols) {
if ($is_identity_insert) {
return 1 if $errno == 36;
- carp
+ carp
"Layer: $layer, Origin: $origin, Severity: $severity, Error: $errno" .
($errmsg ? "\n$errmsg" : '') .
($osmsg ? "\n$osmsg" : '') .
($blkmsg ? "\n$blkmsg" : '');
-
+
return 0;
});
# $bulk->next::method($source, \@source_columns, \@new_data, {
# syb_bcp_attribs => {
# identity_flag => $is_identity_insert,
-# identity_column => $identity_idx,
+# identity_column => $identity_idx,
# }
# });
my $sql = 'INSERT INTO ' .
{
syb_bcp_attribs => {
identity_flag => $is_identity_insert,
- identity_column => $identity_idx,
+ identity_column => $identity_idx,
}
}
);
my (@primary_cols) = $source->primary_columns;
- croak "Cannot update TEXT/IMAGE column(s) without a primary key"
+ $self->throw_exception('Cannot update TEXT/IMAGE column(s) without a primary key')
unless @primary_cols;
# check if we're updating a single row by PK
my %row = %$row;
my (@primary_cols) = $source->primary_columns;
- croak "Cannot update TEXT/IMAGE column(s) without a primary key"
+ $self->throw_exception('Cannot update TEXT/IMAGE column(s) without a primary key')
unless @primary_cols;
- if ((grep { defined $row{$_} } @primary_cols) != @primary_cols) {
- croak "Cannot update TEXT/IMAGE column(s) without primary key values";
- }
+ $self->throw_exception('Cannot update TEXT/IMAGE column(s) without primary key values')
+ if ((grep { defined $row{$_} } @primary_cols) != @primary_cols);
for my $col (keys %$blob_cols) {
my $blob = $blob_cols->{$col};
$sth->finish if $sth;
if ($exception) {
if ($self->using_freetds) {
- croak (
+ $self->throw_exception (
'TEXT/IMAGE operation failed, probably because you are using FreeTDS: '
. $exception
);
} else {
- croak $exception;
+ $self->throw_exception($exception);
}
}
}
=head1 TRANSACTIONS
Due to limitations of the TDS protocol, L<DBD::Sybase>, or both; you cannot
-begin a transaction while there are active cursors. An active cursor is, for
-example, a L<ResultSet|DBIx::Class::ResultSet> that has been executed using
-C<next> or C<first> but has not been exhausted or
-L<reset|DBIx::Class::ResultSet/reset>.
+begin a transaction while there are active cursors; nor can you use multiple
+active cursors within a transaction. An active cursor is, for example, a
+L<ResultSet|DBIx::Class::ResultSet> that has been executed using C<next> or
+C<first> but has not been exhausted or L<reset|DBIx::Class::ResultSet/reset>.
For example, this will not work:
}
});
+This won't either:
+
+ my $first_row = $large_rs->first;
+ $schema->txn_do(sub { ... });
+
Transactions done for inserts in C<AutoCommit> mode when placeholders are in use
are not affected, as they are done on an extra database handle.
projects / dbsrgits/DBIx-Class.git / blobdiff