use mro 'c3';
use Carp::Clan qw/^DBIx::Class/;
use List::Util ();
+use Sub::Name ();
__PACKAGE__->mk_group_accessors('simple' =>
- qw/_identity _blob_log_on_update _insert_dbh _identity_method/
+ qw/_identity _blob_log_on_update _writer_storage _is_writer_storage
+ _identity_method/
);
+my @also_proxy_to_writer_storage = qw/
+ disconnect _connect_info _sql_maker _sql_maker_opts disable_sth_caching
+ auto_savepoint unsafe cursor_class debug debugobj schema
+/;
+
=head1 NAME
DBIx::Class::Storage::DBI::Sybase - Sybase support for DBIx::Class
# based on LongReadLen in connect_info
$self->set_textsize if $self->using_freetds;
+
+# create storage for insert/(update blob) transactions,
+# unless this is that storage
+ return if $self->_is_writer_storage;
+
+ my $writer_storage = (ref $self)->new;
+
+ $writer_storage->_is_writer_storage(1);
+ $writer_storage->connect_info($self->connect_info);
+
+ $self->_writer_storage($writer_storage);
+}
+
+for my $method (@also_proxy_to_writer_storage) {
+ no strict 'refs';
+
+ my $replaced = __PACKAGE__->can($method);
+
+ *{$method} = Sub::Name::subname __PACKAGE__."::$method" => sub {
+ my $self = shift;
+ $self->_writer_storage->$replaced(@_) if $self->_writer_storage;
+ return $self->$replaced(@_);
+ };
}
# Make sure we have CHAINED mode turned on if AutoCommit is off in non-FreeTDS
sub _fetch_identity_sql {
my ($self, $source, $col) = @_;
- return "SELECT MAX($col) FROM ".$source->from;
+ return sprintf ("SELECT MAX(%s) FROM %s",
+ map { $self->sql_maker->_quote ($_) } ($col, $source->from)
+ );
}
sub _execute {
my $blob_cols = $self->_remove_blob_cols($source, $to_insert);
-# insert+blob insert done atomically, on _insert_dbh
- (my ($guard), local ($self->{_dbh})) = do {
- $self->_insert_dbh($self->_connect(@{ $self->_dbi_connect_info }))
- unless $self->_insert_dbh;
-
- my $new_guard = $self->txn_scope_guard;
-
-# _dbh_begin_work may reconnect, if so we need to update _insert_dbh
- $self->_insert_dbh($self->_dbh);
+ my $identity_col = List::Util::first
+ { $source->column_info($_)->{is_auto_increment} }
+ $source->columns;
- ($new_guard, $self->_insert_dbh)
- } if $blob_cols;
+ # do we need the horrific SELECT MAX(COL) hack?
+ my $dumb_last_insert_id =
+ $identity_col
+ && (not exists $to_insert->{$identity_col})
+ && ($self->_identity_method||'') ne '@@IDENTITY';
+
+ my $next = $self->next::can;
+
+ # we are already in a transaction, or there are no blobs
+ # and we don't need the PK - just (try to) do it
+ if ($self->{transaction_depth}
+ || (!$blob_cols && !$dumb_last_insert_id)
+ ) {
+ return $self->_insert (
+ $next, $source, $to_insert, $blob_cols, $identity_col
+ );
+ }
- my $need_last_insert_id = 0;
+ # otherwise use the _writer_storage to do the insert+transaction on another
+ # connection
+ my $guard = $self->_writer_storage->txn_scope_guard;
- my ($identity_col) =
- map $_->[0],
- grep $_->[1]{is_auto_increment},
- map [ $_, $source->column_info($_) ],
- $source->columns;
+ my $updated_cols = $self->_writer_storage->_insert (
+ $next, $source, $to_insert, $blob_cols, $identity_col
+ );
- $need_last_insert_id = 1
- if $identity_col && (not exists $to_insert->{$identity_col});
+ $self->_identity($self->_writer_storage->_identity);
- # We have to do the insert in a transaction to avoid race conditions with the
- # SELECT MAX(COL) identity method used when placeholders are enabled.
- my $updated_cols = do {
- no warnings 'uninitialized';
- if (
- $need_last_insert_id &&
- $self->_identity_method ne '@@IDENTITY' &&
- !$self->{transaction_depth}
- ) {
- $self->_insert_dbh($self->_connect(@{ $self->_dbi_connect_info }))
- unless $self->_insert_dbh;
- local $self->{_dbh} = $self->_insert_dbh;
+ $guard->commit;
- my $guard = $self->txn_scope_guard;
+ return $updated_cols;
+}
-# _dbh_begin_work may reconnect, if so we need to update _insert_dbh
- $self->_insert_dbh($self->_dbh);
+sub _insert {
+ my ($self, $next, $source, $to_insert, $blob_cols, $identity_col) = @_;
- my $upd_cols = $self->next::method (@_);
- $guard->commit;
+ my $updated_cols = $self->$next ($source, $to_insert);
- $upd_cols;
- }
- else {
- $self->next::method(@_);
- }
+ my $final_row = {
+ $identity_col => $self->last_insert_id($source, $identity_col),
+ %$to_insert,
+ %$updated_cols,
};
- $self->_insert_blobs($source, $blob_cols, $to_insert) if $blob_cols;
-
- $guard->commit if $guard;
+ $self->_insert_blobs ($source, $blob_cols, $final_row) if $blob_cols;
return $updated_cols;
}
my ($source, $fields, $where) = @_;
my $wantarray = wantarray;
-
my $blob_cols = $self->_remove_blob_cols($source, $fields);
-# update+blob update(s) done atomically
- my $guard = $self->txn_scope_guard if $blob_cols;
+ if (not $blob_cols) {
+ return $self->next::method(@_);
+ }
+
+# update+blob update(s) done atomically on separate connection
+ $self = $self->_writer_storage;
+
+ my $guard = $self->txn_scope_guard;
my @res;
if ($wantarray) {
$self->next::method(@_);
}
- $self->_update_blobs($source, $blob_cols, $where) if $blob_cols;
+ $self->_update_blobs($source, $blob_cols, $where);
- $guard->commit if $guard;
+ $guard->commit;
return $wantarray ? @res : $res[0];
}
+### the insert_bulk stuff stolen from DBI/MSSQL.pm
+
+sub _set_identity_insert {
+ my ($self, $table) = @_;
+
+ my $sql = sprintf (
+ 'SET IDENTITY_INSERT %s ON',
+ $self->sql_maker->_quote ($table),
+ );
+
+ my $dbh = $self->_get_dbh;
+ eval { $dbh->do ($sql) };
+ if ($@) {
+ $self->throw_exception (sprintf "Error executing '%s': %s",
+ $sql,
+ $dbh->errstr,
+ );
+ }
+}
+
+sub _unset_identity_insert {
+ my ($self, $table) = @_;
+
+ my $sql = sprintf (
+ 'SET IDENTITY_INSERT %s OFF',
+ $self->sql_maker->_quote ($table),
+ );
+
+ my $dbh = $self->_get_dbh;
+ $dbh->do ($sql);
+}
+
+# XXX this should use the DBD::Sybase bulk API, where possible
+sub insert_bulk {
+ my $self = shift;
+ my ($source, $cols, $data) = @_;
+
+ my $is_identity_insert = (List::Util::first
+ { $source->column_info ($_)->{is_auto_increment} }
+ (@{$cols})
+ )
+ ? 1
+ : 0;
+
+ if ($is_identity_insert) {
+ $self->_set_identity_insert ($source->name);
+ }
+
+ $self->next::method(@_);
+
+ if ($is_identity_insert) {
+ $self->_unset_identity_insert ($source->name);
+ }
+}
+
+### end of stolen insert_bulk section
+
sub _remove_blob_cols {
my ($self, $source, $fields) = @_;
@row_to_update{@primary_cols} = @{$where}{@primary_cols};
@rows = \%row_to_update;
} else {
- my $rs = $source->resultset->search(
- $where,
- {
- result_class => 'DBIx::Class::ResultClass::HashRefInflator',
- select => \@primary_cols
- }
- );
- @rows = $rs->all; # statement must finish
+ my $cursor = $self->select ($source, \@primary_cols, $where, {});
+ @rows = map {
+ my %row; @row{@primary_cols} = @$_; \%row
+ } $cursor->all;
}
for my $row (@rows) {
unless @primary_cols;
if ((grep { defined $row{$_} } @primary_cols) != @primary_cols) {
- if (@primary_cols == 1) {
- my $col = $primary_cols[0];
- $row{$col} = $self->last_insert_id($source, $col);
- } else {
- croak "Cannot update TEXT/IMAGE column(s) without primary key values";
- }
+ croak "Cannot update TEXT/IMAGE column(s) without primary key values";
}
for my $col (keys %$blob_cols) {
my $blob = $blob_cols->{$col};
my %where = map { ($_, $row{$_}) } @primary_cols;
- my $cursor = $source->resultset->search(\%where, {
- select => [$col]
- })->cursor;
+
+ my $cursor = $self->select ($source, [$col], \%where, {});
$cursor->next;
my $sth = $cursor->sth;
C<SELECT MAX(col)>, which is the only way to get the C<IDENTITY> value in this
mode.
+In addition, they are done on a separate connection so that it's possible to
+have active cursors when doing an insert.
+
When using C<DBIx::Class::Storage::DBI::Sybase::NoBindVars> transactions are
disabled, as there are no concurrency issues with C<SELECT @@IDENTITY> as it's a
session variable.
});
Transactions done for inserts in C<AutoCommit> mode when placeholders are in use
-are not affected, as they use an extra database handle to do the insert.
+are not affected, as they are done on an extra database handle.
Some workarounds:
projects / dbsrgits/DBIx-Class.git / blobdiff