use base qw/DBIx::Class::Storage::DBI/;
use mro 'c3';
+use DBIx::Class::_Util 'modver_gt_or_eq';
use DBIx::Class::Carp;
use Try::Tiny;
use namespace::clean;
described in L<RT#79576|https://rt.cpan.org/Public/Bug/Display.html?id=79576>.
In order to trigger the bug condition one needs to supply B<more than one>
-bind value that is an object with overloaded stringification (nummification
+bind value that is an object with overloaded stringification (numification
is not relevant, only stringification is). When this is the case the internal
DBIx::Class call to C<< $sth->bind_param >> would be executed in a way that
triggers the above-mentioned DBD::SQLite bug. As a result all the logs and
pointing to this section. This warning will be removed 2 years from now,
around April 2015, You can disable it after you've audited your data by
setting the C<DBIC_RT79576_NOWARN> environment variable. Note - the warning
-is emited only once per callsite per process and only when the condition in
-question is encountered. Thus it is very unlikey that your logsystem will be
+is emitted only once per callsite per process and only when the condition in
+question is encountered. Thus it is very unlikely that your logsystem will be
flooded as a result of this.
=back
return undef unless $dbh->FETCH('Active');
return undef unless $dbh->ping;
- # since we do not have access to sqlite3_get_autocommit(), do a trick
- # to attempt to *safely* determine what state are we *actually* in.
- # FIXME
- # also using T::T here leads to bizarre leaks - will figure it out later
- my $really_not_in_txn = do {
- local $@;
-
- # older versions of DBD::SQLite do not properly detect multiline BEGIN/COMMIT
- # statements to adjust their {AutoCommit} state. Hence use such a statement
- # pair here as well, in order to escape from poking {AutoCommit} needlessly
- # https://rt.cpan.org/Public/Bug/Display.html?id=80087
- eval {
- # will fail instantly if already in a txn
- $dbh->do("-- multiline\nBEGIN");
- $dbh->do("-- multiline\nCOMMIT");
- 1;
- } or do {
- ($@ =~ /transaction within a transaction/)
- ? 0
- : undef
- ;
- };
- };
-
my $ping_fail;
- # if we were unable to determine this - we may very well be dead
- if (not defined $really_not_in_txn) {
- $ping_fail = 1;
- }
- # check the AC sync-state
- elsif ($really_not_in_txn xor $dbh->{AutoCommit}) {
- carp_unique (sprintf
- 'Internal transaction state of handle %s (apparently %s a transaction) does not seem to '
- . 'match its AutoCommit attribute setting of %s - this is an indication of a '
- . 'potentially serious bug in your transaction handling logic',
- $dbh,
- $really_not_in_txn ? 'NOT in' : 'in',
- $dbh->{AutoCommit} ? 'TRUE' : 'FALSE',
- );
-
- # it is too dangerous to execute anything else in this state
- # assume everything works (safer - worst case scenario next statement throws)
- return 1;
- }
- else {
- # do the actual test
- $ping_fail = ! try { $dbh->do('SELECT * FROM sqlite_master LIMIT 1'); 1 };
+ # older DBD::SQLite does not properly synchronize commit state between
+ # the libsqlite and the $dbh
+ unless (defined $DBD::SQLite::__DBIC_TXN_SYNC_SANE__) {
+ $DBD::SQLite::__DBIC_TXN_SYNC_SANE__ = modver_gt_or_eq('DBD::SQLite', '1.38_02');
}
- if ($ping_fail) {
- # it is possible to have a proper "connection", and have "ping" return
- # false anyway (e.g. corrupted file). In such cases DBD::SQLite still
- # keeps the actual file handle open. We don't really want this to happen,
- # so force-close the handle via DBI itself
- #
- local $@; # so that we do not clober the real error as set above
- eval { $dbh->disconnect }; # if it fails - it fails
- return undef # the actual RV of _ping()
- }
- else {
- return 1;
+ # fallback to travesty
+ unless ($DBD::SQLite::__DBIC_TXN_SYNC_SANE__) {
+ # since we do not have access to sqlite3_get_autocommit(), do a trick
+ # to attempt to *safely* determine what state are we *actually* in.
+ # FIXME
+ # also using T::T here leads to bizarre leaks - will figure it out later
+ my $really_not_in_txn = do {
+ local $@;
+
+ # older versions of DBD::SQLite do not properly detect multiline BEGIN/COMMIT
+ # statements to adjust their {AutoCommit} state. Hence use such a statement
+ # pair here as well, in order to escape from poking {AutoCommit} needlessly
+ # https://rt.cpan.org/Public/Bug/Display.html?id=80087
+ eval {
+ # will fail instantly if already in a txn
+ $dbh->do("-- multiline\nBEGIN");
+ $dbh->do("-- multiline\nCOMMIT");
+ 1;
+ } or do {
+ ($@ =~ /transaction within a transaction/)
+ ? 0
+ : undef
+ ;
+ };
+ };
+
+ # if we were unable to determine this - we may very well be dead
+ if (not defined $really_not_in_txn) {
+ $ping_fail = 1;
+ }
+ # check the AC sync-state
+ elsif ($really_not_in_txn xor $dbh->{AutoCommit}) {
+ carp_unique (sprintf
+ 'Internal transaction state of handle %s (apparently %s a transaction) does not seem to '
+ . 'match its AutoCommit attribute setting of %s - this is an indication of a '
+ . 'potentially serious bug in your transaction handling logic',
+ $dbh,
+ $really_not_in_txn ? 'NOT in' : 'in',
+ $dbh->{AutoCommit} ? 'TRUE' : 'FALSE',
+ );
+
+ # it is too dangerous to execute anything else in this state
+ # assume everything works (safer - worst case scenario next statement throws)
+ return 1;
+ }
}
+
+ # do the actual test and return on no failure
+ ( $ping_fail ||= ! try { $dbh->do('SELECT * FROM sqlite_master LIMIT 1'); 1 } )
+ or return 1; # the actual RV of _ping()
+
+ # ping failed (or so it seems) - need to do some cleanup
+ # it is possible to have a proper "connection", and have "ping" return
+ # false anyway (e.g. corrupted file). In such cases DBD::SQLite still
+ # keeps the actual file handle open. We don't really want this to happen,
+ # so force-close the handle via DBI itself
+ #
+ local $@; # so that we do not clobber the real error as set above
+ eval { $dbh->disconnect }; # if it fails - it fails
+ undef; # the actual RV of _ping()
}
sub deployment_statements {
$sqltargs->{producer_args}{sqlite_version} = $dver;
}
+ $sqltargs->{quote_identifiers}
+ = !!$self->sql_maker->_quote_chars
+ if ! exists $sqltargs->{quote_identifiers};
+
$self->next::method($schema, $type, $version, $dir, $sqltargs, @rest);
}
}
# DBD::SQLite (at least up to version 1.31 has a bug where it will
-# non-fatally nummify a string value bound as an integer, resulting
+# non-fatally numify a string value bound as an integer, resulting
# in insertions of '0' into supposed-to-be-numeric fields
# Since this can result in severe data inconsistency, remove the
-# bind attr if such a sitation is detected
+# bind attr if such a situation is detected
#
# FIXME - when a DBD::SQLite version is released that eventually fixes
-# this sutiation (somehow) - no-op this override once a proper DBD
+# this situation (somehow) - no-op this override once a proper DBD
# version is detected
sub _dbi_attrs_for_bind {
my ($self, $ident, $bind) = @_;
# 0.08191 and 0.08209 inclusive (fixed in 0.08210 and higher)
my $stringifiable = 0;
- for (0.. $#$bindattrs) {
+ for my $i (0.. $#$bindattrs) {
- $stringifiable++ if ( length ref $bind->[$_][1] and overload::Method($bind->[$_][1], '""') );
+ $stringifiable++ if ( length ref $bind->[$i][1] and overload::Method($bind->[$i][1], '""') );
if (
- defined $bindattrs->[$_]
+ defined $bindattrs->[$i]
and
- defined $bind->[$_][1]
+ defined $bind->[$i][1]
and
- $bindattrs->[$_] eq DBI::SQL_INTEGER()
+ grep { $bindattrs->[$i] eq $_ } (
+ DBI::SQL_INTEGER(), DBI::SQL_TINYINT(), DBI::SQL_SMALLINT(), DBI::SQL_BIGINT()
+ )
and
- $bind->[$_][1] !~ /^ [\+\-]? [0-9]+ (?: \. 0* )? $/x
+ $bind->[$i][1] !~ /^ [\+\-]? [0-9]+ (?: \. 0* )? $/x
) {
carp_unique( sprintf (
"Non-integer value supplied for column '%s' despite the integer datatype",
- $bind->[$_][0]{dbic_colname} || "# $_"
+ $bind->[$i][0]{dbic_colname} || "# $i"
) );
- undef $bindattrs->[$_];
+ undef $bindattrs->[$i];
}
}
projects / dbsrgits/DBIx-Class.git / blobdiff