because this actually works

[dbsrgits/DBIx-Class.git] / lib / DBIx / Class / Storage / DBI / NoBindVars.pm

diff --git a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
index 73c7b43..09a45f6 100644 (file)
--- a/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
+++ b/lib/DBIx/Class/Storage/DBI/NoBindVars.pm
@@ -5,6 +5,35 @@ use warnings;
 
 use base 'DBIx::Class::Storage::DBI';
 
+=head1 NAME 
+
+DBIx::Class::Storage::DBI::NoBindVars - Sometime DBDs have poor to no support for bind variables
+
+=head1 DESCRIPTION
+
+This class allows queries to work when the DBD or underlying library does not
+support the usual C<?> placeholders, or at least doesn't support them very
+well, as is the case with L<DBD::Sybase>
+
+=head1 METHODS
+
+=head2 sth
+
+Uses C<prepare> instead of the usual C<prepare_cached>, seeing as we can't cache very effectively without bind variables.
+
+=cut
+
+sub sth {
+  my ($self, $sql) = @_;
+  return $self->dbh->prepare($sql);
+}
+
+=head2 _execute
+
+Manually subs in the values for the usual C<?> placeholders before calling L</sth> on the generated SQL.
+
+=cut
+
 sub _execute {
   my ($self, $op, $extra_bind, $ident, @args) = @_;
   my ($sql, @bind) = $self->sql_maker->$op($ident, @args);
@@ -14,10 +43,7 @@ sub _execute {
     $self->debugobj->query_start($sql, @debug_bind);
   }
 
-  while(my $bvar = shift @bind) {
-    $bvar = $self->dbh->quote($bvar);
-    $sql =~ s/\?/$bvar/;
-  }
+  $sql =~ s/\?/shift(@bind)/eg;
 
   my $sth = eval { $self->sth($sql,$op) };
 
@@ -45,23 +71,10 @@ sub _execute {
   return (wantarray ? ($rv, $sth, @bind) : $rv);
 }
 
-1;
-
-=head1 NAME 
-
-DBIx::Class::Storage::DBI::NoBindVars - Sometime DBDs have poor to no support for bind variables
-
-=head1 SYNOPSIS
-
-=head1 DESCRIPTION
-
-This class allows queries to work when the DBD or underlying library does not
-support the usual C<?> placeholders, or at least doesn't support them very
-well, as is the case with L<DBD::Sybase>
-
 =head1 AUTHORS
 
 Brandon Black <blblack@gmail.com>
+
 Trym Skaar <trym@tryms.no>
 
 =head1 LICENSE
@@ -69,3 +82,5 @@ Trym Skaar <trym@tryms.no>
 You may distribute this code under the same terms as Perl itself.
 
 =cut
+
+1;