package # Hide from PAUSE
DBIx::Class::SQLAHacks::Oracle;
+use warnings;
+use strict;
+
use base qw( DBIx::Class::SQLAHacks );
use Carp::Clan qw/^DBIx::Class|^SQL::Abstract/;
#
# TODO:
-# - Problems with such statements: parentid != PRIOR artistid
-# - Check the parameter syntax of connect_by
-# - Review review by experienced DBIC/SQL:A developers :-)
+# - Review by experienced DBIC/SQL:A developers :-)
+# - Problem with count and connect_by look the TODO in t/73oracle.t
#
sub new {
- my $self = shift->SUPER::new(@_);
-
- push @{ $self->{unary_ops} },{
- regex => qr/^prior$/,
- handler => '_prior_as_unary_op',
- };
-
- push @{ $self->{special_ops} },{
- regex => qr/^prior$/,
- handler => '_prior_as_special_op',
+ my $self = shift;
+ my %opts = (ref $_[0] eq 'HASH') ? %{$_[0]} : @_;
+ push @{$opts{special_ops}}, {
+ regex => qr/^prior$/i,
+ handler => '_where_field_PRIOR',
};
- return $self;
+ $self->SUPER::new (\%opts);
}
-
sub select {
my ($self, $table, $fields, $where, $order, @rest) = @_;
$sql .= $self->_sqlcase(' start with ') . $ws;
push @bind, @wb;
}
- if ( my $connect_by = $attrs->{'connect_by'}) {
+ if ( my $connect_by = $attrs->{'connect_by'} ) {
my ($connect_by_sql, @connect_by_sql_bind) = $self->_recurse_where( $attrs->{'connect_by'} );
$sql .= sprintf(" %s %s",
- $self->_sqlcase('connect by'),
+ ( $attrs->{'nocycle'} ) ? $self->_sqlcase('connect by nocycle')
+ : $self->_sqlcase('connect by'),
$connect_by_sql,
);
push @bind, @connect_by_sql_bind;
}
sub _order_siblings_by {
- my $self = shift;
- my $ref = ref $_[0];
+ my ( $self, $arg ) = @_;
+
+ my ( @sql, @bind );
+ for my $c ( $self->_order_by_chunks($arg) ) {
+ $self->_SWITCH_refkind(
+ $c,
+ {
+ SCALAR => sub { push @sql, $c },
+ ARRAYREF => sub { push @sql, shift @$c; push @bind, @$c },
+ }
+ );
+ }
- my @vals = $ref eq 'ARRAY' ? @{$_[0]} :
- $ref eq 'SCALAR' ? ${$_[0]} :
- $ref eq '' ? $_[0] :
- puke( "Unsupported data struct $ref for ORDER SIBILINGS BY" );
+ my $sql =
+ @sql
+ ? sprintf( '%s %s', $self->_sqlcase(' order siblings by'), join( ', ', @sql ) )
+ : '';
- my $val = join ', ', map { $self->_quote($_) } @vals;
- return $val ? $self->_sqlcase(' order siblings by')." $val" : '';
+ return wantarray ? ( $sql, @bind ) : $sql;
}
-sub _prior_as_special_op {
- my ( $self, $field, $op, $arg ) = @_;
-
- my ( $label, $and, $placeholder );
- $label = $self->_convert( $self->_quote($field) );
- $and = ' ' . $self->_sqlcase('and') . ' ';
- $placeholder = $self->_convert('?');
-
- # TODO: $op is prior, and not the operator
- $op = $self->_sqlcase('=');
-
- my ( $sql, @bind ) = $self->_SWITCH_refkind(
- $arg,
- {
- SCALARREF => sub {
- my $sql = sprintf( "%s %s PRIOR %s", $label, $op, $$arg );
- return $sql;
- },
- SCALAR => sub {
- my $sql = sprintf( "%s %s PRIOR %s", $label, $op, $placeholder );
- return ( $sql, $arg );
- },
- HASHREF => sub { # case { '-prior' => { '=<' => 'nwiger'} }
- # no _convert and _quote from SCALARREF
- my ( $sql, @bind ) = $self->_where_hashpair_HASHREF( $field, $arg, $op );
- $sql = sprintf( " PRIOR %s", $sql );
- return ( $sql, @bind );
- },
- FALLBACK => sub {
- # TODO
- $self->puke(" wrong way... :/");
- },
- }
- );
- return ( $sql, @bind );
-}
+# we need to add a '=' only when PRIOR is used against a column diretly
+# i.e. when it is invoked by a special_op callback
+sub _where_field_PRIOR {
+ my ($self, $lhs, $op, $rhs) = @_;
+ my ($sql, @bind) = $self->_recurse_where ($rhs);
-sub _prior_as_unary_op {
- my ( $self, $op, $arg ) = @_;
-
- my $placeholder = $self->_convert('?');
- my $and = ' ' . $self->_sqlcase('and') . ' ';
-
- my ( $sql, @bind ) = $self->_SWITCH_refkind(
- $arg,
- {
- ARRAYREF => sub {
- $self->puke("special op 'prior' accepts an arrayref with exactly two values")
- if @$arg != 2;
-
- my ( @all_sql, @all_bind );
-
- foreach my $val ( @{$arg} ) {
- my ( $sql, @bind ) = $self->_SWITCH_refkind($val,
- {
- SCALAR => sub {
- return ( $placeholder, ($val) );
- },
- SCALARREF => sub {
- return ( $$val, () );
- },
- }
- );
- push @all_sql, $sql;
- push @all_bind, @bind;
- }
- my $sql = sprintf("PRIOR %s ",join $self->_sqlcase('='), @all_sql);
- return ($sql,@all_bind);
- },
- FALLBACK => sub {
-
- # TODO
- $self->puke(" wrong way... :/ ");
- },
- }
- );
- return ( $sql, @bind );
-};
+ $sql = sprintf ('%s = %s %s ',
+ $self->_convert($self->_quote($lhs)),
+ $self->_sqlcase ($op),
+ $sql
+ );
+
+ return ($sql, @bind);
+}
1;