}
else {
my $us = $rsrc->source_name;
- $self->throw_exception ("'$us' neither depends nor is depended on by '$relname', something is wrong...");
+ $self->throw_exception (
+ "Unable to determine relationship '$relname' direction from '$us', "
+ . "possibly due to a missing reverse-relationship on '$relname' to '$us'."
+ );
}
}
my $updated_cols = $source->storage->insert(
$source,
{ $self->get_columns },
- (keys %auto_pri) && $source->storage->_supports_insert_returning
+ (keys %auto_pri) && $source->storage->_use_insert_returning
? { returning => [ sort { $auto_pri{$a} <=> $auto_pri{$b} } keys %auto_pri ] }
: ()
,
$self->in_storage(1);
delete $self->{_orig_ident};
+ delete $self->{_orig_ident_failreason};
delete $self->{_ignore_at_insert};
$rollback_guard->commit if $rollback_guard;
$self->throw_exception( "Not in database" ) unless $self->in_storage;
- $self->throw_exception('Unable to update a row with incomplete or no identity')
+ $self->throw_exception($self->{_orig_ident_failreason})
if ! keys %$ident_cond;
my $rows = $self->result_source->storage->update(
$self->throw_exception( "Not in database" ) unless $self->in_storage;
my $ident_cond = $self->{_orig_ident} || $self->ident_condition;
- $self->throw_exception('Unable to delete a row with incomplete or no identity')
+ $self->throw_exception($self->{_orig_ident_failreason})
if ! keys %$ident_cond;
$self->result_source->storage->delete(
$self->result_source, $ident_cond
);
- delete $self->{_orig_ident};
+ delete $self->{_orig_ident}; # no longer identifiable
$self->in_storage(undef);
}
else {
my $colinfo = $self->column_info ($column);
# cache for speed (the object may *not* have a resultsource instance)
- if (not defined $colinfo->{is_numeric} && $self->_source_handle) {
+ if (! defined $colinfo->{is_numeric} && $self->_source_handle) {
$colinfo->{is_numeric} =
$self->result_source->schema->storage->is_datatype_numeric ($colinfo->{data_type})
? 1
my ($self, $column, $new_value) = @_;
# if we can't get an ident condition on first try - mark the object as unidentifiable
- $self->{_orig_ident} ||= (try { $self->ident_condition }) || {};
+ # (by using an empty hashref) and store the error for further diag
+ unless ($self->{_orig_ident}) {
+ try {
+ $self->{_orig_ident} = $self->ident_condition
+ }
+ catch {
+ $self->{_orig_ident_failreason} = $_;
+ $self->{_orig_ident} = {};
+ };
+ }
my $old_value = $self->get_column($column);
$new_value = $self->store_column($column, $new_value);
my $ident_cond = $self->{_orig_ident} || $self->ident_condition;
- $self->throw_exception('Unable to requery a row with incomplete or no identity')
+ $self->throw_exception($self->{_orig_ident_failreason})
if ! keys %$ident_cond;
return $resultset->find($ident_cond);