1 # Test to ensure we get a consistent result set wether or not we use the
2 # prefetch option in combination rows (LIMIT).
10 plan $@ ? (skip_all => 'needs DBD::SQLite for testing') : (tests => 2);
12 my $schema = DBICTest->init_schema();
13 $schema->storage->debug(1);
14 my $no_prefetch = $schema->resultset('Artist')->search(
19 my $use_prefetch = $schema->resultset('Artist')->search(
27 my $no_prefetch_count = 0;
28 my $use_prefetch_count = 0;
30 is($no_prefetch->count, $use_prefetch->count, '$no_prefetch->count == $use_prefetch->count');
33 local $TODO = "This is a difficult bug to fix, workaround is not to use prefetch with rows";
34 $no_prefetch_count++ while $no_prefetch->next;
35 $use_prefetch_count++ while $use_prefetch->next;
39 "manual row count confirms consistency"
40 . " (\$no_prefetch_count == $no_prefetch_count, "
41 . " \$use_prefetch_count == $use_prefetch_count)"
45 my $rs1 = $schema->resultset('Artist')->search(
50 warn ${$rs1->as_query}->[0], $/;
51 { my @x = $rs1->all; warn "$#x\n"; }
53 my $rs2 = $schema->resultset('Artist')->search(
62 warn ${$rs2->as_query}->[0], $/;
63 { my @x = $rs2->all; warn "$#x\n"; }
66 The fix is to, when using prefetch, take the query and put it into a subquery
67 joined to the tables we're prefetching from. This might result in the same
68 table being joined once in the main subquery and once in the main query. This
69 may actually resolve other, unknown edgecase bugs. It is also the right way
70 to do prefetching. Optimizations can come later.
82 my $temp = $foo_rs->search(
89 $foo_rs->storage->schema->resultset('foo')->search(
93 { me => $temp->as_query },
100 * The prefetch->join change needs to happen ONLY IF there are conditions
101 that depend on bar being joined.
102 * How will this work when the $rs is further searched on? Those clauses
103 need to be added to the subquery, not the outer one. This is particularly
104 true if rows is added in the attribute later per the Pager.