6 use Test::More tests => 88;
11 Mutually recursive roles.
21 sub bar { 'Role::Foo::bar' }
28 sub foo { 'Role::Bar::foo' }
36 with 'Role::Foo', 'Role::Bar';
37 } '... our mutually recursive roles combine okay';
43 with 'Role::Bar', 'Role::Foo';
44 } '... our mutually recursive roles combine okay (no matter what order)';
47 my $test1 = My::Test1->new;
48 isa_ok($test1, 'My::Test1');
50 ok($test1->does('Role::Foo'), '... $test1 does Role::Foo');
51 ok($test1->does('Role::Bar'), '... $test1 does Role::Bar');
53 can_ok($test1, 'foo');
54 can_ok($test1, 'bar');
56 is($test1->foo, 'Role::Bar::foo', '... $test1->foo worked');
57 is($test1->bar, 'Role::Foo::bar', '... $test1->bar worked');
59 my $test2 = My::Test2->new;
60 isa_ok($test2, 'My::Test2');
62 ok($test2->does('Role::Foo'), '... $test2 does Role::Foo');
63 ok($test2->does('Role::Bar'), '... $test2 does Role::Bar');
65 can_ok($test2, 'foo');
66 can_ok($test2, 'bar');
68 is($test2->foo, 'Role::Bar::foo', '... $test2->foo worked');
69 is($test2->bar, 'Role::Foo::bar', '... $test2->bar worked');
71 # check some meta-stuff
73 ok(Role::Foo->meta->has_method('bar'), '... it still has the bar method');
74 ok(Role::Foo->meta->requires_method('foo'), '... it still has the required foo method');
76 ok(Role::Bar->meta->has_method('foo'), '... it still has the foo method');
77 ok(Role::Bar->meta->requires_method('bar'), '... it still has the required bar method');
89 sub bling { 'Role::Bling::bling' }
91 package Role::Bling::Bling;
94 sub bling { 'Role::Bling::Bling::bling' }
102 with 'Role::Bling', 'Role::Bling::Bling';
103 } qr/Due to a method name conflict in roles 'Role::Bling' and 'Role::Bling::Bling', the method 'bling' must be implemented by 'My::Test3'/, '... role methods conflict and method was required';
110 with 'Role::Bling::Bling';
111 } '... role methods didnt conflict when manually combined';
117 with 'Role::Bling::Bling';
119 } '... role methods didnt conflict when manually combined (in opposite order)';
125 with 'Role::Bling::Bling', 'Role::Bling';
126 } '... role methods didnt conflict when manually resolved';
128 sub bling { 'My::Test6::bling' }
131 ok(!My::Test3->meta->has_method('bling'), '... we didnt get any methods in the conflict');
132 ok(My::Test4->meta->has_method('bling'), '... we did get the method when manually dealt with');
133 ok(My::Test5->meta->has_method('bling'), '... we did get the method when manually dealt with');
134 ok(My::Test6->meta->has_method('bling'), '... we did get the method when manually dealt with');
136 ok(!My::Test3->does('Role::Bling'), '... our class does() the correct roles');
137 ok(!My::Test3->does('Role::Bling::Bling'), '... our class does() the correct roles');
138 ok(My::Test4->does('Role::Bling'), '... our class does() the correct roles');
139 ok(My::Test4->does('Role::Bling::Bling'), '... our class does() the correct roles');
140 ok(My::Test5->does('Role::Bling'), '... our class does() the correct roles');
141 ok(My::Test5->does('Role::Bling::Bling'), '... our class does() the correct roles');
142 ok(My::Test6->does('Role::Bling'), '... our class does() the correct roles');
143 ok(My::Test6->does('Role::Bling::Bling'), '... our class does() the correct roles');
145 is(My::Test4->bling, 'Role::Bling::bling', '... and we got the first method that was added');
146 is(My::Test5->bling, 'Role::Bling::Bling::bling', '... and we got the first method that was added');
147 is(My::Test6->bling, 'My::Test6::bling', '... and we got the local method');
149 # check how this affects role compostion
152 package Role::Bling::Bling::Bling;
155 with 'Role::Bling::Bling';
157 sub bling { 'Role::Bling::Bling::Bling::bling' }
160 ok(Role::Bling::Bling->meta->has_method('bling'), '... still got the bling method in Role::Bling::Bling');
161 ok(Role::Bling::Bling->meta->does_role('Role::Bling::Bling'), '... our role correctly does() the other role');
162 ok(Role::Bling::Bling::Bling->meta->has_method('bling'), '... dont have the bling method in Role::Bling::Bling::Bling');
163 is(Role::Bling::Bling::Bling->meta->get_method('bling')->(),
164 'Role::Bling::Bling::Bling::bling',
165 '... still got the bling method in Role::Bling::Bling::Bling');
170 Role attribute conflicts
178 has 'ghost' => (is => 'ro', default => 'Role::Boo::ghost');
180 package Role::Boo::Hoo;
183 has 'ghost' => (is => 'ro', default => 'Role::Boo::Hoo::ghost');
191 with 'Role::Boo', 'Role::Boo::Hoo';
192 } qr/We have encountered an attribute conflict/,
193 '... role attrs conflict and method was required';
200 with 'Role::Boo::Hoo';
201 } '... role attrs didnt conflict when manually combined';
207 with 'Role::Boo::Hoo';
209 } '... role attrs didnt conflict when manually combined';
214 has 'ghost' => (is => 'ro', default => 'My::Test10::ghost');
217 with 'Role::Boo', 'Role::Boo::Hoo';
218 } qr/We have encountered an attribute conflict/,
219 '... role attrs conflict and cannot be manually disambiguted';
223 ok(!My::Test7->meta->has_attribute('ghost'), '... we didnt get any attributes in the conflict');
224 ok(My::Test8->meta->has_attribute('ghost'), '... we did get an attributes when manually composed');
225 ok(My::Test9->meta->has_attribute('ghost'), '... we did get an attributes when manually composed');
226 ok(My::Test10->meta->has_attribute('ghost'), '... we did still have an attribute ghost (conflict does not mess with class)');
228 ok(!My::Test7->does('Role::Boo'), '... our class does() the correct roles');
229 ok(!My::Test7->does('Role::Boo::Hoo'), '... our class does() the correct roles');
230 ok(My::Test8->does('Role::Boo'), '... our class does() the correct roles');
231 ok(My::Test8->does('Role::Boo::Hoo'), '... our class does() the correct roles');
232 ok(My::Test9->does('Role::Boo'), '... our class does() the correct roles');
233 ok(My::Test9->does('Role::Boo::Hoo'), '... our class does() the correct roles');
234 ok(!My::Test10->does('Role::Boo'), '... our class does() the correct roles');
235 ok(!My::Test10->does('Role::Boo::Hoo'), '... our class does() the correct roles');
237 can_ok('My::Test8', 'ghost');
238 can_ok('My::Test9', 'ghost');
239 can_ok('My::Test10', 'ghost');
241 is(My::Test8->new->ghost, 'Role::Boo::ghost', '... got the expected default attr value');
242 is(My::Test9->new->ghost, 'Role::Boo::Hoo::ghost', '... got the expected default attr value');
243 is(My::Test10->new->ghost, 'My::Test10::ghost', '... got the expected default attr value');
247 Role override method conflicts
255 override 'twist' => sub {
256 super() . ' -> Role::Plot::twist';
262 override 'twist' => sub {
263 super() . ' -> Role::Truth::twist';
268 package My::Test::Base;
271 sub twist { 'My::Test::Base::twist' }
276 extends 'My::Test::Base';
280 } '... composed the role with override okay';
285 extends 'My::Test::Base';
289 } '... composed the role with override okay';
296 } '... cannot compose it because we have no superclass';
301 extends 'My::Test::Base';
304 with 'Role::Plot', 'Role::Truth';
305 } qr/Two \'override\' methods of the same name encountered/,
306 '... cannot compose it because we have no superclass';
309 ok(My::Test11->meta->has_method('twist'), '... the twist method has been added');
310 ok(My::Test12->meta->has_method('twist'), '... the twist method has been added');
311 ok(!My::Test13->meta->has_method('twist'), '... the twist method has not been added');
312 ok(!My::Test14->meta->has_method('twist'), '... the twist method has not been added');
314 ok(!My::Test11->does('Role::Plot'), '... our class does() the correct roles');
315 ok(My::Test11->does('Role::Truth'), '... our class does() the correct roles');
316 ok(!My::Test12->does('Role::Truth'), '... our class does() the correct roles');
317 ok(My::Test12->does('Role::Plot'), '... our class does() the correct roles');
318 ok(!My::Test13->does('Role::Plot'), '... our class does() the correct roles');
319 ok(!My::Test14->does('Role::Truth'), '... our class does() the correct roles');
320 ok(!My::Test14->does('Role::Plot'), '... our class does() the correct roles');
322 is(My::Test11->twist(), 'My::Test::Base::twist -> Role::Truth::twist', '... got the right method return');
323 is(My::Test12->twist(), 'My::Test::Base::twist -> Role::Plot::twist', '... got the right method return');
324 ok(!My::Test13->can('twist'), '... no twist method here at all');
325 is(My::Test14->twist(), 'My::Test::Base::twist', '... got the right method return (from superclass)');
328 package Role::Reality;
333 } qr/A local method of the same name as been found/,
334 '... could not compose roles here, it dies';
337 'Role::Reality::twist';
341 ok(Role::Reality->meta->has_method('twist'), '... the twist method has not been added');
342 #ok(!Role::Reality->meta->does_role('Role::Plot'), '... our role does() the correct roles');
343 is(Role::Reality->meta->get_method('twist')->(),
344 'Role::Reality::twist',
345 '... the twist method returns the right value');
347 # Ovid's test case from rt.cpan.org #44
365 with qw(Role1 Role2);
366 } qr/Due to a method name conflict in roles 'Role1' and 'Role2', the method 'foo' must be implemented by 'Conflicts'/;
371 Role conflicts between attributes and methods
373 [15:23] <kolibrie> when class defines method and role defines method, class wins
374 [15:24] <kolibrie> when class 'has' method and role defines method, class wins
375 [15:24] <kolibrie> when class defines method and role 'has' method, role wins
376 [15:24] <kolibrie> when class 'has' method and role 'has' method, role wins
377 [15:24] <kolibrie> which means when class 'has' method and two roles 'has' method, no tiebreak is detected
378 [15:24] <perigrin> this is with role and has declaration in the exact same order in every case?
379 [15:25] <kolibrie> yes
380 [15:25] <perigrin> interesting
381 [15:25] <kolibrie> that's what I thought
382 [15:26] <kolibrie> does that sound like something I should write a test for?
383 [15:27] <perigrin> stevan, ping?
384 [15:27] <perigrin> I'm not sure what the right answer for composition is.
385 [15:27] <perigrin> who should win
386 [15:27] <perigrin> if I were to guess I'd say the class should always win.
387 [15:27] <kolibrie> that would be my guess, but I thought I would ask to make sure
388 [15:29] <stevan> kolibrie: please write a test
389 [15:29] <stevan> I am not exactly sure who should win either,.. but I suspect it is not working correctly right now
390 [15:29] <stevan> I know exactly why it is doing what it is doing though
392 Now I have to decide actually what happens, and how to fix it.
396 package Role::Method;
399 sub ghost { 'Role::Method::ghost' }
401 package Role::Method2;
404 sub ghost { 'Role::Method2::ghost' }
406 package Role::Attribute;
409 has 'ghost' => (is => 'ro', default => 'Role::Attribute::ghost');
411 package Role::Attribute2;
414 has 'ghost' => (is => 'ro', default => 'Role::Attribute2::ghost');
423 } '... composed the method role into the method class';
425 sub ghost { 'My::Test15::ghost' }
432 } '... composed the method role into the attribute class';
434 has 'ghost' => (is => 'ro', default => 'My::Test16::ghost');
440 with 'Role::Attribute';
441 } '... composed the attribute role into the method class';
443 sub ghost { 'My::Test17::ghost' }
449 with 'Role::Attribute';
450 } '... composed the attribute role into the attribute class';
452 has 'ghost' => (is => 'ro', default => 'My::Test18::ghost');
458 with 'Role::Method', 'Role::Method2';
459 } '... composed method roles into class with method tiebreaker';
461 sub ghost { 'My::Test19::ghost' }
467 with 'Role::Method', 'Role::Method2';
468 } '... composed method roles into class with attribute tiebreaker';
470 has 'ghost' => (is => 'ro', default => 'My::Test20::ghost');
476 with 'Role::Attribute', 'Role::Attribute2';
477 } '... composed attribute roles into class with method tiebreaker';
479 sub ghost { 'My::Test21::ghost' }
485 with 'Role::Attribute', 'Role::Attribute2';
486 } '... composed attribute roles into class with attribute tiebreaker';
488 has 'ghost' => (is => 'ro', default => 'My::Test22::ghost');
494 with 'Role::Method', 'Role::Attribute';
495 } '... composed method and attribute role into class with method tiebreaker';
497 sub ghost { 'My::Test23::ghost' }
503 with 'Role::Method', 'Role::Attribute';
504 } '... composed method and attribute role into class with attribute tiebreaker';
506 has 'ghost' => (is => 'ro', default => 'My::Test24::ghost');
512 with 'Role::Attribute', 'Role::Method';
513 } '... composed attribute and method role into class with method tiebreaker';
515 sub ghost { 'My::Test25::ghost' }
521 with 'Role::Attribute', 'Role::Method';
522 } '... composed attribute and method role into class with attribute tiebreaker';
524 has 'ghost' => (is => 'ro', default => 'My::Test26::ghost');
527 my $test15 = My::Test15->new;
528 isa_ok($test15, 'My::Test15');
529 is($test15->ghost, 'My::Test15::ghost', '... we access the method from the class and ignore the role method');
531 my $test16 = My::Test16->new;
532 isa_ok($test16, 'My::Test16');
533 is($test16->ghost, 'My::Test16::ghost', '... we access the attribute from the class and ignore the role method');
535 my $test17 = My::Test17->new;
536 isa_ok($test17, 'My::Test17');
537 is($test17->ghost, 'My::Test17::ghost', '... we access the method from the class and ignore the role attribute');
539 my $test18 = My::Test18->new;
540 isa_ok($test18, 'My::Test18');
541 is($test18->ghost, 'My::Test18::ghost', '... we access the attribute from the class and ignore the role attribute');
543 my $test19 = My::Test19->new;
544 isa_ok($test19, 'My::Test19');
545 is($test19->ghost, 'My::Test19::ghost', '... we access the method from the class and ignore the role methods');
547 my $test20 = My::Test20->new;
548 isa_ok($test20, 'My::Test20');
549 is($test20->ghost, 'My::Test20::ghost', '... we access the attribute from the class and ignore the role methods');
551 my $test21 = My::Test21->new;
552 isa_ok($test21, 'My::Test21');
553 is($test21->ghost, 'My::Test21::ghost', '... we access the method from the class and ignore the role attributes');
555 my $test22 = My::Test22->new;
556 isa_ok($test22, 'My::Test22');
557 is($test22->ghost, 'My::Test22::ghost', '... we access the attribute from the class and ignore the role attributes');
559 my $test23 = My::Test23->new;
560 isa_ok($test23, 'My::Test23');
561 is($test23->ghost, 'My::Test23::ghost', '... we access the method from the class and ignore the role method and attribute');
563 my $test24 = My::Test24->new;
564 isa_ok($test24, 'My::Test24');
565 is($test24->ghost, 'My::Test24::ghost', '... we access the attribute from the class and ignore the role method and attribute');
567 my $test25 = My::Test25->new;
568 isa_ok($test25, 'My::Test25');
569 is($test25->ghost, 'My::Test25::ghost', '... we access the method from the class and ignore the role attribute and method');
571 my $test26 = My::Test26->new;
572 isa_ok($test26, 'My::Test26');
573 is($test26->ghost, 'My::Test26::ghost', '... we access the attribute from the class and ignore the role attribute and method');