Commit | Line | Data |
8d005ad9 |
1 | use strict; |
2 | use warnings; |
3 | use Test::More; |
4 | use Test::Warn; |
5 | |
6 | use lib qw(t/lib); |
a5a7bb73 |
7 | use DBICTest ':DiffSQL'; |
b5ce6748 |
8 | use DBIx::Class::_Util 'UNRESOLVABLE_CONDITION'; |
8d005ad9 |
9 | |
8d005ad9 |
10 | use Data::Dumper; |
ff7d03e6 |
11 | BEGIN { |
12 | if ( eval { require Test::Differences } ) { |
13 | no warnings 'redefine'; |
14 | *is_deeply = \&Test::Differences::eq_or_diff; |
15 | } |
16 | } |
8d005ad9 |
17 | |
18 | my $schema = DBICTest->init_schema( no_deploy => 1); |
19 | my $sm = $schema->storage->sql_maker; |
20 | |
7638636b |
21 | { |
22 | package # hideee |
23 | DBICTest::SillyInt; |
24 | |
25 | use overload |
26 | fallback => 1, |
27 | '0+' => sub { ${$_[0]} }, |
28 | ; |
29 | } |
30 | my $num = bless( \do { my $foo = 69 }, 'DBICTest::SillyInt' ); |
31 | |
32 | is($num, 69, 'test overloaded object is "sane"'); |
33 | is("$num", 69, 'test overloaded object is "sane"'); |
34 | |
8d005ad9 |
35 | for my $t ( |
36 | { |
37 | where => { artistid => 1, charfield => undef }, |
38 | cc_result => { artistid => 1, charfield => undef }, |
39 | sql => 'WHERE artistid = ? AND charfield IS NULL', |
8e40a627 |
40 | efcc_result => { artistid => 1 }, |
41 | efcc_n_result => { artistid => 1, charfield => undef }, |
8d005ad9 |
42 | }, |
43 | { |
44 | where => { -and => [ artistid => 1, charfield => undef, { rank => 13 } ] }, |
45 | cc_result => { artistid => 1, charfield => undef, rank => 13 }, |
46 | sql => 'WHERE artistid = ? AND charfield IS NULL AND rank = ?', |
8e40a627 |
47 | efcc_result => { artistid => 1, rank => 13 }, |
48 | efcc_n_result => { artistid => 1, charfield => undef, rank => 13 }, |
8d005ad9 |
49 | }, |
50 | { |
51 | where => { -and => [ { artistid => 1, charfield => undef}, { rank => 13 } ] }, |
52 | cc_result => { artistid => 1, charfield => undef, rank => 13 }, |
53 | sql => 'WHERE artistid = ? AND charfield IS NULL AND rank = ?', |
8e40a627 |
54 | efcc_result => { artistid => 1, rank => 13 }, |
55 | efcc_n_result => { artistid => 1, charfield => undef, rank => 13 }, |
8d005ad9 |
56 | }, |
57 | { |
58 | where => { -and => [ -or => { name => 'Caterwauler McCrae' }, 'rank' ] }, |
59 | cc_result => { name => 'Caterwauler McCrae', rank => undef }, |
60 | sql => 'WHERE name = ? AND rank IS NULL', |
8e40a627 |
61 | efcc_result => { name => 'Caterwauler McCrae' }, |
62 | efcc_n_result => { name => 'Caterwauler McCrae', rank => undef }, |
8d005ad9 |
63 | }, |
64 | { |
65 | where => { -and => [ [ [ artist => {'=' => \'foo' } ] ], { name => \[ '= ?', 'bar' ] } ] }, |
66 | cc_result => { artist => {'=' => \'foo' }, name => \[ '= ?', 'bar' ] }, |
67 | sql => 'WHERE artist = foo AND name = ?', |
8e40a627 |
68 | efcc_result => { artist => \'foo' }, |
8d005ad9 |
69 | }, |
70 | { |
71 | where => { -and => [ -or => { name => 'Caterwauler McCrae', artistid => 2 } ] }, |
72 | cc_result => { -or => [ artistid => 2, name => 'Caterwauler McCrae' ] }, |
73 | sql => 'WHERE artistid = ? OR name = ?', |
8e40a627 |
74 | efcc_result => {}, |
75 | }, |
76 | { |
77 | where => { -or => { name => 'Caterwauler McCrae', artistid => 2 } }, |
78 | cc_result => { -or => [ artistid => 2, name => 'Caterwauler McCrae' ] }, |
79 | sql => 'WHERE artistid = ? OR name = ?', |
80 | efcc_result => {}, |
8d005ad9 |
81 | }, |
82 | { |
7638636b |
83 | where => { -and => [ \'foo=bar', [ { artistid => { '=', $num } } ], { name => 'Caterwauler McCrae'} ] }, |
84 | cc_result => { '' => \'foo=bar', name => 'Caterwauler McCrae', artistid => $num }, |
8d005ad9 |
85 | sql => 'WHERE foo=bar AND artistid = ? AND name = ?', |
8e40a627 |
86 | efcc_result => { name => 'Caterwauler McCrae', artistid => $num }, |
8d005ad9 |
87 | }, |
88 | { |
7638636b |
89 | where => { artistid => [ $num ], rank => [ 13, 2, 3 ], charfield => [ undef ] }, |
90 | cc_result => { artistid => $num, charfield => undef, rank => [13, 2, 3] }, |
8d005ad9 |
91 | sql => 'WHERE artistid = ? AND charfield IS NULL AND ( rank = ? OR rank = ? OR rank = ? )', |
8e40a627 |
92 | efcc_result => { artistid => $num }, |
93 | efcc_n_result => { artistid => $num, charfield => undef }, |
8d005ad9 |
94 | }, |
95 | { |
96 | where => { artistid => { '=' => 1 }, rank => { '>' => 12 }, charfield => { '=' => undef } }, |
97 | cc_result => { artistid => 1, charfield => undef, rank => { '>' => 12 } }, |
98 | sql => 'WHERE artistid = ? AND charfield IS NULL AND rank > ?', |
8e40a627 |
99 | efcc_result => { artistid => 1 }, |
100 | efcc_n_result => { artistid => 1, charfield => undef }, |
8d005ad9 |
101 | }, |
102 | { |
953d5b7d |
103 | where => { artistid => { '=' => [ 1 ], }, charfield => { '=' => [ -AND => \'1', \['?',2] ] }, rank => { '=' => [ -OR => $num, $num ] } }, |
104 | cc_result => { artistid => 1, charfield => [-and => { '=' => \['?',2] }, { '=' => \'1' } ], rank => { '=' => [$num, $num] } }, |
8d005ad9 |
105 | sql => 'WHERE artistid = ? AND charfield = 1 AND charfield = ? AND ( rank = ? OR rank = ? )', |
5268b1da |
106 | collapsed_sql => 'WHERE artistid = ? AND charfield = ? AND charfield = 1 AND ( rank = ? OR rank = ? )', |
8e40a627 |
107 | efcc_result => { artistid => 1, charfield => UNRESOLVABLE_CONDITION }, |
8d005ad9 |
108 | }, |
109 | { |
110 | where => { -and => [ artistid => 1, artistid => 2 ], name => [ -and => { '!=', 1 }, 2 ], charfield => [ -or => { '=', 2 } ], rank => [-and => undef, { '=', undef }, { '!=', 2 } ] }, |
5268b1da |
111 | cc_result => { artistid => [ -and => 1, 2 ], name => [ -and => { '!=', 1 }, 2 ], charfield => 2, rank => [ -and => { '!=', 2 }, undef ] }, |
8d005ad9 |
112 | sql => 'WHERE artistid = ? AND artistid = ? AND charfield = ? AND name != ? AND name = ? AND rank IS NULL AND rank IS NULL AND rank != ?', |
5268b1da |
113 | collapsed_sql => 'WHERE artistid = ? AND artistid = ? AND charfield = ? AND name != ? AND name = ? AND rank != ? AND rank IS NULL', |
8e40a627 |
114 | efcc_result => { |
115 | artistid => UNRESOLVABLE_CONDITION, |
116 | name => 2, |
117 | charfield => 2, |
118 | }, |
119 | efcc_n_result => { |
120 | artistid => UNRESOLVABLE_CONDITION, |
121 | name => 2, |
122 | charfield => 2, |
123 | rank => undef, |
124 | }, |
8d005ad9 |
125 | }, |
135ac69d |
126 | (map { { |
127 | where => $_, |
128 | sql => 'WHERE (rank = 13 OR charfield IS NULL OR artistid = ?) AND (artistid = ? OR charfield IS NULL OR rank != 42)', |
129 | collapsed_sql => 'WHERE (artistid = ? OR charfield IS NULL OR rank = 13) AND (artistid = ? OR charfield IS NULL OR rank != 42)', |
130 | cc_result => { -and => [ |
131 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
132 | { -or => [ artistid => 1, charfield => undef, rank => { '!=' => \42 } ] }, |
133 | ] }, |
134 | efcc_result => {}, |
135 | efcc_n_result => {}, |
136 | } } ( |
ff7d03e6 |
137 | |
135ac69d |
138 | { -and => [ |
139 | -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
140 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } }, |
141 | ] }, |
142 | |
143 | { |
144 | -OR => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
145 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } }, |
146 | }, |
ff7d03e6 |
147 | |
135ac69d |
148 | ) ), |
149 | { |
c1f3f2e8 |
150 | where => { -or => [ |
151 | -and => [ foo => { '!=', { -value => undef } }, bar => { -in => [ 69, 42 ] } ], |
152 | foo => { '=', { -value => undef } }, |
153 | baz => { '!=' => { -ident => 'bozz' } }, |
154 | baz => { -ident => 'buzz' }, |
155 | ] }, |
156 | sql => 'WHERE ( foo IS NOT NULL AND bar IN ( ?, ? ) ) OR foo IS NULL OR baz != bozz OR baz = buzz', |
157 | collapsed_sql => 'WHERE baz != bozz OR baz = buzz OR foo IS NULL OR ( bar IN ( ?, ? ) AND foo IS NOT NULL )', |
95da0f23 |
158 | cc_result => { -or => [ |
c1f3f2e8 |
159 | baz => { '!=' => { -ident => 'bozz' } }, |
160 | baz => { '=' => { -ident => 'buzz' } }, |
95da0f23 |
161 | foo => undef, |
162 | { bar => { -in => [ 69, 42 ] }, foo => { '!=', undef } } |
163 | ] }, |
164 | efcc_result => {}, |
165 | }, |
166 | { |
135ac69d |
167 | where => { -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => { '=' => 1 }, genreid => { '=' => \['?', 2] } ] }, |
168 | sql => 'WHERE rank = 13 OR charfield IS NULL OR artistid = ? OR genreid = ?', |
169 | collapsed_sql => 'WHERE artistid = ? OR charfield IS NULL OR genreid = ? OR rank = 13', |
170 | cc_result => { -or => [ artistid => 1, charfield => undef, genreid => { '=' => \['?', 2] }, rank => { '=' => \13 } ] }, |
171 | efcc_result => {}, |
172 | efcc_n_result => {}, |
173 | }, |
174 | { |
175 | where => { -and => [ |
176 | -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
177 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '=' => \13 } }, |
178 | ] }, |
179 | cc_result => { -and => [ |
180 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
181 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
182 | ] }, |
183 | sql => 'WHERE (rank = 13 OR charfield IS NULL OR artistid = ?) AND (artistid = ? OR charfield IS NULL OR rank = 13)', |
184 | collapsed_sql => 'WHERE (artistid = ? OR charfield IS NULL OR rank = 13) AND (artistid = ? OR charfield IS NULL OR rank = 13)', |
185 | efcc_result => {}, |
186 | efcc_n_result => {}, |
187 | }, |
188 | { |
189 | where => { -and => [ |
190 | -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
191 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } }, |
192 | -and => [ foo => { '=' => \1 }, bar => 2 ], |
193 | -and => [ foo => 3, bar => { '=' => \4 } ], |
194 | -exists => \'(SELECT 1)', |
195 | -exists => \'(SELECT 2)', |
196 | -not => { foo => 69 }, |
197 | -not => { foo => 42 }, |
198 | ]}, |
199 | sql => 'WHERE |
200 | ( rank = 13 OR charfield IS NULL OR artistid = ? ) |
201 | AND ( artistid = ? OR charfield IS NULL OR rank != 42 ) |
202 | AND foo = 1 |
203 | AND bar = ? |
204 | AND foo = ? |
205 | AND bar = 4 |
206 | AND (EXISTS (SELECT 1)) |
207 | AND (EXISTS (SELECT 2)) |
208 | AND NOT foo = ? |
209 | AND NOT foo = ? |
210 | ', |
211 | collapsed_sql => 'WHERE |
212 | ( artistid = ? OR charfield IS NULL OR rank = 13 ) |
213 | AND ( artistid = ? OR charfield IS NULL OR rank != 42 ) |
214 | AND (EXISTS (SELECT 1)) |
215 | AND (EXISTS (SELECT 2)) |
216 | AND NOT foo = ? |
217 | AND NOT foo = ? |
218 | AND bar = 4 |
219 | AND bar = ? |
220 | AND foo = 1 |
221 | AND foo = ? |
222 | ', |
223 | cc_result => { |
224 | -and => [ |
225 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
226 | { -or => [ artistid => 1, charfield => undef, rank => { '!=' => \42 } ] }, |
227 | { -exists => \'(SELECT 1)' }, |
228 | { -exists => \'(SELECT 2)' }, |
229 | { -not => { foo => 69 } }, |
230 | { -not => { foo => 42 } }, |
231 | ], |
232 | foo => [ -and => { '=' => \1 }, 3 ], |
233 | bar => [ -and => { '=' => \4 }, 2 ], |
234 | }, |
235 | efcc_result => { |
236 | foo => UNRESOLVABLE_CONDITION, |
237 | bar => UNRESOLVABLE_CONDITION, |
238 | }, |
239 | efcc_n_result => { |
240 | foo => UNRESOLVABLE_CONDITION, |
241 | bar => UNRESOLVABLE_CONDITION, |
242 | }, |
243 | }, |
8d005ad9 |
244 | { |
245 | where => { -and => [ |
246 | [ '_macro.to' => { -like => '%correct%' }, '_wc_macros.to' => { -like => '%correct%' } ], |
247 | { -and => [ { 'group.is_active' => 1 }, { 'me.is_active' => 1 } ] } |
248 | ] }, |
249 | cc_result => { |
250 | 'group.is_active' => 1, |
251 | 'me.is_active' => 1, |
252 | -or => [ |
253 | '_macro.to' => { -like => '%correct%' }, |
254 | '_wc_macros.to' => { -like => '%correct%' }, |
255 | ], |
256 | }, |
257 | sql => 'WHERE ( _macro.to LIKE ? OR _wc_macros.to LIKE ? ) AND group.is_active = ? AND me.is_active = ?', |
8e40a627 |
258 | efcc_result => { 'group.is_active' => 1, 'me.is_active' => 1 }, |
8d005ad9 |
259 | }, |
5f35ba0f |
260 | |
b5ce6748 |
261 | { |
5f35ba0f |
262 | where => { -and => [ |
263 | artistid => { -value => [1] }, |
264 | charfield => { -ident => 'foo' }, |
265 | name => { '=' => { -value => undef } }, |
266 | rank => { '=' => { -ident => 'bar' } }, |
267 | ] }, |
268 | sql => 'WHERE artistid = ? AND charfield = foo AND name IS NULL AND rank = bar', |
269 | cc_result => { |
270 | artistid => { -value => [1] }, |
271 | name => undef, |
272 | charfield => { '=', { -ident => 'foo' } }, |
273 | rank => { '=' => { -ident => 'bar' } }, |
274 | }, |
275 | efcc_result => { |
276 | artistid => [1], |
277 | charfield => { -ident => 'foo' }, |
278 | rank => { -ident => 'bar' }, |
279 | }, |
280 | efcc_n_result => { |
281 | artistid => [1], |
282 | name => undef, |
283 | charfield => { -ident => 'foo' }, |
284 | rank => { -ident => 'bar' }, |
285 | }, |
b5ce6748 |
286 | }, |
5f35ba0f |
287 | |
8d005ad9 |
288 | { |
289 | where => { artistid => [] }, |
290 | cc_result => { artistid => [] }, |
8e40a627 |
291 | efcc_result => {}, |
8d005ad9 |
292 | }, |
293 | (map { |
294 | { |
295 | where => { -and => $_ }, |
296 | cc_result => undef, |
8e40a627 |
297 | efcc_result => {}, |
8d005ad9 |
298 | sql => '', |
299 | }, |
300 | { |
301 | where => { -or => $_ }, |
302 | cc_result => undef, |
8e40a627 |
303 | efcc_result => {}, |
8d005ad9 |
304 | sql => '', |
305 | }, |
22485a7e |
306 | { |
307 | where => { -or => [ foo => 1, $_ ] }, |
308 | cc_result => { foo => 1 }, |
309 | efcc_result => { foo => 1 }, |
310 | sql => 'WHERE foo = ?', |
311 | }, |
312 | { |
313 | where => { -or => [ $_, foo => 1 ] }, |
314 | cc_result => { foo => 1 }, |
315 | efcc_result => { foo => 1 }, |
316 | sql => 'WHERE foo = ?', |
317 | }, |
318 | { |
319 | where => { -and => [ fuu => 2, $_, foo => 1 ] }, |
320 | sql => 'WHERE fuu = ? AND foo = ?', |
321 | collapsed_sql => 'WHERE foo = ? AND fuu = ?', |
322 | cc_result => { foo => 1, fuu => 2 }, |
323 | efcc_result => { foo => 1, fuu => 2 }, |
324 | }, |
8d005ad9 |
325 | } ( |
326 | # bare |
327 | [], {}, |
328 | # singles |
329 | [ {} ], [ [] ], |
330 | # doubles |
331 | [ [], [] ], [ {}, {} ], [ [], {} ], [ {}, [] ], |
332 | # tripples |
333 | [ {}, [], {} ], [ [], {}, [] ] |
334 | )), |
335 | |
336 | # FIXME legacy compat crap, possibly worth undef/dieing in SQLMaker |
8e40a627 |
337 | { where => { artistid => {} }, sql => '', cc_result => undef, efcc_result => {}, efcc_n_result => {} }, |
8d005ad9 |
338 | |
339 | # batshit insanity, just to be thorough |
340 | { |
341 | where => { -and => [ [ 'artistid' ], [ -and => [ artistid => { '!=', 69 }, artistid => undef, artistid => { '=' => 200 } ]], artistid => [], { -or => [] }, { -and => [] }, [ 'charfield' ], { name => [] }, 'rank' ] }, |
5268b1da |
342 | cc_result => { artistid => [ -and => [], { '!=', 69 }, undef, 200 ], charfield => undef, name => [], rank => undef }, |
8d005ad9 |
343 | sql => 'WHERE artistid IS NULL AND artistid != ? AND artistid IS NULL AND artistid = ? AND 0=1 AND charfield IS NULL AND 0=1 AND rank IS NULL', |
5268b1da |
344 | collapsed_sql => 'WHERE 0=1 AND artistid != ? AND artistid IS NULL AND artistid = ? AND charfield IS NULL AND 0=1 AND rank IS NULL', |
8e40a627 |
345 | efcc_result => { artistid => UNRESOLVABLE_CONDITION }, |
346 | efcc_n_result => { artistid => UNRESOLVABLE_CONDITION, charfield => undef, rank => undef }, |
8d005ad9 |
347 | }, |
8acda57c |
348 | |
349 | # original test from RT#93244 |
350 | { |
351 | where => { |
352 | -and => [ |
353 | \[ |
354 | "LOWER(me.title) LIKE ?", |
355 | '%spoon%', |
356 | ], |
357 | [ { 'me.title' => 'Spoonful of bees' } ], |
358 | ]}, |
359 | cc_result => { |
360 | '' => \[ |
361 | "LOWER(me.title) LIKE ?", |
362 | '%spoon%', |
363 | ], |
364 | 'me.title' => 'Spoonful of bees', |
365 | }, |
366 | sql => 'WHERE LOWER(me.title) LIKE ? AND me.title = ?', |
8e40a627 |
367 | efcc_result => { 'me.title' => 'Spoonful of bees' }, |
8acda57c |
368 | } |
8d005ad9 |
369 | ) { |
370 | |
371 | for my $w ( |
372 | $t->{where}, |
953d5b7d |
373 | $t->{where}, # do it twice, make sure we didn't destory the condition |
8d005ad9 |
374 | [ -and => $t->{where} ], |
953d5b7d |
375 | [ -AND => $t->{where} ], |
376 | { -OR => [ -AND => $t->{where} ] }, |
8e40a627 |
377 | ( keys %{$t->{where}} <= 1 ? [ %{$t->{where}} ] : () ), |
378 | ( (keys %{$t->{where}} == 1 and $t->{where}{-or}) |
379 | ? ( ref $t->{where}{-or} eq 'HASH' |
380 | ? [ map { $_ => $t->{where}{-or}{$_} } sort keys %{$t->{where}{-or}} ] |
381 | : $t->{where}{-or} |
382 | ) |
383 | : () |
384 | ), |
8d005ad9 |
385 | ) { |
386 | my $name = do { local ($Data::Dumper::Indent, $Data::Dumper::Terse, $Data::Dumper::Sortkeys) = (0, 1, 1); Dumper $w }; |
387 | |
5268b1da |
388 | my ($generated_sql) = $sm->where($w); |
8d005ad9 |
389 | |
5268b1da |
390 | is_same_sql ( $generated_sql, $t->{sql}, "Expected SQL from $name" ) |
8d005ad9 |
391 | if exists $t->{sql}; |
392 | |
393 | my $collapsed_cond = $schema->storage->_collapse_cond($w); |
394 | |
5268b1da |
395 | is_same_sql( |
396 | ($sm->where($collapsed_cond))[0], |
397 | ( $t->{collapsed_sql} || $t->{sql} || $generated_sql ), |
398 | "Collapse did not alter *the semantics* of the final SQL based on $name", |
8d005ad9 |
399 | ); |
400 | |
401 | is_deeply( |
402 | $collapsed_cond, |
403 | $t->{cc_result}, |
404 | "Expected collapsed condition produced on $name", |
405 | ); |
406 | |
407 | is_deeply( |
408 | $schema->storage->_extract_fixed_condition_columns($w), |
409 | $t->{efcc_result}, |
410 | "Expected fixed_condition produced on $name", |
411 | ); |
8e40a627 |
412 | |
413 | is_deeply( |
414 | $schema->storage->_extract_fixed_condition_columns($w, 'consider_nulls'), |
415 | $t->{efcc_n_result}, |
416 | "Expected fixed_condition including NULLs produced on $name", |
417 | ) if $t->{efcc_n_result}; |
ff7d03e6 |
418 | |
419 | die unless Test::Builder->new->is_passing; |
8d005ad9 |
420 | } |
421 | } |
422 | |
423 | done_testing; |