Commit | Line | Data |
8d005ad9 |
1 | use strict; |
2 | use warnings; |
3 | use Test::More; |
4 | use Test::Warn; |
5 | |
6 | use lib qw(t/lib); |
a5a7bb73 |
7 | use DBICTest ':DiffSQL'; |
b5ce6748 |
8 | use DBIx::Class::_Util 'UNRESOLVABLE_CONDITION'; |
8d005ad9 |
9 | |
8d005ad9 |
10 | use Data::Dumper; |
11 | |
12 | my $schema = DBICTest->init_schema( no_deploy => 1); |
13 | my $sm = $schema->storage->sql_maker; |
14 | |
7638636b |
15 | { |
16 | package # hideee |
17 | DBICTest::SillyInt; |
18 | |
19 | use overload |
20 | fallback => 1, |
21 | '0+' => sub { ${$_[0]} }, |
22 | ; |
23 | } |
24 | my $num = bless( \do { my $foo = 69 }, 'DBICTest::SillyInt' ); |
25 | |
26 | is($num, 69, 'test overloaded object is "sane"'); |
27 | is("$num", 69, 'test overloaded object is "sane"'); |
28 | |
8d005ad9 |
29 | for my $t ( |
30 | { |
31 | where => { artistid => 1, charfield => undef }, |
32 | cc_result => { artistid => 1, charfield => undef }, |
33 | sql => 'WHERE artistid = ? AND charfield IS NULL', |
8e40a627 |
34 | efcc_result => { artistid => 1 }, |
35 | efcc_n_result => { artistid => 1, charfield => undef }, |
8d005ad9 |
36 | }, |
37 | { |
38 | where => { -and => [ artistid => 1, charfield => undef, { rank => 13 } ] }, |
39 | cc_result => { artistid => 1, charfield => undef, rank => 13 }, |
40 | sql => 'WHERE artistid = ? AND charfield IS NULL AND rank = ?', |
8e40a627 |
41 | efcc_result => { artistid => 1, rank => 13 }, |
42 | efcc_n_result => { artistid => 1, charfield => undef, rank => 13 }, |
8d005ad9 |
43 | }, |
44 | { |
45 | where => { -and => [ { artistid => 1, charfield => undef}, { rank => 13 } ] }, |
46 | cc_result => { artistid => 1, charfield => undef, rank => 13 }, |
47 | sql => 'WHERE artistid = ? AND charfield IS NULL AND rank = ?', |
8e40a627 |
48 | efcc_result => { artistid => 1, rank => 13 }, |
49 | efcc_n_result => { artistid => 1, charfield => undef, rank => 13 }, |
8d005ad9 |
50 | }, |
51 | { |
52 | where => { -and => [ -or => { name => 'Caterwauler McCrae' }, 'rank' ] }, |
53 | cc_result => { name => 'Caterwauler McCrae', rank => undef }, |
54 | sql => 'WHERE name = ? AND rank IS NULL', |
8e40a627 |
55 | efcc_result => { name => 'Caterwauler McCrae' }, |
56 | efcc_n_result => { name => 'Caterwauler McCrae', rank => undef }, |
8d005ad9 |
57 | }, |
58 | { |
59 | where => { -and => [ [ [ artist => {'=' => \'foo' } ] ], { name => \[ '= ?', 'bar' ] } ] }, |
60 | cc_result => { artist => {'=' => \'foo' }, name => \[ '= ?', 'bar' ] }, |
61 | sql => 'WHERE artist = foo AND name = ?', |
8e40a627 |
62 | efcc_result => { artist => \'foo' }, |
8d005ad9 |
63 | }, |
64 | { |
65 | where => { -and => [ -or => { name => 'Caterwauler McCrae', artistid => 2 } ] }, |
66 | cc_result => { -or => [ artistid => 2, name => 'Caterwauler McCrae' ] }, |
67 | sql => 'WHERE artistid = ? OR name = ?', |
8e40a627 |
68 | efcc_result => {}, |
69 | }, |
70 | { |
71 | where => { -or => { name => 'Caterwauler McCrae', artistid => 2 } }, |
72 | cc_result => { -or => [ artistid => 2, name => 'Caterwauler McCrae' ] }, |
73 | sql => 'WHERE artistid = ? OR name = ?', |
74 | efcc_result => {}, |
8d005ad9 |
75 | }, |
76 | { |
7638636b |
77 | where => { -and => [ \'foo=bar', [ { artistid => { '=', $num } } ], { name => 'Caterwauler McCrae'} ] }, |
78 | cc_result => { '' => \'foo=bar', name => 'Caterwauler McCrae', artistid => $num }, |
8d005ad9 |
79 | sql => 'WHERE foo=bar AND artistid = ? AND name = ?', |
8e40a627 |
80 | efcc_result => { name => 'Caterwauler McCrae', artistid => $num }, |
8d005ad9 |
81 | }, |
82 | { |
7638636b |
83 | where => { artistid => [ $num ], rank => [ 13, 2, 3 ], charfield => [ undef ] }, |
84 | cc_result => { artistid => $num, charfield => undef, rank => [13, 2, 3] }, |
8d005ad9 |
85 | sql => 'WHERE artistid = ? AND charfield IS NULL AND ( rank = ? OR rank = ? OR rank = ? )', |
8e40a627 |
86 | efcc_result => { artistid => $num }, |
87 | efcc_n_result => { artistid => $num, charfield => undef }, |
8d005ad9 |
88 | }, |
89 | { |
90 | where => { artistid => { '=' => 1 }, rank => { '>' => 12 }, charfield => { '=' => undef } }, |
91 | cc_result => { artistid => 1, charfield => undef, rank => { '>' => 12 } }, |
92 | sql => 'WHERE artistid = ? AND charfield IS NULL AND rank > ?', |
8e40a627 |
93 | efcc_result => { artistid => 1 }, |
94 | efcc_n_result => { artistid => 1, charfield => undef }, |
8d005ad9 |
95 | }, |
96 | { |
953d5b7d |
97 | where => { artistid => { '=' => [ 1 ], }, charfield => { '=' => [ -AND => \'1', \['?',2] ] }, rank => { '=' => [ -OR => $num, $num ] } }, |
98 | cc_result => { artistid => 1, charfield => [-and => { '=' => \['?',2] }, { '=' => \'1' } ], rank => { '=' => [$num, $num] } }, |
8d005ad9 |
99 | sql => 'WHERE artistid = ? AND charfield = 1 AND charfield = ? AND ( rank = ? OR rank = ? )', |
5268b1da |
100 | collapsed_sql => 'WHERE artistid = ? AND charfield = ? AND charfield = 1 AND ( rank = ? OR rank = ? )', |
8e40a627 |
101 | efcc_result => { artistid => 1, charfield => UNRESOLVABLE_CONDITION }, |
8d005ad9 |
102 | }, |
103 | { |
104 | where => { -and => [ artistid => 1, artistid => 2 ], name => [ -and => { '!=', 1 }, 2 ], charfield => [ -or => { '=', 2 } ], rank => [-and => undef, { '=', undef }, { '!=', 2 } ] }, |
5268b1da |
105 | cc_result => { artistid => [ -and => 1, 2 ], name => [ -and => { '!=', 1 }, 2 ], charfield => 2, rank => [ -and => { '!=', 2 }, undef ] }, |
8d005ad9 |
106 | sql => 'WHERE artistid = ? AND artistid = ? AND charfield = ? AND name != ? AND name = ? AND rank IS NULL AND rank IS NULL AND rank != ?', |
5268b1da |
107 | collapsed_sql => 'WHERE artistid = ? AND artistid = ? AND charfield = ? AND name != ? AND name = ? AND rank != ? AND rank IS NULL', |
8e40a627 |
108 | efcc_result => { |
109 | artistid => UNRESOLVABLE_CONDITION, |
110 | name => 2, |
111 | charfield => 2, |
112 | }, |
113 | efcc_n_result => { |
114 | artistid => UNRESOLVABLE_CONDITION, |
115 | name => 2, |
116 | charfield => 2, |
117 | rank => undef, |
118 | }, |
8d005ad9 |
119 | }, |
135ac69d |
120 | (map { { |
121 | where => $_, |
122 | sql => 'WHERE (rank = 13 OR charfield IS NULL OR artistid = ?) AND (artistid = ? OR charfield IS NULL OR rank != 42)', |
123 | collapsed_sql => 'WHERE (artistid = ? OR charfield IS NULL OR rank = 13) AND (artistid = ? OR charfield IS NULL OR rank != 42)', |
124 | cc_result => { -and => [ |
125 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
126 | { -or => [ artistid => 1, charfield => undef, rank => { '!=' => \42 } ] }, |
127 | ] }, |
128 | efcc_result => {}, |
129 | efcc_n_result => {}, |
130 | } } ( |
131 | { -and => [ |
132 | -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
133 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } }, |
134 | ] }, |
135 | |
136 | { |
137 | -OR => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
138 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } }, |
139 | }, |
140 | ) ), |
141 | { |
142 | where => { -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => { '=' => 1 }, genreid => { '=' => \['?', 2] } ] }, |
143 | sql => 'WHERE rank = 13 OR charfield IS NULL OR artistid = ? OR genreid = ?', |
144 | collapsed_sql => 'WHERE artistid = ? OR charfield IS NULL OR genreid = ? OR rank = 13', |
145 | cc_result => { -or => [ artistid => 1, charfield => undef, genreid => { '=' => \['?', 2] }, rank => { '=' => \13 } ] }, |
146 | efcc_result => {}, |
147 | efcc_n_result => {}, |
148 | }, |
149 | { |
150 | where => { -and => [ |
151 | -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
152 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '=' => \13 } }, |
153 | ] }, |
154 | cc_result => { -and => [ |
155 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
156 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
157 | ] }, |
158 | sql => 'WHERE (rank = 13 OR charfield IS NULL OR artistid = ?) AND (artistid = ? OR charfield IS NULL OR rank = 13)', |
159 | collapsed_sql => 'WHERE (artistid = ? OR charfield IS NULL OR rank = 13) AND (artistid = ? OR charfield IS NULL OR rank = 13)', |
160 | efcc_result => {}, |
161 | efcc_n_result => {}, |
162 | }, |
163 | { |
164 | where => { -and => [ |
165 | -or => [ rank => { '=' => \13 }, charfield => { '=' => undef }, artistid => 1 ], |
166 | -or => { artistid => { '=' => 1 }, charfield => undef, rank => { '!=' => \42 } }, |
167 | -and => [ foo => { '=' => \1 }, bar => 2 ], |
168 | -and => [ foo => 3, bar => { '=' => \4 } ], |
169 | -exists => \'(SELECT 1)', |
170 | -exists => \'(SELECT 2)', |
171 | -not => { foo => 69 }, |
172 | -not => { foo => 42 }, |
173 | ]}, |
174 | sql => 'WHERE |
175 | ( rank = 13 OR charfield IS NULL OR artistid = ? ) |
176 | AND ( artistid = ? OR charfield IS NULL OR rank != 42 ) |
177 | AND foo = 1 |
178 | AND bar = ? |
179 | AND foo = ? |
180 | AND bar = 4 |
181 | AND (EXISTS (SELECT 1)) |
182 | AND (EXISTS (SELECT 2)) |
183 | AND NOT foo = ? |
184 | AND NOT foo = ? |
185 | ', |
186 | collapsed_sql => 'WHERE |
187 | ( artistid = ? OR charfield IS NULL OR rank = 13 ) |
188 | AND ( artistid = ? OR charfield IS NULL OR rank != 42 ) |
189 | AND (EXISTS (SELECT 1)) |
190 | AND (EXISTS (SELECT 2)) |
191 | AND NOT foo = ? |
192 | AND NOT foo = ? |
193 | AND bar = 4 |
194 | AND bar = ? |
195 | AND foo = 1 |
196 | AND foo = ? |
197 | ', |
198 | cc_result => { |
199 | -and => [ |
200 | { -or => [ artistid => 1, charfield => undef, rank => { '=' => \13 } ] }, |
201 | { -or => [ artistid => 1, charfield => undef, rank => { '!=' => \42 } ] }, |
202 | { -exists => \'(SELECT 1)' }, |
203 | { -exists => \'(SELECT 2)' }, |
204 | { -not => { foo => 69 } }, |
205 | { -not => { foo => 42 } }, |
206 | ], |
207 | foo => [ -and => { '=' => \1 }, 3 ], |
208 | bar => [ -and => { '=' => \4 }, 2 ], |
209 | }, |
210 | efcc_result => { |
211 | foo => UNRESOLVABLE_CONDITION, |
212 | bar => UNRESOLVABLE_CONDITION, |
213 | }, |
214 | efcc_n_result => { |
215 | foo => UNRESOLVABLE_CONDITION, |
216 | bar => UNRESOLVABLE_CONDITION, |
217 | }, |
218 | }, |
8d005ad9 |
219 | { |
220 | where => { -and => [ |
221 | [ '_macro.to' => { -like => '%correct%' }, '_wc_macros.to' => { -like => '%correct%' } ], |
222 | { -and => [ { 'group.is_active' => 1 }, { 'me.is_active' => 1 } ] } |
223 | ] }, |
224 | cc_result => { |
225 | 'group.is_active' => 1, |
226 | 'me.is_active' => 1, |
227 | -or => [ |
228 | '_macro.to' => { -like => '%correct%' }, |
229 | '_wc_macros.to' => { -like => '%correct%' }, |
230 | ], |
231 | }, |
232 | sql => 'WHERE ( _macro.to LIKE ? OR _wc_macros.to LIKE ? ) AND group.is_active = ? AND me.is_active = ?', |
8e40a627 |
233 | efcc_result => { 'group.is_active' => 1, 'me.is_active' => 1 }, |
8d005ad9 |
234 | }, |
5f35ba0f |
235 | |
b5ce6748 |
236 | { |
5f35ba0f |
237 | where => { -and => [ |
238 | artistid => { -value => [1] }, |
239 | charfield => { -ident => 'foo' }, |
240 | name => { '=' => { -value => undef } }, |
241 | rank => { '=' => { -ident => 'bar' } }, |
242 | ] }, |
243 | sql => 'WHERE artistid = ? AND charfield = foo AND name IS NULL AND rank = bar', |
244 | cc_result => { |
245 | artistid => { -value => [1] }, |
246 | name => undef, |
247 | charfield => { '=', { -ident => 'foo' } }, |
248 | rank => { '=' => { -ident => 'bar' } }, |
249 | }, |
250 | efcc_result => { |
251 | artistid => [1], |
252 | charfield => { -ident => 'foo' }, |
253 | rank => { -ident => 'bar' }, |
254 | }, |
255 | efcc_n_result => { |
256 | artistid => [1], |
257 | name => undef, |
258 | charfield => { -ident => 'foo' }, |
259 | rank => { -ident => 'bar' }, |
260 | }, |
b5ce6748 |
261 | }, |
5f35ba0f |
262 | |
8d005ad9 |
263 | { |
264 | where => { artistid => [] }, |
265 | cc_result => { artistid => [] }, |
8e40a627 |
266 | efcc_result => {}, |
8d005ad9 |
267 | }, |
268 | (map { |
269 | { |
270 | where => { -and => $_ }, |
271 | cc_result => undef, |
8e40a627 |
272 | efcc_result => {}, |
8d005ad9 |
273 | sql => '', |
274 | }, |
275 | { |
276 | where => { -or => $_ }, |
277 | cc_result => undef, |
8e40a627 |
278 | efcc_result => {}, |
8d005ad9 |
279 | sql => '', |
280 | }, |
22485a7e |
281 | { |
282 | where => { -or => [ foo => 1, $_ ] }, |
283 | cc_result => { foo => 1 }, |
284 | efcc_result => { foo => 1 }, |
285 | sql => 'WHERE foo = ?', |
286 | }, |
287 | { |
288 | where => { -or => [ $_, foo => 1 ] }, |
289 | cc_result => { foo => 1 }, |
290 | efcc_result => { foo => 1 }, |
291 | sql => 'WHERE foo = ?', |
292 | }, |
293 | { |
294 | where => { -and => [ fuu => 2, $_, foo => 1 ] }, |
295 | sql => 'WHERE fuu = ? AND foo = ?', |
296 | collapsed_sql => 'WHERE foo = ? AND fuu = ?', |
297 | cc_result => { foo => 1, fuu => 2 }, |
298 | efcc_result => { foo => 1, fuu => 2 }, |
299 | }, |
8d005ad9 |
300 | } ( |
301 | # bare |
302 | [], {}, |
303 | # singles |
304 | [ {} ], [ [] ], |
305 | # doubles |
306 | [ [], [] ], [ {}, {} ], [ [], {} ], [ {}, [] ], |
307 | # tripples |
308 | [ {}, [], {} ], [ [], {}, [] ] |
309 | )), |
310 | |
311 | # FIXME legacy compat crap, possibly worth undef/dieing in SQLMaker |
8e40a627 |
312 | { where => { artistid => {} }, sql => '', cc_result => undef, efcc_result => {}, efcc_n_result => {} }, |
8d005ad9 |
313 | |
314 | # batshit insanity, just to be thorough |
315 | { |
316 | where => { -and => [ [ 'artistid' ], [ -and => [ artistid => { '!=', 69 }, artistid => undef, artistid => { '=' => 200 } ]], artistid => [], { -or => [] }, { -and => [] }, [ 'charfield' ], { name => [] }, 'rank' ] }, |
5268b1da |
317 | cc_result => { artistid => [ -and => [], { '!=', 69 }, undef, 200 ], charfield => undef, name => [], rank => undef }, |
8d005ad9 |
318 | sql => 'WHERE artistid IS NULL AND artistid != ? AND artistid IS NULL AND artistid = ? AND 0=1 AND charfield IS NULL AND 0=1 AND rank IS NULL', |
5268b1da |
319 | collapsed_sql => 'WHERE 0=1 AND artistid != ? AND artistid IS NULL AND artistid = ? AND charfield IS NULL AND 0=1 AND rank IS NULL', |
8e40a627 |
320 | efcc_result => { artistid => UNRESOLVABLE_CONDITION }, |
321 | efcc_n_result => { artistid => UNRESOLVABLE_CONDITION, charfield => undef, rank => undef }, |
8d005ad9 |
322 | }, |
8acda57c |
323 | |
324 | # original test from RT#93244 |
325 | { |
326 | where => { |
327 | -and => [ |
328 | \[ |
329 | "LOWER(me.title) LIKE ?", |
330 | '%spoon%', |
331 | ], |
332 | [ { 'me.title' => 'Spoonful of bees' } ], |
333 | ]}, |
334 | cc_result => { |
335 | '' => \[ |
336 | "LOWER(me.title) LIKE ?", |
337 | '%spoon%', |
338 | ], |
339 | 'me.title' => 'Spoonful of bees', |
340 | }, |
341 | sql => 'WHERE LOWER(me.title) LIKE ? AND me.title = ?', |
8e40a627 |
342 | efcc_result => { 'me.title' => 'Spoonful of bees' }, |
8acda57c |
343 | } |
8d005ad9 |
344 | ) { |
345 | |
346 | for my $w ( |
347 | $t->{where}, |
953d5b7d |
348 | $t->{where}, # do it twice, make sure we didn't destory the condition |
8d005ad9 |
349 | [ -and => $t->{where} ], |
953d5b7d |
350 | [ -AND => $t->{where} ], |
351 | { -OR => [ -AND => $t->{where} ] }, |
8e40a627 |
352 | ( keys %{$t->{where}} <= 1 ? [ %{$t->{where}} ] : () ), |
353 | ( (keys %{$t->{where}} == 1 and $t->{where}{-or}) |
354 | ? ( ref $t->{where}{-or} eq 'HASH' |
355 | ? [ map { $_ => $t->{where}{-or}{$_} } sort keys %{$t->{where}{-or}} ] |
356 | : $t->{where}{-or} |
357 | ) |
358 | : () |
359 | ), |
8d005ad9 |
360 | ) { |
361 | my $name = do { local ($Data::Dumper::Indent, $Data::Dumper::Terse, $Data::Dumper::Sortkeys) = (0, 1, 1); Dumper $w }; |
362 | |
5268b1da |
363 | my ($generated_sql) = $sm->where($w); |
8d005ad9 |
364 | |
5268b1da |
365 | is_same_sql ( $generated_sql, $t->{sql}, "Expected SQL from $name" ) |
8d005ad9 |
366 | if exists $t->{sql}; |
367 | |
368 | my $collapsed_cond = $schema->storage->_collapse_cond($w); |
369 | |
5268b1da |
370 | is_same_sql( |
371 | ($sm->where($collapsed_cond))[0], |
372 | ( $t->{collapsed_sql} || $t->{sql} || $generated_sql ), |
373 | "Collapse did not alter *the semantics* of the final SQL based on $name", |
8d005ad9 |
374 | ); |
375 | |
376 | is_deeply( |
377 | $collapsed_cond, |
378 | $t->{cc_result}, |
379 | "Expected collapsed condition produced on $name", |
380 | ); |
381 | |
382 | is_deeply( |
383 | $schema->storage->_extract_fixed_condition_columns($w), |
384 | $t->{efcc_result}, |
385 | "Expected fixed_condition produced on $name", |
386 | ); |
8e40a627 |
387 | |
388 | is_deeply( |
389 | $schema->storage->_extract_fixed_condition_columns($w, 'consider_nulls'), |
390 | $t->{efcc_n_result}, |
391 | "Expected fixed_condition including NULLs produced on $name", |
392 | ) if $t->{efcc_n_result}; |
8d005ad9 |
393 | } |
394 | } |
395 | |
396 | done_testing; |