Commit | Line | Data |
ff1234ad |
1 | use strict; |
2 | use warnings; |
3 | |
4 | use lib qw(t/lib); |
5 | use Test::More; |
6 | use Test::Exception; |
31073ac7 |
7 | |
8 | use DBICTest::Schema::CD; |
9 | BEGIN { |
10 | # the default scalarref table name will not work well for this test |
11 | DBICTest::Schema::CD->table('cd'); |
12 | } |
13 | |
ff1234ad |
14 | use DBICTest; |
887d8da0 |
15 | use DBIC::DebugObj; |
16 | use DBIC::SqlMakerTest; |
ff1234ad |
17 | |
be64931c |
18 | my $schema = DBICTest->init_schema; |
19 | |
20 | my ($sql, @bind); |
21 | my $debugobj = DBIC::DebugObj->new (\$sql, \@bind); |
22 | my $orig_debugobj = $schema->storage->debugobj; |
23 | my $orig_debug = $schema->storage->debug; |
ff1234ad |
24 | |
25 | my $tkfks = $schema->resultset('FourKeys_to_TwoKeys'); |
26 | |
fd8076c8 |
27 | my ($fa, $fb, $fc) = $tkfks->related_resultset ('fourkeys')->populate ([ |
ff1234ad |
28 | [qw/foo bar hello goodbye sensors read_count/], |
29 | [qw/1 1 1 1 a 10 /], |
30 | [qw/2 2 2 2 b 20 /], |
fd8076c8 |
31 | [qw/1 1 1 2 c 30 /], |
ff1234ad |
32 | ]); |
33 | |
34 | # This is already provided by DBICTest |
35 | #my ($ta, $tb) = $tkfk->related_resultset ('twokeys')->populate ([ |
36 | # [qw/artist cd /], |
37 | # [qw/1 1 /], |
38 | # [qw/2 2 /], |
39 | #]); |
40 | my ($ta, $tb) = $schema->resultset ('TwoKeys') |
41 | ->search ( [ { artist => 1, cd => 1 }, { artist => 2, cd => 2 } ]) |
42 | ->all; |
43 | |
44 | my $tkfk_cnt = $tkfks->count; |
45 | |
46 | my $non_void_ctx = $tkfks->populate ([ |
47 | { autopilot => 'a', fourkeys => $fa, twokeys => $ta, pilot_sequence => 10 }, |
48 | { autopilot => 'b', fourkeys => $fb, twokeys => $tb, pilot_sequence => 20 }, |
49 | { autopilot => 'x', fourkeys => $fa, twokeys => $tb, pilot_sequence => 30 }, |
50 | { autopilot => 'y', fourkeys => $fb, twokeys => $ta, pilot_sequence => 40 }, |
51 | ]); |
52 | is ($tkfks->count, $tkfk_cnt += 4, 'FourKeys_to_TwoKeys populated succesfully'); |
53 | |
54 | # |
55 | # Make sure the forced group by works (i.e. the joining does not cause double-updates) |
56 | # |
57 | |
58 | # create a resultset matching $fa and $fb only |
fd8076c8 |
59 | my $fks = $schema->resultset ('FourKeys')->search ( |
60 | { |
61 | sensors => { '!=', 'c' }, |
62 | ( map { $_ => [1, 2] } qw/foo bar hello goodbye/ ), |
eb58c082 |
63 | }, { join => { fourkeys_to_twokeys => 'twokeys' }} |
fd8076c8 |
64 | ); |
ff1234ad |
65 | |
66 | is ($fks->count, 4, 'Joined FourKey count correct (2x2)'); |
be64931c |
67 | |
68 | $schema->storage->debugobj ($debugobj); |
69 | $schema->storage->debug (1); |
ff1234ad |
70 | $fks->update ({ read_count => \ 'read_count + 1' }); |
be64931c |
71 | $schema->storage->debugobj ($orig_debugobj); |
72 | $schema->storage->debug ($orig_debug); |
ff1234ad |
73 | |
be64931c |
74 | is_same_sql_bind ( |
75 | $sql, |
76 | \@bind, |
77 | 'UPDATE fourkeys |
78 | SET read_count = read_count + 1 |
fd8076c8 |
79 | WHERE ( ( ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? ) ) |
80 | ', |
81 | [ ("'1'", "'2'") x 4, "'c'" ], |
82 | 'Correct update-SQL with multijoin with pruning', |
83 | ); |
84 | |
85 | is ($fa->discard_changes->read_count, 11, 'Update ran only once on discard-join resultset'); |
86 | is ($fb->discard_changes->read_count, 21, 'Update ran only once on discard-join resultset'); |
87 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
88 | |
89 | # make the multi-join stick |
eb58c082 |
90 | my $fks_multi = $fks->search({ 'fourkeys_to_twokeys.pilot_sequence' => { '!=' => 666 } }); |
fd8076c8 |
91 | |
92 | $schema->storage->debugobj ($debugobj); |
93 | $schema->storage->debug (1); |
eb58c082 |
94 | $fks_multi->update ({ read_count => \ 'read_count + 1' }); |
fd8076c8 |
95 | $schema->storage->debugobj ($orig_debugobj); |
96 | $schema->storage->debug ($orig_debug); |
97 | |
98 | is_same_sql_bind ( |
99 | $sql, |
100 | \@bind, |
101 | 'UPDATE fourkeys |
102 | SET read_count = read_count + 1 |
be64931c |
103 | WHERE ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) OR ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? )', |
104 | [ map { "'$_'" } ( (1) x 4, (2) x 4 ) ], |
fd8076c8 |
105 | 'Correct update-SQL with multijoin without pruning', |
be64931c |
106 | ); |
ff1234ad |
107 | |
fd8076c8 |
108 | is ($fa->discard_changes->read_count, 12, 'Update ran only once on joined resultset'); |
109 | is ($fb->discard_changes->read_count, 22, 'Update ran only once on joined resultset'); |
110 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
be64931c |
111 | |
112 | # try the same sql with forced multicolumn in |
113 | $schema->storage->_use_multicolumn_in (1); |
114 | $schema->storage->debugobj ($debugobj); |
115 | $schema->storage->debug (1); |
eb58c082 |
116 | throws_ok { $fks_multi->update ({ read_count => \ 'read_count + 1' }) } # this can't actually execute, we just need the "as_query" |
eba59b7e |
117 | qr/\QDBI Exception:/ or do { $sql = ''; @bind = () }; |
be64931c |
118 | $schema->storage->_use_multicolumn_in (undef); |
119 | $schema->storage->debugobj ($orig_debugobj); |
120 | $schema->storage->debug ($orig_debug); |
121 | |
122 | is_same_sql_bind ( |
123 | $sql, |
124 | \@bind, |
125 | 'UPDATE fourkeys |
126 | SET read_count = read_count + 1 |
127 | WHERE ( |
128 | (foo, bar, hello, goodbye) IN ( |
129 | SELECT me.foo, me.bar, me.hello, me.goodbye |
130 | FROM fourkeys me |
fd8076c8 |
131 | LEFT JOIN fourkeys_to_twokeys fourkeys_to_twokeys ON |
132 | fourkeys_to_twokeys.f_bar = me.bar |
133 | AND fourkeys_to_twokeys.f_foo = me.foo |
134 | AND fourkeys_to_twokeys.f_goodbye = me.goodbye |
135 | AND fourkeys_to_twokeys.f_hello = me.hello |
8d005ad9 |
136 | WHERE ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND fourkeys_to_twokeys.pilot_sequence != ? AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? |
be64931c |
137 | ) |
138 | ) |
139 | ', |
fd8076c8 |
140 | [ |
8d005ad9 |
141 | ("'1'", "'2'") x 2, |
fd8076c8 |
142 | "'666'", |
8d005ad9 |
143 | ("'1'", "'2'") x 2, |
fd8076c8 |
144 | "'c'", |
145 | ], |
be64931c |
146 | 'Correct update-SQL with multicolumn in support', |
147 | ); |
ff1234ad |
148 | |
eb58c082 |
149 | # make a *premultiplied* join stick |
150 | my $fks_premulti = $fks->search({ 'twokeys.artist' => { '!=' => 666 } }); |
151 | |
152 | $schema->storage->debugobj ($debugobj); |
153 | $schema->storage->debug (1); |
154 | $fks_premulti->update ({ read_count => \ 'read_count + 1' }); |
155 | $schema->storage->debugobj ($orig_debugobj); |
156 | $schema->storage->debug ($orig_debug); |
157 | |
158 | is_same_sql_bind ( |
159 | $sql, |
160 | \@bind, |
161 | 'UPDATE fourkeys |
162 | SET read_count = read_count + 1 |
163 | WHERE ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) OR ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? )', |
164 | [ map { "'$_'" } ( (1) x 4, (2) x 4 ) ], |
165 | 'Correct update-SQL with premultiplied restricting join without pruning', |
166 | ); |
167 | |
168 | is ($fa->discard_changes->read_count, 13, 'Update ran only once on joined resultset'); |
169 | is ($fb->discard_changes->read_count, 23, 'Update ran only once on joined resultset'); |
170 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
171 | |
172 | |
ff1234ad |
173 | # |
be64931c |
174 | # Make sure multicolumn in or the equivalent functions correctly |
ff1234ad |
175 | # |
176 | |
177 | my $sub_rs = $tkfks->search ( |
178 | [ |
179 | { map { $_ => 1 } qw/artist.artistid cd.cdid fourkeys.foo fourkeys.bar fourkeys.hello fourkeys.goodbye/ }, |
180 | { map { $_ => 2 } qw/artist.artistid cd.cdid fourkeys.foo fourkeys.bar fourkeys.hello fourkeys.goodbye/ }, |
181 | ], |
182 | { |
183 | join => [ 'fourkeys', { twokeys => [qw/artist cd/] } ], |
184 | }, |
185 | ); |
186 | |
187 | is ($sub_rs->count, 2, 'Only two rows from fourkeys match'); |
188 | |
189 | # attempts to delete a grouped rs should fail miserably |
190 | throws_ok ( |
191 | sub { $sub_rs->search ({}, { distinct => 1 })->delete }, |
192 | qr/attempted a delete operation on a resultset which does group_by/, |
193 | 'Grouped rs update/delete not allowed', |
194 | ); |
195 | |
196 | # grouping on PKs only should pass |
af668ad6 |
197 | $sub_rs->search ( |
198 | {}, |
199 | { |
be64931c |
200 | group_by => [ reverse $sub_rs->result_source->primary_columns ], # reverse to make sure the PK-list comparison works |
af668ad6 |
201 | }, |
202 | )->update ({ pilot_sequence => \ 'pilot_sequence + 1' }); |
ff1234ad |
203 | |
204 | is_deeply ( |
205 | [ $tkfks->search ({ autopilot => [qw/a b x y/]}, { order_by => 'autopilot' }) |
8273e845 |
206 | ->get_column ('pilot_sequence')->all |
ff1234ad |
207 | ], |
208 | [qw/11 21 30 40/], |
209 | 'Only two rows incremented', |
210 | ); |
211 | |
af668ad6 |
212 | # also make sure weird scalarref usage works (RT#51409) |
213 | $tkfks->search ( |
214 | \ 'pilot_sequence BETWEEN 11 AND 21', |
215 | )->update ({ pilot_sequence => \ 'pilot_sequence + 1' }); |
216 | |
217 | is_deeply ( |
218 | [ $tkfks->search ({ autopilot => [qw/a b x y/]}, { order_by => 'autopilot' }) |
8273e845 |
219 | ->get_column ('pilot_sequence')->all |
af668ad6 |
220 | ], |
221 | [qw/12 22 30 40/], |
222 | 'Only two rows incremented (where => scalarref works)', |
223 | ); |
224 | |
59ac6523 |
225 | { |
226 | my $rs = $schema->resultset('FourKeys_to_TwoKeys')->search ( |
227 | { |
228 | -or => [ |
229 | { 'me.pilot_sequence' => 12 }, |
230 | { 'me.autopilot' => 'b' }, |
231 | ], |
232 | } |
233 | ); |
234 | lives_ok { $rs->update({ autopilot => 'z' }) } |
235 | 'Update with table name qualifier in -or conditions lives'; |
236 | is_deeply ( |
237 | [ $tkfks->search ({ pilot_sequence => [12, 22]}) |
238 | ->get_column ('autopilot')->all |
239 | ], |
240 | [qw/z z/], |
241 | '... and yields the right data', |
242 | ); |
243 | } |
244 | |
245 | |
ff1234ad |
246 | $sub_rs->delete; |
ff1234ad |
247 | is ($tkfks->count, $tkfk_cnt -= 2, 'Only two rows deleted'); |
fef47a8e |
248 | |
249 | # make sure limit-only deletion works |
250 | cmp_ok ($tkfk_cnt, '>', 1, 'More than 1 row left'); |
251 | $tkfks->search ({}, { rows => 1 })->delete; |
252 | is ($tkfks->count, $tkfk_cnt -= 1, 'Only one row deleted'); |
253 | |
887d8da0 |
254 | |
fd8076c8 |
255 | # check with sql-equality, as sqlite will accept most bad sql just fine |
be64931c |
256 | $schema->storage->debugobj ($debugobj); |
887d8da0 |
257 | $schema->storage->debug (1); |
fd8076c8 |
258 | |
259 | { |
260 | my $rs = $schema->resultset('CD')->search( |
261 | { 'me.year' => { '!=' => 2010 } }, |
262 | ); |
263 | |
264 | $rs->search({}, { join => 'liner_notes' })->delete; |
265 | is_same_sql_bind ( |
266 | $sql, |
267 | \@bind, |
268 | 'DELETE FROM cd WHERE ( year != ? )', |
269 | ["'2010'"], |
270 | 'Non-restricting multijoins properly thrown out' |
271 | ); |
272 | |
273 | $rs->search({}, { prefetch => 'liner_notes' })->delete; |
274 | is_same_sql_bind ( |
275 | $sql, |
276 | \@bind, |
277 | 'DELETE FROM cd WHERE ( year != ? )', |
278 | ["'2010'"], |
279 | 'Non-restricting multiprefetch thrown out' |
280 | ); |
281 | |
282 | $rs->search({}, { prefetch => 'artist' })->delete; |
283 | is_same_sql_bind ( |
284 | $sql, |
285 | \@bind, |
286 | 'DELETE FROM cd WHERE ( cdid IN ( SELECT me.cdid FROM cd me JOIN artist artist ON artist.artistid = me.artist WHERE ( me.year != ? ) ) )', |
287 | ["'2010'"], |
288 | 'Restricting prefetch left in, selector thrown out' |
289 | ); |
290 | |
554f3621 |
291 | # switch artist and cd to fully qualified table names |
292 | # make sure nothing is stripped out |
293 | my $cd_rsrc = $schema->source('CD'); |
294 | $cd_rsrc->name('main.cd'); |
295 | $cd_rsrc->relationship_info($_)->{attrs}{cascade_delete} = 0 |
296 | for $cd_rsrc->relationships; |
297 | |
298 | my $art_rsrc = $schema->source('Artist'); |
299 | $art_rsrc->name(\'main.artist'); |
300 | $art_rsrc->relationship_info($_)->{attrs}{cascade_delete} = 0 |
301 | for $art_rsrc->relationships; |
302 | |
303 | $rs->delete; |
fd8076c8 |
304 | is_same_sql_bind ( |
305 | $sql, |
306 | \@bind, |
554f3621 |
307 | 'DELETE FROM main.cd WHERE ( year != ? )', |
fd8076c8 |
308 | ["'2010'"], |
554f3621 |
309 | 'delete with fully qualified table name' |
310 | ); |
311 | |
312 | $rs->create({ title => 'foo', artist => 1, year => 2000 }); |
313 | $rs->delete_all; |
314 | is_same_sql_bind ( |
315 | $sql, |
316 | \@bind, |
317 | 'DELETE FROM main.cd WHERE ( cdid = ? )', |
318 | ["'1'"], |
319 | 'delete_all with fully qualified table name' |
320 | ); |
321 | |
322 | $rs->create({ cdid => 42, title => 'foo', artist => 2, year => 2000 }); |
323 | $rs->find(42)->delete; |
324 | is_same_sql_bind ( |
325 | $sql, |
326 | \@bind, |
327 | 'DELETE FROM main.cd WHERE ( cdid = ? )', |
328 | ["'42'"], |
329 | 'delete of object from table with fully qualified name' |
330 | ); |
331 | |
332 | $rs->create({ cdid => 42, title => 'foo', artist => 2, year => 2000 }); |
333 | $rs->find(42)->related_resultset('artist')->delete; |
334 | is_same_sql_bind ( |
335 | $sql, |
336 | \@bind, |
337 | 'DELETE FROM main.artist WHERE ( artistid IN ( SELECT me.artistid FROM main.artist me WHERE ( me.artistid = ? ) ) )', |
338 | ["'2'"], |
339 | 'delete of related object from scalarref fully qualified named table', |
340 | ); |
341 | |
342 | $schema->resultset('Artist')->find(3)->related_resultset('cds')->delete; |
343 | is_same_sql_bind ( |
344 | $sql, |
345 | \@bind, |
346 | 'DELETE FROM main.cd WHERE ( artist = ? )', |
347 | ["'3'"], |
348 | 'delete of related object from fully qualified named table', |
fd8076c8 |
349 | ); |
350 | |
554f3621 |
351 | $schema->resultset('Artist')->find(3)->cds_unordered->delete; |
fd8076c8 |
352 | is_same_sql_bind ( |
353 | $sql, |
354 | \@bind, |
554f3621 |
355 | 'DELETE FROM main.cd WHERE ( artist = ? )', |
356 | ["'3'"], |
357 | 'delete of related object from fully qualified named table via relaccessor', |
358 | ); |
359 | |
360 | $rs->search({}, { prefetch => 'artist' })->delete; |
361 | is_same_sql_bind ( |
362 | $sql, |
363 | \@bind, |
364 | 'DELETE FROM main.cd WHERE ( cdid IN ( SELECT me.cdid FROM main.cd me JOIN main.artist artist ON artist.artistid = me.artist WHERE ( me.year != ? ) ) )', |
fd8076c8 |
365 | ["'2010'"], |
366 | 'delete with fully qualified table name and subquery correct' |
367 | ); |
368 | |
31073ac7 |
369 | # check that as_subselect_rs works ok |
370 | # inner query is untouched, then a selector |
371 | # and an IN condition |
372 | $schema->resultset('CD')->search({ |
373 | 'me.cdid' => 1, |
374 | 'artist.name' => 'partytimecity', |
375 | }, { |
376 | join => 'artist', |
377 | })->as_subselect_rs->delete; |
378 | |
379 | is_same_sql_bind ( |
380 | $sql, |
381 | \@bind, |
382 | ' |
554f3621 |
383 | DELETE FROM main.cd |
31073ac7 |
384 | WHERE ( |
385 | cdid IN ( |
386 | SELECT me.cdid |
387 | FROM ( |
388 | SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track |
554f3621 |
389 | FROM main.cd me |
390 | JOIN main.artist artist ON artist.artistid = me.artist |
31073ac7 |
391 | WHERE artist.name = ? AND me.cdid = ? |
392 | ) me |
393 | ) |
394 | ) |
395 | ', |
396 | ["'partytimecity'", "'1'"], |
397 | 'Delete from as_subselect_rs works correctly' |
398 | ); |
fd8076c8 |
399 | } |
887d8da0 |
400 | |
47980c14 |
401 | $schema->storage->debugobj ($orig_debugobj); |
402 | $schema->storage->debug ($orig_debug); |
403 | |
fef47a8e |
404 | done_testing; |