Commit | Line | Data |
ff1234ad |
1 | use strict; |
2 | use warnings; |
3 | |
4 | use lib qw(t/lib); |
5 | use Test::More; |
6 | use Test::Exception; |
31073ac7 |
7 | |
8 | use DBICTest::Schema::CD; |
9 | BEGIN { |
10 | # the default scalarref table name will not work well for this test |
11 | DBICTest::Schema::CD->table('cd'); |
12 | } |
13 | |
ff1234ad |
14 | use DBICTest; |
887d8da0 |
15 | use DBIC::DebugObj; |
16 | use DBIC::SqlMakerTest; |
ff1234ad |
17 | |
be64931c |
18 | my $schema = DBICTest->init_schema; |
19 | |
20 | my ($sql, @bind); |
21 | my $debugobj = DBIC::DebugObj->new (\$sql, \@bind); |
22 | my $orig_debugobj = $schema->storage->debugobj; |
23 | my $orig_debug = $schema->storage->debug; |
ff1234ad |
24 | |
25 | my $tkfks = $schema->resultset('FourKeys_to_TwoKeys'); |
26 | |
fd8076c8 |
27 | my ($fa, $fb, $fc) = $tkfks->related_resultset ('fourkeys')->populate ([ |
ff1234ad |
28 | [qw/foo bar hello goodbye sensors read_count/], |
29 | [qw/1 1 1 1 a 10 /], |
30 | [qw/2 2 2 2 b 20 /], |
fd8076c8 |
31 | [qw/1 1 1 2 c 30 /], |
ff1234ad |
32 | ]); |
33 | |
34 | # This is already provided by DBICTest |
35 | #my ($ta, $tb) = $tkfk->related_resultset ('twokeys')->populate ([ |
36 | # [qw/artist cd /], |
37 | # [qw/1 1 /], |
38 | # [qw/2 2 /], |
39 | #]); |
40 | my ($ta, $tb) = $schema->resultset ('TwoKeys') |
41 | ->search ( [ { artist => 1, cd => 1 }, { artist => 2, cd => 2 } ]) |
42 | ->all; |
43 | |
44 | my $tkfk_cnt = $tkfks->count; |
45 | |
46 | my $non_void_ctx = $tkfks->populate ([ |
47 | { autopilot => 'a', fourkeys => $fa, twokeys => $ta, pilot_sequence => 10 }, |
48 | { autopilot => 'b', fourkeys => $fb, twokeys => $tb, pilot_sequence => 20 }, |
49 | { autopilot => 'x', fourkeys => $fa, twokeys => $tb, pilot_sequence => 30 }, |
50 | { autopilot => 'y', fourkeys => $fb, twokeys => $ta, pilot_sequence => 40 }, |
51 | ]); |
52 | is ($tkfks->count, $tkfk_cnt += 4, 'FourKeys_to_TwoKeys populated succesfully'); |
53 | |
54 | # |
55 | # Make sure the forced group by works (i.e. the joining does not cause double-updates) |
56 | # |
57 | |
58 | # create a resultset matching $fa and $fb only |
fd8076c8 |
59 | my $fks = $schema->resultset ('FourKeys')->search ( |
60 | { |
61 | sensors => { '!=', 'c' }, |
62 | ( map { $_ => [1, 2] } qw/foo bar hello goodbye/ ), |
63 | }, { join => 'fourkeys_to_twokeys'} |
64 | ); |
ff1234ad |
65 | |
66 | is ($fks->count, 4, 'Joined FourKey count correct (2x2)'); |
be64931c |
67 | |
68 | $schema->storage->debugobj ($debugobj); |
69 | $schema->storage->debug (1); |
ff1234ad |
70 | $fks->update ({ read_count => \ 'read_count + 1' }); |
be64931c |
71 | $schema->storage->debugobj ($orig_debugobj); |
72 | $schema->storage->debug ($orig_debug); |
ff1234ad |
73 | |
be64931c |
74 | is_same_sql_bind ( |
75 | $sql, |
76 | \@bind, |
77 | 'UPDATE fourkeys |
78 | SET read_count = read_count + 1 |
fd8076c8 |
79 | WHERE ( ( ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? ) ) |
80 | ', |
81 | [ ("'1'", "'2'") x 4, "'c'" ], |
82 | 'Correct update-SQL with multijoin with pruning', |
83 | ); |
84 | |
85 | is ($fa->discard_changes->read_count, 11, 'Update ran only once on discard-join resultset'); |
86 | is ($fb->discard_changes->read_count, 21, 'Update ran only once on discard-join resultset'); |
87 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
88 | |
89 | # make the multi-join stick |
90 | $fks = $fks->search({ 'fourkeys_to_twokeys.pilot_sequence' => { '!=' => 666 } }); |
91 | |
92 | $schema->storage->debugobj ($debugobj); |
93 | $schema->storage->debug (1); |
94 | $fks->update ({ read_count => \ 'read_count + 1' }); |
95 | $schema->storage->debugobj ($orig_debugobj); |
96 | $schema->storage->debug ($orig_debug); |
97 | |
98 | is_same_sql_bind ( |
99 | $sql, |
100 | \@bind, |
101 | 'UPDATE fourkeys |
102 | SET read_count = read_count + 1 |
be64931c |
103 | WHERE ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? ) OR ( bar = ? AND foo = ? AND goodbye = ? AND hello = ? )', |
104 | [ map { "'$_'" } ( (1) x 4, (2) x 4 ) ], |
fd8076c8 |
105 | 'Correct update-SQL with multijoin without pruning', |
be64931c |
106 | ); |
ff1234ad |
107 | |
fd8076c8 |
108 | is ($fa->discard_changes->read_count, 12, 'Update ran only once on joined resultset'); |
109 | is ($fb->discard_changes->read_count, 22, 'Update ran only once on joined resultset'); |
110 | is ($fc->discard_changes->read_count, 30, 'Update did not touch outlier'); |
be64931c |
111 | |
112 | # try the same sql with forced multicolumn in |
113 | $schema->storage->_use_multicolumn_in (1); |
114 | $schema->storage->debugobj ($debugobj); |
115 | $schema->storage->debug (1); |
66137dff |
116 | throws_ok { $fks->update ({ read_count => \ 'read_count + 1' }) } # this can't actually execute, we just need the "as_query" |
117 | qr/\Q DBI Exception:/ or do { $sql = ''; @bind = () }; |
be64931c |
118 | $schema->storage->_use_multicolumn_in (undef); |
119 | $schema->storage->debugobj ($orig_debugobj); |
120 | $schema->storage->debug ($orig_debug); |
121 | |
122 | is_same_sql_bind ( |
123 | $sql, |
124 | \@bind, |
125 | 'UPDATE fourkeys |
126 | SET read_count = read_count + 1 |
127 | WHERE ( |
128 | (foo, bar, hello, goodbye) IN ( |
129 | SELECT me.foo, me.bar, me.hello, me.goodbye |
130 | FROM fourkeys me |
fd8076c8 |
131 | LEFT JOIN fourkeys_to_twokeys fourkeys_to_twokeys ON |
132 | fourkeys_to_twokeys.f_bar = me.bar |
133 | AND fourkeys_to_twokeys.f_foo = me.foo |
134 | AND fourkeys_to_twokeys.f_goodbye = me.goodbye |
135 | AND fourkeys_to_twokeys.f_hello = me.hello |
136 | WHERE fourkeys_to_twokeys.pilot_sequence != ? AND ( bar = ? OR bar = ? ) AND ( foo = ? OR foo = ? ) AND ( goodbye = ? OR goodbye = ? ) AND ( hello = ? OR hello = ? ) AND sensors != ? |
be64931c |
137 | ) |
138 | ) |
139 | ', |
fd8076c8 |
140 | [ |
141 | "'666'", |
142 | ("'1'", "'2'") x 4, |
143 | "'c'", |
144 | ], |
be64931c |
145 | 'Correct update-SQL with multicolumn in support', |
146 | ); |
ff1234ad |
147 | |
148 | # |
be64931c |
149 | # Make sure multicolumn in or the equivalent functions correctly |
ff1234ad |
150 | # |
151 | |
152 | my $sub_rs = $tkfks->search ( |
153 | [ |
154 | { map { $_ => 1 } qw/artist.artistid cd.cdid fourkeys.foo fourkeys.bar fourkeys.hello fourkeys.goodbye/ }, |
155 | { map { $_ => 2 } qw/artist.artistid cd.cdid fourkeys.foo fourkeys.bar fourkeys.hello fourkeys.goodbye/ }, |
156 | ], |
157 | { |
158 | join => [ 'fourkeys', { twokeys => [qw/artist cd/] } ], |
159 | }, |
160 | ); |
161 | |
162 | is ($sub_rs->count, 2, 'Only two rows from fourkeys match'); |
163 | |
164 | # attempts to delete a grouped rs should fail miserably |
165 | throws_ok ( |
166 | sub { $sub_rs->search ({}, { distinct => 1 })->delete }, |
167 | qr/attempted a delete operation on a resultset which does group_by/, |
168 | 'Grouped rs update/delete not allowed', |
169 | ); |
170 | |
171 | # grouping on PKs only should pass |
af668ad6 |
172 | $sub_rs->search ( |
173 | {}, |
174 | { |
be64931c |
175 | group_by => [ reverse $sub_rs->result_source->primary_columns ], # reverse to make sure the PK-list comparison works |
af668ad6 |
176 | }, |
177 | )->update ({ pilot_sequence => \ 'pilot_sequence + 1' }); |
ff1234ad |
178 | |
179 | is_deeply ( |
180 | [ $tkfks->search ({ autopilot => [qw/a b x y/]}, { order_by => 'autopilot' }) |
8273e845 |
181 | ->get_column ('pilot_sequence')->all |
ff1234ad |
182 | ], |
183 | [qw/11 21 30 40/], |
184 | 'Only two rows incremented', |
185 | ); |
186 | |
af668ad6 |
187 | # also make sure weird scalarref usage works (RT#51409) |
188 | $tkfks->search ( |
189 | \ 'pilot_sequence BETWEEN 11 AND 21', |
190 | )->update ({ pilot_sequence => \ 'pilot_sequence + 1' }); |
191 | |
192 | is_deeply ( |
193 | [ $tkfks->search ({ autopilot => [qw/a b x y/]}, { order_by => 'autopilot' }) |
8273e845 |
194 | ->get_column ('pilot_sequence')->all |
af668ad6 |
195 | ], |
196 | [qw/12 22 30 40/], |
197 | 'Only two rows incremented (where => scalarref works)', |
198 | ); |
199 | |
59ac6523 |
200 | { |
201 | my $rs = $schema->resultset('FourKeys_to_TwoKeys')->search ( |
202 | { |
203 | -or => [ |
204 | { 'me.pilot_sequence' => 12 }, |
205 | { 'me.autopilot' => 'b' }, |
206 | ], |
207 | } |
208 | ); |
209 | lives_ok { $rs->update({ autopilot => 'z' }) } |
210 | 'Update with table name qualifier in -or conditions lives'; |
211 | is_deeply ( |
212 | [ $tkfks->search ({ pilot_sequence => [12, 22]}) |
213 | ->get_column ('autopilot')->all |
214 | ], |
215 | [qw/z z/], |
216 | '... and yields the right data', |
217 | ); |
218 | } |
219 | |
220 | |
ff1234ad |
221 | $sub_rs->delete; |
ff1234ad |
222 | is ($tkfks->count, $tkfk_cnt -= 2, 'Only two rows deleted'); |
fef47a8e |
223 | |
224 | # make sure limit-only deletion works |
225 | cmp_ok ($tkfk_cnt, '>', 1, 'More than 1 row left'); |
226 | $tkfks->search ({}, { rows => 1 })->delete; |
227 | is ($tkfks->count, $tkfk_cnt -= 1, 'Only one row deleted'); |
228 | |
887d8da0 |
229 | |
fd8076c8 |
230 | # check with sql-equality, as sqlite will accept most bad sql just fine |
be64931c |
231 | $schema->storage->debugobj ($debugobj); |
887d8da0 |
232 | $schema->storage->debug (1); |
fd8076c8 |
233 | |
234 | { |
235 | my $rs = $schema->resultset('CD')->search( |
236 | { 'me.year' => { '!=' => 2010 } }, |
237 | ); |
238 | |
239 | $rs->search({}, { join => 'liner_notes' })->delete; |
240 | is_same_sql_bind ( |
241 | $sql, |
242 | \@bind, |
243 | 'DELETE FROM cd WHERE ( year != ? )', |
244 | ["'2010'"], |
245 | 'Non-restricting multijoins properly thrown out' |
246 | ); |
247 | |
248 | $rs->search({}, { prefetch => 'liner_notes' })->delete; |
249 | is_same_sql_bind ( |
250 | $sql, |
251 | \@bind, |
252 | 'DELETE FROM cd WHERE ( year != ? )', |
253 | ["'2010'"], |
254 | 'Non-restricting multiprefetch thrown out' |
255 | ); |
256 | |
257 | $rs->search({}, { prefetch => 'artist' })->delete; |
258 | is_same_sql_bind ( |
259 | $sql, |
260 | \@bind, |
261 | 'DELETE FROM cd WHERE ( cdid IN ( SELECT me.cdid FROM cd me JOIN artist artist ON artist.artistid = me.artist WHERE ( me.year != ? ) ) )', |
262 | ["'2010'"], |
263 | 'Restricting prefetch left in, selector thrown out' |
264 | ); |
265 | |
266 | $rs->result_source->name('schema_qualified.cd'); |
267 | # this is expected to fail - we only want to collect the generated SQL |
268 | eval { $rs->delete }; |
269 | is_same_sql_bind ( |
270 | $sql, |
271 | \@bind, |
272 | 'DELETE FROM schema_qualified.cd WHERE ( year != ? )', |
273 | ["'2010'"], |
274 | 'delete with fully qualified table name and subquery correct' |
275 | ); |
276 | |
31073ac7 |
277 | # this is expected to fail - we only want to collect the generated SQL |
fd8076c8 |
278 | eval { $rs->search({}, { prefetch => 'artist' })->delete }; |
279 | is_same_sql_bind ( |
280 | $sql, |
281 | \@bind, |
282 | 'DELETE FROM schema_qualified.cd WHERE ( cdid IN ( SELECT me.cdid FROM schema_qualified.cd me JOIN artist artist ON artist.artistid = me.artist WHERE ( me.year != ? ) ) )', |
283 | ["'2010'"], |
284 | 'delete with fully qualified table name and subquery correct' |
285 | ); |
286 | |
287 | $rs->result_source->name('cd'); |
31073ac7 |
288 | |
289 | # check that as_subselect_rs works ok |
290 | # inner query is untouched, then a selector |
291 | # and an IN condition |
292 | $schema->resultset('CD')->search({ |
293 | 'me.cdid' => 1, |
294 | 'artist.name' => 'partytimecity', |
295 | }, { |
296 | join => 'artist', |
297 | })->as_subselect_rs->delete; |
298 | |
299 | is_same_sql_bind ( |
300 | $sql, |
301 | \@bind, |
302 | ' |
303 | DELETE FROM cd |
304 | WHERE ( |
305 | cdid IN ( |
306 | SELECT me.cdid |
307 | FROM ( |
308 | SELECT me.cdid, me.artist, me.title, me.year, me.genreid, me.single_track |
309 | FROM cd me |
310 | JOIN artist artist ON artist.artistid = me.artist |
311 | WHERE artist.name = ? AND me.cdid = ? |
312 | ) me |
313 | ) |
314 | ) |
315 | ', |
316 | ["'partytimecity'", "'1'"], |
317 | 'Delete from as_subselect_rs works correctly' |
318 | ); |
fd8076c8 |
319 | } |
887d8da0 |
320 | |
47980c14 |
321 | $schema->storage->debugobj ($orig_debugobj); |
322 | $schema->storage->debug ($orig_debug); |
323 | |
fef47a8e |
324 | done_testing; |