Fix spotty handling of complex order_by relationship attrs while prefetching
[dbsrgits/DBIx-Class.git] / lib / DBIx / Class / Storage / DBIHacks.pm
CommitLineData
c443438f 1package #hide from PAUSE
2 DBIx::Class::Storage::DBIHacks;
d28bb90d 3
4#
5# This module contains code that should never have seen the light of day,
6# does not belong in the Storage, or is otherwise unfit for public
7eb76996 7# display. The arrival of SQLA2 should immediately oboslete 90% of this
d28bb90d 8#
9
10use strict;
11use warnings;
12
13use base 'DBIx::Class::Storage';
14use mro 'c3';
15
16use Carp::Clan qw/^DBIx::Class/;
6298a324 17use List::Util 'first';
18use Scalar::Util 'blessed';
19use namespace::clean;
d28bb90d 20
21#
052e8431 22# This code will remove non-selecting/non-restricting joins from
4b1b5ea3 23# {from} specs, aiding the RDBMS query optimizer
052e8431 24#
25sub _prune_unused_joins {
4b1b5ea3 26 my ($self) = shift;
27
28 my ($from, $select, $where, $attrs) = @_;
052e8431 29
052e8431 30 if (ref $from ne 'ARRAY' || ref $from->[0] ne 'HASH' || ref $from->[1] ne 'ARRAY') {
31 return $from; # only standard {from} specs are supported
32 }
33
4b1b5ea3 34 my $aliastypes = $self->_resolve_aliastypes_from_select_args(@_);
35
36 # a grouped set will not be affected by amount of rows. Thus any
37 # {multiplying} joins can go
38 delete $aliastypes->{multiplying} if $attrs->{group_by};
39
052e8431 40
41 my @newfrom = $from->[0]; # FROM head is always present
42
43 my %need_joins = (map { %{$_||{}} } (values %$aliastypes) );
44 for my $j (@{$from}[1..$#$from]) {
539ffe87 45 push @newfrom, $j if (
4b1b5ea3 46 (! $j->[0]{-alias}) # legacy crap
539ffe87 47 ||
48 $need_joins{$j->[0]{-alias}}
49 );
052e8431 50 }
51
52 return \@newfrom;
53}
54
052e8431 55#
d28bb90d 56# This is the code producing joined subqueries like:
57# SELECT me.*, other.* FROM ( SELECT me.* FROM ... ) JOIN other ON ...
58#
59sub _adjust_select_args_for_complex_prefetch {
60 my ($self, $from, $select, $where, $attrs) = @_;
61
62 $self->throw_exception ('Nothing to prefetch... how did we get here?!')
63 if not @{$attrs->{_prefetch_select}};
64
65 $self->throw_exception ('Complex prefetches are not supported on resultsets with a custom from attribute')
66 if (ref $from ne 'ARRAY' || ref $from->[0] ne 'HASH' || ref $from->[1] ne 'ARRAY');
67
68
69 # generate inner/outer attribute lists, remove stuff that doesn't apply
70 my $outer_attrs = { %$attrs };
71 delete $outer_attrs->{$_} for qw/where bind rows offset group_by having/;
72
73 my $inner_attrs = { %$attrs };
74 delete $inner_attrs->{$_} for qw/for collapse _prefetch_select _collapse_order_by select as/;
75
76
77 # bring over all non-collapse-induced order_by into the inner query (if any)
78 # the outer one will have to keep them all
79 delete $inner_attrs->{order_by};
80 if (my $ord_cnt = @{$outer_attrs->{order_by}} - @{$outer_attrs->{_collapse_order_by}} ) {
81 $inner_attrs->{order_by} = [
82 @{$outer_attrs->{order_by}}[ 0 .. $ord_cnt - 1]
83 ];
84 }
85
d28bb90d 86 # generate the inner/outer select lists
87 # for inside we consider only stuff *not* brought in by the prefetch
88 # on the outside we substitute any function for its alias
89 my $outer_select = [ @$select ];
90 my $inner_select = [];
91 for my $i (0 .. ( @$outer_select - @{$outer_attrs->{_prefetch_select}} - 1) ) {
92 my $sel = $outer_select->[$i];
93
94 if (ref $sel eq 'HASH' ) {
95 $sel->{-as} ||= $attrs->{as}[$i];
96 $outer_select->[$i] = join ('.', $attrs->{alias}, ($sel->{-as} || "inner_column_$i") );
97 }
98
99 push @$inner_select, $sel;
bb9bffea 100
101 push @{$inner_attrs->{as}}, $attrs->{as}[$i];
d28bb90d 102 }
103
d28bb90d 104 # construct the inner $from for the subquery
48580715 105 # we need to prune first, because this will determine if we need a group_by below
052e8431 106 my $inner_from = $self->_prune_unused_joins ($from, $inner_select, $where, $inner_attrs);
ad630f4b 107
539ffe87 108 # if a multi-type join was needed in the subquery - add a group_by to simulate the
109 # collapse in the subq
110 $inner_attrs->{group_by} ||= $inner_select
6298a324 111 if first { ! $_->[0]{-is_single} } (@{$inner_from}[1 .. $#$inner_from]);
d28bb90d 112
d28bb90d 113 # generate the subquery
114 my $subq = $self->_select_args_to_query (
052e8431 115 $inner_from,
d28bb90d 116 $inner_select,
117 $where,
118 $inner_attrs,
119 );
120
121 my $subq_joinspec = {
122 -alias => $attrs->{alias},
052e8431 123 -source_handle => $inner_from->[0]{-source_handle},
d28bb90d 124 $attrs->{alias} => $subq,
125 };
126
127 # Generate the outer from - this is relatively easy (really just replace
128 # the join slot with the subquery), with a major caveat - we can not
129 # join anything that is non-selecting (not part of the prefetch), but at
130 # the same time is a multi-type relationship, as it will explode the result.
131 #
132 # There are two possibilities here
133 # - either the join is non-restricting, in which case we simply throw it away
134 # - it is part of the restrictions, in which case we need to collapse the outer
135 # result by tackling yet another group_by to the outside of the query
136
052e8431 137 # normalize a copy of $from, so it will be easier to work with further
138 # down (i.e. promote the initial hashref to an AoH)
139 $from = [ @$from ];
140 $from->[0] = [ $from->[0] ];
141
d28bb90d 142 # so first generate the outer_from, up to the substitution point
143 my @outer_from;
144 while (my $j = shift @$from) {
145 if ($j->[0]{-alias} eq $attrs->{alias}) { # time to swap
146 push @outer_from, [
147 $subq_joinspec,
148 @{$j}[1 .. $#$j],
149 ];
150 last; # we'll take care of what's left in $from below
151 }
152 else {
153 push @outer_from, $j;
154 }
155 }
156
052e8431 157 # scan the from spec against different attributes, and see which joins are needed
158 # in what role
159 my $outer_aliastypes =
539ffe87 160 $self->_resolve_aliastypes_from_select_args( $from, $outer_select, $where, $outer_attrs );
052e8431 161
d28bb90d 162 # see what's left - throw away if not selecting/restricting
163 # also throw in a group_by if restricting to guard against
164 # cross-join explosions
165 #
166 while (my $j = shift @$from) {
167 my $alias = $j->[0]{-alias};
168
1a736efb 169 if ($outer_aliastypes->{selecting}{$alias}) {
d28bb90d 170 push @outer_from, $j;
171 }
1a736efb 172 elsif ($outer_aliastypes->{restricting}{$alias}) {
d28bb90d 173 push @outer_from, $j;
539ffe87 174 $outer_attrs->{group_by} ||= $outer_select unless $j->[0]{-is_single};
d28bb90d 175 }
176 }
177
178 # demote the outer_from head
179 $outer_from[0] = $outer_from[0][0];
180
181 # This is totally horrific - the $where ends up in both the inner and outer query
182 # Unfortunately not much can be done until SQLA2 introspection arrives, and even
183 # then if where conditions apply to the *right* side of the prefetch, you may have
184 # to both filter the inner select (e.g. to apply a limit) and then have to re-filter
185 # the outer select to exclude joins you didin't want in the first place
186 #
187 # OTOH it can be seen as a plus: <ash> (notes that this query would make a DBA cry ;)
188 return (\@outer_from, $outer_select, $where, $outer_attrs);
189}
190
1a736efb 191#
192# I KNOW THIS SUCKS! GET SQLA2 OUT THE DOOR SO THIS CAN DIE!
193#
ad630f4b 194# Due to a lack of SQLA2 we fall back to crude scans of all the
195# select/where/order/group attributes, in order to determine what
196# aliases are neded to fulfill the query. This information is used
197# throughout the code to prune unnecessary JOINs from the queries
198# in an attempt to reduce the execution time.
199# Although the method is pretty horrific, the worst thing that can
1a736efb 200# happen is for it to fail due to some scalar SQL, which in turn will
201# result in a vocal exception.
539ffe87 202sub _resolve_aliastypes_from_select_args {
052e8431 203 my ( $self, $from, $select, $where, $attrs ) = @_;
546f1cd9 204
ad630f4b 205 $self->throw_exception ('Unable to analyze custom {from}')
206 if ref $from ne 'ARRAY';
546f1cd9 207
ad630f4b 208 # what we will return
964a3c71 209 my $aliases_by_type;
546f1cd9 210
ad630f4b 211 # see what aliases are there to work with
212 my $alias_list;
539ffe87 213 for (@$from) {
214 my $j = $_;
ad630f4b 215 $j = $j->[0] if ref $j eq 'ARRAY';
539ffe87 216 my $al = $j->{-alias}
217 or next;
218
219 $alias_list->{$al} = $j;
220 $aliases_by_type->{multiplying}{$al} = 1
221 unless $j->{-is_single};
546f1cd9 222 }
546f1cd9 223
1a736efb 224 # get a column to source/alias map (including unqualified ones)
225 my $colinfo = $self->_resolve_column_info ($from);
226
ad630f4b 227 # set up a botched SQLA
228 my $sql_maker = $self->sql_maker;
07f31d19 229
3f5b99fe 230 local $sql_maker->{having_bind}; # these are throw away results
231
232 # we can't scan properly without any quoting (\b doesn't cut it
233 # everywhere), so unless there is proper quoting set - use our
234 # own weird impossible character.
235 # Also in the case of no quoting, we need to explicitly disable
236 # name_sep, otherwise sorry nasty legacy syntax like
237 # { 'count(foo.id)' => { '>' => 3 } } will stop working >:(
238 local $sql_maker->{quote_char} = $sql_maker->{quote_char};
239 local $sql_maker->{name_sep} = $sql_maker->{name_sep};
240
241 unless (defined $sql_maker->{quote_char} and length $sql_maker->{quote_char}) {
242 $sql_maker->{quote_char} = "\x00";
243 $sql_maker->{name_sep} = '';
244 }
245
246 my ($lquote, $rquote, $sep) = map { quotemeta $_ } ($sql_maker->_quote_chars, $sql_maker->name_sep);
07f31d19 247
1a736efb 248 # generate sql chunks
249 my $to_scan = {
250 restricting => [
251 $sql_maker->_recurse_where ($where),
a7e643b1 252 $sql_maker->_parse_rs_attrs ({
1a736efb 253 map { $_ => $attrs->{$_} } (qw/group_by having/)
254 }),
255 ],
256 selecting => [
7d3139ac 257 $self->_extract_order_columns ($attrs->{order_by}, $sql_maker),
1a736efb 258 $sql_maker->_recurse_fields ($select),
259 ],
260 };
261
262 # throw away empty chunks
263 $_ = [ map { $_ || () } @$_ ] for values %$to_scan;
264
265 # first loop through all fully qualified columns and get the corresponding
266 # alias (should work even if they are in scalarrefs)
ad630f4b 267 for my $alias (keys %$alias_list) {
1a736efb 268 my $al_re = qr/
3f5b99fe 269 $lquote $alias $rquote $sep
1a736efb 270 |
3f5b99fe 271 \b $alias \.
1a736efb 272 /x;
273
1a736efb 274 for my $type (keys %$to_scan) {
275 for my $piece (@{$to_scan->{$type}}) {
276 $aliases_by_type->{$type}{$alias} = 1 if ($piece =~ $al_re);
277 }
ad630f4b 278 }
1a736efb 279 }
280
281 # now loop through unqualified column names, and try to locate them within
282 # the chunks
283 for my $col (keys %$colinfo) {
3f5b99fe 284 next if $col =~ / \. /x; # if column is qualified it was caught by the above
1a736efb 285
3f5b99fe 286 my $col_re = qr/ $lquote $col $rquote /x;
1a736efb 287
288 for my $type (keys %$to_scan) {
289 for my $piece (@{$to_scan->{$type}}) {
290 $aliases_by_type->{$type}{$colinfo->{$col}{-source_alias}} = 1 if ($piece =~ $col_re);
291 }
07f31d19 292 }
293 }
294
295 # Add any non-left joins to the restriction list (such joins are indeed restrictions)
ad630f4b 296 for my $j (values %$alias_list) {
07f31d19 297 my $alias = $j->{-alias} or next;
1a736efb 298 $aliases_by_type->{restricting}{$alias} = 1 if (
07f31d19 299 (not $j->{-join_type})
300 or
301 ($j->{-join_type} !~ /^left (?: \s+ outer)? $/xi)
302 );
303 }
304
305 # mark all join parents as mentioned
306 # (e.g. join => { cds => 'tracks' } - tracks will need to bring cds too )
964a3c71 307 for my $type (keys %$aliases_by_type) {
308 for my $alias (keys %{$aliases_by_type->{$type}}) {
309 $aliases_by_type->{$type}{$_} = 1
faeb2407 310 for (map { values %$_ } @{ $alias_list->{$alias}{-join_path} || [] });
07f31d19 311 }
312 }
ad630f4b 313
964a3c71 314 return $aliases_by_type;
07f31d19 315}
316
d28bb90d 317sub _resolve_ident_sources {
318 my ($self, $ident) = @_;
319
320 my $alias2source = {};
321 my $rs_alias;
322
323 # the reason this is so contrived is that $ident may be a {from}
324 # structure, specifying multiple tables to join
6298a324 325 if ( blessed $ident && $ident->isa("DBIx::Class::ResultSource") ) {
d28bb90d 326 # this is compat mode for insert/update/delete which do not deal with aliases
327 $alias2source->{me} = $ident;
328 $rs_alias = 'me';
329 }
330 elsif (ref $ident eq 'ARRAY') {
331
332 for (@$ident) {
333 my $tabinfo;
334 if (ref $_ eq 'HASH') {
335 $tabinfo = $_;
336 $rs_alias = $tabinfo->{-alias};
337 }
338 if (ref $_ eq 'ARRAY' and ref $_->[0] eq 'HASH') {
339 $tabinfo = $_->[0];
340 }
341
342 $alias2source->{$tabinfo->{-alias}} = $tabinfo->{-source_handle}->resolve
343 if ($tabinfo->{-source_handle});
344 }
345 }
346
347 return ($alias2source, $rs_alias);
348}
349
350# Takes $ident, \@column_names
351#
352# returns { $column_name => \%column_info, ... }
353# also note: this adds -result_source => $rsrc to the column info
354#
09e14fdc 355# If no columns_names are supplied returns info about *all* columns
356# for all sources
d28bb90d 357sub _resolve_column_info {
358 my ($self, $ident, $colnames) = @_;
359 my ($alias2src, $root_alias) = $self->_resolve_ident_sources($ident);
360
09e14fdc 361 my (%return, %seen_cols, @auto_colnames);
d28bb90d 362
363 # compile a global list of column names, to be able to properly
364 # disambiguate unqualified column names (if at all possible)
365 for my $alias (keys %$alias2src) {
366 my $rsrc = $alias2src->{$alias};
367 for my $colname ($rsrc->columns) {
368 push @{$seen_cols{$colname}}, $alias;
3f5b99fe 369 push @auto_colnames, "$alias.$colname" unless $colnames;
d28bb90d 370 }
371 }
372
09e14fdc 373 $colnames ||= [
374 @auto_colnames,
375 grep { @{$seen_cols{$_}} == 1 } (keys %seen_cols),
376 ];
377
d28bb90d 378 COLUMN:
379 foreach my $col (@$colnames) {
3f5b99fe 380 my ($alias, $colname) = $col =~ m/^ (?: ([^\.]+) \. )? (.+) $/x;
d28bb90d 381
382 unless ($alias) {
383 # see if the column was seen exactly once (so we know which rsrc it came from)
384 if ($seen_cols{$colname} and @{$seen_cols{$colname}} == 1) {
385 $alias = $seen_cols{$colname}[0];
386 }
387 else {
388 next COLUMN;
389 }
390 }
391
392 my $rsrc = $alias2src->{$alias};
393 $return{$col} = $rsrc && {
394 %{$rsrc->column_info($colname)},
395 -result_source => $rsrc,
396 -source_alias => $alias,
397 };
398 }
399
400 return \%return;
401}
402
289ac713 403# The DBIC relationship chaining implementation is pretty simple - every
404# new related_relationship is pushed onto the {from} stack, and the {select}
405# window simply slides further in. This means that when we count somewhere
406# in the middle, we got to make sure that everything in the join chain is an
407# actual inner join, otherwise the count will come back with unpredictable
408# results (a resultset may be generated with _some_ rows regardless of if
409# the relation which the $rs currently selects has rows or not). E.g.
410# $artist_rs->cds->count - normally generates:
411# SELECT COUNT( * ) FROM artist me LEFT JOIN cd cds ON cds.artist = me.artistid
412# which actually returns the number of artists * (number of cds || 1)
413#
414# So what we do here is crawl {from}, determine if the current alias is at
415# the top of the stack, and if not - make sure the chain is inner-joined down
416# to the root.
417#
31a8aaaf 418sub _inner_join_to_node {
289ac713 419 my ($self, $from, $alias) = @_;
420
421 # subqueries and other oddness are naturally not supported
422 return $from if (
423 ref $from ne 'ARRAY'
424 ||
425 @$from <= 1
426 ||
427 ref $from->[0] ne 'HASH'
428 ||
429 ! $from->[0]{-alias}
430 ||
7eb76996 431 $from->[0]{-alias} eq $alias # this last bit means $alias is the head of $from - nothing to do
289ac713 432 );
433
434 # find the current $alias in the $from structure
435 my $switch_branch;
436 JOINSCAN:
437 for my $j (@{$from}[1 .. $#$from]) {
438 if ($j->[0]{-alias} eq $alias) {
439 $switch_branch = $j->[0]{-join_path};
440 last JOINSCAN;
441 }
442 }
443
7eb76996 444 # something else went quite wrong
289ac713 445 return $from unless $switch_branch;
446
447 # So it looks like we will have to switch some stuff around.
448 # local() is useless here as we will be leaving the scope
449 # anyway, and deep cloning is just too fucking expensive
7eb76996 450 # So replace the first hashref in the node arrayref manually
289ac713 451 my @new_from = ($from->[0]);
faeb2407 452 my $sw_idx = { map { (values %$_), 1 } @$switch_branch }; #there's one k/v per join-path
289ac713 453
454 for my $j (@{$from}[1 .. $#$from]) {
455 my $jalias = $j->[0]{-alias};
456
457 if ($sw_idx->{$jalias}) {
458 my %attrs = %{$j->[0]};
459 delete $attrs{-join_type};
460 push @new_from, [
461 \%attrs,
462 @{$j}[ 1 .. $#$j ],
463 ];
464 }
465 else {
466 push @new_from, $j;
467 }
468 }
469
470 return \@new_from;
471}
472
bac6c4fb 473# Most databases do not allow aliasing of tables in UPDATE/DELETE. Thus
474# a condition containing 'me' or other table prefixes will not work
475# at all. What this code tries to do (badly) is introspect the condition
476# and remove all column qualifiers. If it bails out early (returns undef)
477# the calling code should try another approach (e.g. a subquery)
478sub _strip_cond_qualifiers {
479 my ($self, $where) = @_;
480
481 my $cond = {};
482
483 # No-op. No condition, we're updating/deleting everything
484 return $cond unless $where;
485
486 if (ref $where eq 'ARRAY') {
487 $cond = [
488 map {
489 my %hash;
490 foreach my $key (keys %{$_}) {
491 $key =~ /([^.]+)$/;
492 $hash{$1} = $_->{$key};
493 }
494 \%hash;
495 } @$where
496 ];
497 }
498 elsif (ref $where eq 'HASH') {
499 if ( (keys %$where) == 1 && ( (keys %{$where})[0] eq '-and' )) {
500 $cond->{-and} = [];
501 my @cond = @{$where->{-and}};
502 for (my $i = 0; $i < @cond; $i++) {
503 my $entry = $cond[$i];
504 my $hash;
037e8dca 505 my $ref = ref $entry;
506 if ($ref eq 'HASH' or $ref eq 'ARRAY') {
bac6c4fb 507 $hash = $self->_strip_cond_qualifiers($entry);
508 }
037e8dca 509 elsif (! $ref) {
bac6c4fb 510 $entry =~ /([^.]+)$/;
511 $hash->{$1} = $cond[++$i];
512 }
037e8dca 513 else {
514 $self->throw_exception ("_strip_cond_qualifiers() is unable to handle a condition reftype $ref");
515 }
bac6c4fb 516 push @{$cond->{-and}}, $hash;
517 }
518 }
519 else {
520 foreach my $key (keys %$where) {
521 $key =~ /([^.]+)$/;
522 $cond->{$1} = $where->{$key};
523 }
524 }
525 }
526 else {
527 return undef;
528 }
529
530 return $cond;
531}
532
7d3139ac 533sub _extract_order_columns {
1a736efb 534 my ($self, $order_by, $sql_maker) = @_;
c0748280 535
1a736efb 536 my $parser = sub {
537 my ($sql_maker, $order_by) = @_;
c0748280 538
1a736efb 539 return scalar $sql_maker->_order_by_chunks ($order_by)
540 unless wantarray;
c0748280 541
1a736efb 542 my @chunks;
543 for my $chunk (map { ref $_ ? @$_ : $_ } ($sql_maker->_order_by_chunks ($order_by) ) ) {
544 $chunk =~ s/\s+ (?: ASC|DESC ) \s* $//ix;
545 push @chunks, $chunk;
546 }
547
548 return @chunks;
549 };
550
551 if ($sql_maker) {
552 return $parser->($sql_maker, $order_by);
553 }
554 else {
555 $sql_maker = $self->sql_maker;
556 local $sql_maker->{quote_char};
557 return $parser->($sql_maker, $order_by);
558 }
c0748280 559}
bac6c4fb 560
d28bb90d 5611;