From: Peter Rabbitson Date: Wed, 18 Dec 2013 10:20:23 +0000 (+0100) Subject: We already have Storable as a dep, this is pointless X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=scpubgit%2FQ-Branch.git;a=commitdiff_plain;h=771ea2ecd7b6b670b4e04d81336abaf0b71186c5 We already have Storable as a dep, this is pointless --- diff --git a/t/04modifiers.t b/t/04modifiers.t index 3b024c3..c8d3ce1 100644 --- a/t/04modifiers.t +++ b/t/04modifiers.t @@ -8,8 +8,7 @@ use SQL::Abstract::Test import => ['is_same_sql_bind']; use Data::Dumper; use SQL::Abstract; - -my $dclone = eval { require Storable; \&Storable::dclone }; +use Storable 'dclone'; #### WARNING #### # @@ -392,8 +391,7 @@ for my $case (@and_or_tests) { my $sql = SQL::Abstract->new ($case->{args} || {}); - my $where_copy = $dclone->($case->{where}) - if $dclone;; + my $where_copy = dclone($case->{where}); lives_ok (sub { my ($stmt, @bind) = $sql->where($case->{where}); @@ -408,8 +406,7 @@ for my $case (@and_or_tests) { is (@w, 0, 'No warnings within and-or tests') || diag join "\n", 'Emitted warnings:', @w; - is_deeply ($case->{where}, $where_copy, 'Where conditions unchanged') - if $dclone; + is_deeply ($case->{where}, $where_copy, 'Where conditions unchanged'); } }