From: Tyler Riddle <t.riddle@shadowcat.co.uk>
Date: Thu, 18 Oct 2012 18:12:49 +0000 (-0700)
Subject: configurable exclusion of modules; preparing for more complicated filtering of files... 
X-Git-Tag: v0.003001_01~124
X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=scpubgit%2FObject-Remote.git;a=commitdiff_plain;h=f6ac59278cf0c86dc81d2da43e18b592ff2200f2

configurable exclusion of modules; preparing for more complicated filtering of files if needed
---

diff --git a/lib/Object/Remote/FatNode.pm b/lib/Object/Remote/FatNode.pm
index a1e7691..0d10bb9 100644
--- a/lib/Object/Remote/FatNode.pm
+++ b/lib/Object/Remote/FatNode.pm
@@ -4,6 +4,8 @@ use strictures 1;
 use Config;
 use B qw(perlstring);
 
+my @exclude_mods = qw(XSLoader.pm DynaLoader.pm);
+
 sub stripspace {
   my ($text) = @_;
   $text =~ /^(\s+)/ && $text =~ s/^$1//mg;
@@ -38,18 +40,23 @@ $command =~ s/\n/ /g;
 
 chomp(my @inc = qx($command));
 
+my %exclude = map { $_ => 1 } @exclude_mods; 
 my %mods = reverse @inc;
 
-my @non_core = grep +(
+foreach(keys(%mods)) {
+  if ($exclude{ $mods{$_} }) {
+    delete($mods{$_});    
+  }
+}
+
+sub filter_not_core {
   not (
     /^\Q$Config{privlibexp}/ or /^\Q$Config{archlibexp}/
-  )
-), keys %mods;
+  )        
+}
 
-#my @core_non_arch = grep +(
-#  /^\Q$Config{privlibexp}/
-#), grep !/\Q$Config{archname}/, grep !/\Q$Config{myarchname}/, keys %mods;
-my @core_non_arch; 
+my @before_inc = grep { filter_not_core() } keys %mods;
+my @after_inc;
 
 my $start = stripspace <<'END_START';
   # This chunk of stuff was generated by Object::Remote::FatNode. To find
@@ -58,23 +65,27 @@ my $start = stripspace <<'END_START';
   BEGIN {
   my (%fatpacked,%fatpacked_extra);
 END_START
+
+$start .= 'my %exclude = map { $_ => 1 } qw(' . join(' ', @exclude_mods) . ");\n";
+
 my $end = stripspace <<'END_END';
   s/^  //mg for values %fatpacked, values %fatpacked_extra;
 
   sub load_from_hash {
-    if ($_[1] eq 'XSLoader.pm' || $_[1] eq 'DynaLoader.pm') {
-      warn "Will not pre-load '$_[1]'";
-      return undef; 
-    }
-
     if (my $fat = $_[0]->{$_[1]}) {
+      if ($exclude{$_[1]}) {
+        warn "Will not pre-load '$_[1]'";
+        return undef; 
+      }
+ 
+      warn "handling $_[1]";
       open my $fh, '<', \$fat;
       return $fh;
     }
     
     #Uncomment this to find brokenness
     #warn "Missing $_[1]";
-    return
+    return;
   }
 
   unshift @INC, sub { load_from_hash(\%fatpacked, $_[1]) };
@@ -88,7 +99,7 @@ my $end = stripspace <<'END_END';
 END_END
 
 my %files = map +($mods{$_} => scalar do { local (@ARGV, $/) = ($_); <> }),
-              @non_core, @core_non_arch;
+              @before_inc, @after_inc;
 
 sub generate_fatpack_hash {
   my ($hash_name, $orig) = @_;
@@ -99,14 +110,9 @@ sub generate_fatpack_hash {
   .qq!${data}${name}\n!;
 }
 
-use Data::Dumper;
-warn "Dumping list of shipped modules";
-print STDERR "Core non-arch: ", Dumper(\@core_non_arch);
-print STDERR "Non-core: ", Dumper(\@non_core); 
-
 my @segments = (
-  map(generate_fatpack_hash('fatpacked', $_), sort map $mods{$_}, @non_core),
-  map(generate_fatpack_hash('fatpacked_extra', $_), sort map $mods{$_}, @core_non_arch),
+  map(generate_fatpack_hash('fatpacked', $_), sort map $mods{$_}, @before_inc),
+  map(generate_fatpack_hash('fatpacked_extra', $_), sort map $mods{$_}, @after_inc),
 );
 
 our $DATA = join "\n", $start, @segments, $end;