X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=scpubgit%2FObject-Remote.git;a=blobdiff_plain;f=lib%2FObject%2FRemote%2FReadChannel.pm;h=ed29f582628139db13a2b37a0abfc902c960c15d;hp=6bfc3694533508204d7edd70f1a6bd84a73cd72c;hb=8c3529062a426181861d58ee59fb8f10e0be68e5;hpb=c824fdf36c659b3b6dbafe23a3021f2b1d6eeb3f diff --git a/lib/Object/Remote/ReadChannel.pm b/lib/Object/Remote/ReadChannel.pm index 6bfc369..ed29f58 100644 --- a/lib/Object/Remote/ReadChannel.pm +++ b/lib/Object/Remote/ReadChannel.pm @@ -1,11 +1,12 @@ package Object::Remote::ReadChannel; use CPS::Future; -use Scalar::Util qw(weaken); -use Object::Remote::Logging qw(:log :dlog); -use POSIX; +use Scalar::Util qw(weaken openhandle); +use Object::Remote::Logging qw(:log :dlog router ); use Moo; +BEGIN { router()->exclude_forwarding } + has fh => ( is => 'ro', required => 1, trigger => sub { @@ -39,10 +40,7 @@ sub _receive_data_from { while (my $cb = $self->on_line_call and $$rb =~ s/^(.*)\n//) { $cb->(my $line = $1); } - #TODO this isn't compatible with Windows but would be if - #EAGAIN was set to something that could never match - #if on Windows - } elsif ($! != EAGAIN) { + } else { log_trace { "Got EOF or error, this read channel is done" }; Object::Remote->current_loop ->unwatch_io( @@ -58,11 +56,14 @@ sub DEMOLISH { my ($self, $gd) = @_; return if $gd; log_trace { "read channel is being demolished" }; + Object::Remote->current_loop ->unwatch_io( handle => $self->fh, on_read_ready => 1 ); + + } 1;