package Object::Remote::Role::Connector::PerlInterpreter;
-use IPC::Open2;
+#use IPC::Open2;
+use IPC::Open3;
use IO::Handle;
use Object::Remote::ModuleSender;
use Object::Remote::Handle;
use Object::Remote::Future;
+use Object::Remote::Logging qw( :log :dlog );
use Scalar::Util qw(blessed);
use Moo::Role;
return $hook ? $hook->sender : Object::Remote::ModuleSender->new;
}
+has perl_command => (is => 'lazy');
+
+#TODO convert nice value into optional feature enabled by
+#setting value of attribute
+#ulimit of ~500 megs of v-ram
+#TODO only works with ssh with quotes but only works locally
+#with out quotes
+sub _build_perl_command { [ 'sh', '-c', '"ulimit -v 500000; nice -n 15 perl -"' ] }
+#sub _build_perl_command { [ 'perl', '-' ] }
+
around connect => sub {
my ($orig, $self) = (shift, shift);
my $f = $self->$start::start($orig => @_);
return future {
$f->on_done(sub {
my ($conn) = $f->get;
+ my $sub = $conn->remote_sub('Object::Remote::Logging::init_logging_forwarding');
+ $sub->('Object::Remote::Logging', Object::Remote::Logging->arg_router);
Object::Remote::Handle->new(
connection => $conn,
class => 'Object::Remote::ModuleLoader',
} 2;
};
-sub _perl_command { 'perl', '-' }
+sub final_perl_command { shift->perl_command }
sub _start_perl {
my $self = shift;
+ Dlog_debug { "invoking connection to perl interpreter using command line: $_" } @{$self->final_perl_command};
+
+ #TODO open2() dupes the child stderr into the calling
+ #process stderr which means if this process exits the
+ #child is still attached to the shell - using open3()
+ #and having the run loop manage the stderr means this
+ #won't happen BUT if the run loop just sends the remote
+ #stderr data to the local stderr the logs will interleave
+ #for sure - a simple test would be to use open3() and just
+ #close the remote stderr and see what happens - a longer
+ #term solution would be for Object::Remote to offer a feature
+ #where the user of a connection species a destination for output
+ #either a file name or their own file handle and the node output
+ #is dumped to it
my $pid = open2(
my $foreign_stdout,
my $foreign_stdin,
- $self->_perl_command(@_),
+ @{$self->final_perl_command},
) or die "Failed to run perl at '$_[0]': $!";
+
+ Dlog_trace { "Connection to remote side successful; remote stdin and stdout: $_" } [ $foreign_stdin, $foreign_stdout ];
return ($foreign_stdin, $foreign_stdout, $pid);
}
+#TODO open2() forks off a child and I have not been able to locate
+#a mechanism for reaping dead children so they don't become zombies
+#CONFIRMED there is no reaping of children being done, find a safe
+#way to do it
sub _open2_for {
my $self = shift;
my ($foreign_stdin, $foreign_stdout, $pid) = $self->_start_perl(@_);
my $to_send = $self->fatnode_text;
+ log_debug { my $len = length($to_send); "Sending contents of fat node to remote node; size is '$len' characters" };
Object::Remote->current_loop
->watch_io(
handle => $foreign_stdin,
on_write_ready => sub {
- my $len = syswrite($foreign_stdin, $to_send, 4096);
+ my $len = syswrite($foreign_stdin, $to_send, 32768);
if (defined $len) {
substr($to_send, 0, $len) = '';
}
# if the stdin went away, we'll never get Shere
# so it's not a big deal to simply give up on !defined
if (!defined($len) or 0 == length($to_send)) {
+ log_trace { "Got EOF or error when writing fatnode data to filehandle, unwatching it" };
Object::Remote->current_loop
->unwatch_io(
handle => $foreign_stdin,
on_write_ready => 1
);
+ } else {
+ log_trace { "Sent $len bytes of fatnode data to remote side" };
}
}
);
$text .= "ENDFAT\n";
$text .= <<'END';
eval $Object::Remote::FatNode::DATA;
+die $@ if $@;
END
$text .= "__END__\n";
return $text;