use IPC::Open3;
use IO::Handle;
use Symbol;
-use Object::Remote::Logging qw( :log :dlog get_router );
+use Object::Remote::Logging qw(:log :dlog router);
use Object::Remote::ModuleSender;
use Object::Remote::Handle;
use Object::Remote::Future;
with 'Object::Remote::Role::Connector';
has module_sender => (is => 'lazy');
-has ulimit => ( is => 'ro' );
-has nice => ( is => 'ro' );
-has watchdog_timeout => ( is => 'ro', required => 1, default => sub { undef } );
+has ulimit => ( is => 'ro');
+has nice => ( is => 'ro');
+has watchdog_timeout => ( is => 'ro', required => 1, default => sub { undef });
has perl_command => (is => 'lazy');
+has pid => (is => 'rwp');
+has connection_id => (is => 'rwp');
#if no child_stderr file handle is specified then stderr
#of the child will be connected to stderr of the parent
has stderr => ( is => 'rw', default => sub { undef } );
+BEGIN { router()->exclude_forwarding; }
+
sub _build_module_sender {
my ($hook) =
grep {blessed($_) && $_->isa('Object::Remote::ModuleLoader::Hook') }
}
sub _build_perl_command {
- my ($self) = @_;
+ my ($self) = @_;
my $nice = $self->nice;
my $ulimit = $self->ulimit;
- my $shell_code = '';
-
+ my $perl_path = 'perl';
+ my $shell_code = '';
+
if (defined($ulimit)) {
- $shell_code .= "ulimit -v $ulimit; ";
+ $shell_code .= "ulimit $ulimit || exit 1; ";
}
-
+
if (defined($nice)) {
$shell_code .= "nice -n $nice ";
}
-
- $shell_code .= 'perl -';
-
- return [ 'sh', '-c', $shell_code ];
+
+ if (defined($ENV{OBJECT_REMOTE_PERL_BIN})) {
+ log_debug { "Using OBJECT_REMOTE_PERL_BIN environment variable as perl path" };
+ $perl_path = $ENV{OBJECT_REMOTE_PERL_BIN};
+ }
+
+ $shell_code .= $perl_path . ' -';
+
+ return [ 'bash', '-c', $shell_code ];
}
around connect => sub {
return future {
$f->on_done(sub {
my ($conn) = $f->get;
- $self->_setup_watchdog_reset($conn);
- my $sub = $conn->remote_sub('Object::Remote::Logging::init_logging_forwarding');
- $sub->('Object::Remote::Logging', router => get_router, connection_id => $conn->_id);
+ $self->_setup_watchdog_reset($conn);
+ my $sub = $conn->remote_sub('Object::Remote::Logging::init_remote_logging');
+ $sub->('Object::Remote::Logging', router => router(), connection_id => $conn->_id);
Object::Remote::Handle->new(
connection => $conn,
class => 'Object::Remote::ModuleLoader',
my $given_stderr = $self->stderr;
my $foreign_stderr;
- Dlog_debug { "invoking connection to perl interpreter using command line: $_" } @{$self->final_perl_command};
+ Dlog_verbose {
+ s/\n/ /g; "invoking connection to perl interpreter using command line: $_"
+ } @{$self->final_perl_command};
if (defined($given_stderr)) {
#if the stderr data goes to an existing file handle
@{$self->final_perl_command},
) or die "Failed to run perl at '$_[0]': $!";
+ $self->_set_pid($pid);
+
if (defined($given_stderr)) {
Dlog_debug { "Child process STDERR is being handled via run loop" };
my $self = shift;
my ($foreign_stdin, $foreign_stdout, $pid) = $self->_start_perl(@_);
my $to_send = $self->fatnode_text;
- log_debug { my $len = length($to_send); "Sending contents of fat node to remote node; size is '$len' characters" };
+ log_debug { my $len = length($to_send); "Sending contents of fat node to remote node; size is '$len' characters" };
Object::Remote->current_loop
->watch_io(
handle => $foreign_stdin,
my ($self, $conn) = @_;
my $timer_id;
- return unless $self->watchdog_timeout;
+ return unless $self->watchdog_timeout;
Dlog_trace { "Creating Watchdog management timer for connection id $_" } $conn->_id;
every => $self->watchdog_timeout / 3,
code => sub {
unless(defined($conn)) {
- log_trace { "Weak reference to connection in Watchdog was lost, terminating update timer $timer_id" };
+ log_warn { "Weak reference to connection in Watchdog was lost, terminating update timer $timer_id" };
+ Object::Remote->current_loop->unwatch_time($timer_id);
+ return;
+ }
+
+ unless($conn->is_valid) {
+ log_warn { "Watchdog timer found an invalid connection, removing the timer" };
Object::Remote->current_loop->unwatch_time($timer_id);
- return;
+ return;
}
-
+
Dlog_trace { "Reseting Watchdog for connection id $_" } $conn->_id;
#we do not want to block in the run loop so send the
#update off and ignore any result, we don't need it
#anyway
$conn->send_class_call(0, 'Object::Remote::WatchDog', 'reset');
}
- );
+ );
+
+ $conn->on_close->on_ready(sub {
+ log_debug { "Removing watchdog for connection that is now closed" };
+ Object::Remote->current_loop->unwatch_time($timer_id);
+ });
}
sub fatnode_text {
my ($self) = @_;
+ my $connection_timeout = $self->timeout;
+ my $watchdog_timeout = $self->watchdog_timeout;
my $text = '';
require Object::Remote::FatNode;
- if (defined($self->watchdog_timeout)) {
- $text = "my \$WATCHDOG_TIMEOUT = '" . $self->watchdog_timeout . "';\n";
- $text .= "alarm(\$WATCHDOG_TIMEOUT);\n";
+ if (defined($connection_timeout)) {
+ $text .= "alarm($connection_timeout);\n";
+ }
+
+ if (defined($watchdog_timeout)) {
+ $text .= "my \$WATCHDOG_TIMEOUT = $watchdog_timeout;\n";
} else {
- $text = "my \$WATCHDOG_TIMEOUT = undef;\n";
+ $text .= "my \$WATCHDOG_TIMEOUT = undef;\n";
}
+ $text .= '$Object::Remote::FatNode::REMOTE_NODE = "1";' . "\n";
+
$text .= <<'END';
$INC{'Object/Remote/FatNode.pm'} = __FILE__;
$Object::Remote::FatNode::DATA = <<'ENDFAT';