package Object::Remote::Role::Connector::PerlInterpreter;
-use IPC::Open2;
use IPC::Open3;
use IO::Handle;
+use Symbol;
+use Object::Remote::Logging qw(:log :dlog router);
use Object::Remote::ModuleSender;
use Object::Remote::Handle;
use Object::Remote::Future;
-use Object::Remote::Logging qw( :log :dlog );
-use Scalar::Util qw(blessed);
-use POSIX ":sys_wait_h";
+use Scalar::Util qw(blessed weaken);
use Moo::Role;
with 'Object::Remote::Role::Connector';
-#TODO ugh breaks some of the stuff in System::Introspector::Util by
-#screwing with status value of child
-BEGIN {
- $SIG{CHLD} = sub {
- my $kid;
- do {
- $kid = waitpid(-1, WNOHANG);
- } while $kid > 0;
- }
-}
-
has module_sender => (is => 'lazy');
+has ulimit => ( is => 'ro');
+has nice => ( is => 'ro');
+has watchdog_timeout => ( is => 'ro', required => 1, default => sub { undef });
+has perl_command => (is => 'lazy');
+has pid => (is => 'rwp');
+has connection_id => (is => 'rwp');
+
#if no child_stderr file handle is specified then stderr
#of the child will be connected to stderr of the parent
-has stderr => ( is => 'rw', default => sub { \*STDERR } );
-#has stderr => ( is => 'rw' );
+has stderr => ( is => 'rw', default => sub { undef } );
+
+BEGIN { router()->exclude_forwarding; }
sub _build_module_sender {
my ($hook) =
return $hook ? $hook->sender : Object::Remote::ModuleSender->new;
}
-has perl_command => (is => 'lazy');
+sub _build_perl_command {
+ my ($self) = @_;
+ my $nice = $self->nice;
+ my $ulimit = $self->ulimit;
+ my $perl_path = 'perl';
+ my $shell_code = '';
-#TODO convert nice value into optional feature enabled by
-#setting value of attribute
-#ulimit of ~500 megs of v-ram
-#TODO only works with ssh with quotes but only works locally
-#with out quotes
-#sub _build_perl_command { [ 'sh', '-c', '"ulimit -v 80000; nice -n 15 perl -"' ] }
-sub _build_perl_command { [ 'sh', '-c', '"ulimit -v 200000; nice -n 15 perl -"' ] }
-#sub _build_perl_command { [ 'perl', '-' ] }
+ if (defined($ulimit)) {
+ $shell_code .= "ulimit $ulimit || exit 1; ";
+ }
+
+ if (defined($nice)) {
+ $shell_code .= "nice -n $nice ";
+ }
+
+ if (defined($ENV{OBJECT_REMOTE_PERL_BIN})) {
+ log_debug { "Using OBJECT_REMOTE_PERL_BIN environment variable as perl path" };
+ $perl_path = $ENV{OBJECT_REMOTE_PERL_BIN};
+ }
+
+ $shell_code .= $perl_path . ' -';
+
+ return [ 'bash', '-c', $shell_code ];
+}
around connect => sub {
my ($orig, $self) = (shift, shift);
return future {
$f->on_done(sub {
my ($conn) = $f->get;
- my $sub = $conn->remote_sub('Object::Remote::Logging::init_logging_forwarding');
- $sub->('Object::Remote::Logging', Object::Remote::Logging->arg_router);
+ $self->_setup_watchdog_reset($conn);
+ my $sub = $conn->remote_sub('Object::Remote::Logging::init_remote_logging');
+ $sub->('Object::Remote::Logging', router => router(), connection_id => $conn->_id);
Object::Remote::Handle->new(
connection => $conn,
class => 'Object::Remote::ModuleLoader',
my $given_stderr = $self->stderr;
my $foreign_stderr;
- Dlog_debug { "invoking connection to perl interpreter using command line: $_" } @{$self->final_perl_command};
-
- use Symbol;
-
+ Dlog_verbose {
+ s/\n/ /g; "invoking connection to perl interpreter using command line: $_"
+ } @{$self->final_perl_command};
+
if (defined($given_stderr)) {
- $foreign_stderr = gensym();
+ #if the stderr data goes to an existing file handle
+ #an anonymous file handle is required
+ #as the other half of a pipe style file handle pair
+ #so the file handles can go into the run loop
+ $foreign_stderr = gensym();
} else {
- $foreign_stderr = ">&STDERR";
+ #if no file handle has been specified
+ #for the child's stderr then connect
+ #the child stderr to the parent stderr
+ $foreign_stderr = ">&STDERR";
}
my $pid = open3(
@{$self->final_perl_command},
) or die "Failed to run perl at '$_[0]': $!";
+ $self->_set_pid($pid);
+
if (defined($given_stderr)) {
- log_warn { "using experimental cat for child stderr" };
+ Dlog_debug { "Child process STDERR is being handled via run loop" };
- #TODO refactor if this solves the problem
- Object::Remote->current_loop
- ->watch_io(
- handle => $foreign_stderr,
- on_read_ready => sub {
- my $buf = '';
- my $len = sysread($foreign_stderr, $buf, 32768);
- if (!defined($len) or $len == 0) {
- log_trace { "Got EOF or error on child stderr, removing from watcher" };
- $self->stderr(undef);
- Object::Remote->current_loop
- ->unwatch_io(
- handle => $foreign_stderr,
- on_read_ready => 1
- );
+ Object::Remote->current_loop
+ ->watch_io(
+ handle => $foreign_stderr,
+ on_read_ready => sub {
+ my $buf = '';
+ my $len = sysread($foreign_stderr, $buf, 32768);
+ if (!defined($len) or $len == 0) {
+ log_trace { "Got EOF or error on child stderr, removing from watcher" };
+ $self->stderr(undef);
+ Object::Remote->current_loop->unwatch_io(
+ handle => $foreign_stderr,
+ on_read_ready => 1
+ );
} else {
- Dlog_trace { "got $len characters of stderr data for connection" };
- print $given_stderr $buf or die "could not send stderr data: $!";
+ Dlog_trace { "got $len characters of stderr data for connection" };
+ print $given_stderr $buf or die "could not send stderr data: $!";
}
}
);
}
- #TODO open2() dupes the child stderr into the calling
- #process stderr which means if this process exits the
- #child is still attached to the shell - using open3()
- #and having the run loop manage the stderr means this
- #won't happen BUT if the run loop just sends the remote
- #stderr data to the local stderr the logs will interleave
- #for sure - a simple test would be to use open3() and just
- #close the remote stderr and see what happens - a longer
- #term solution would be for Object::Remote to offer a feature
- #where the user of a connection species a destination for output
- #either a file name or their own file handle and the node output
- #is dumped to it
-# my $pid = open2(
-# my $foreign_stdout,
-# my $foreign_stdin,
-# @{$self->final_perl_command},
-# ) or die "Failed to run perl at '$_[0]': $!";
-#
-# Dlog_trace { "Connection to remote side successful; remote stdin and stdout: $_" } [ $foreign_stdin, $foreign_stdout ];
-
-
- return ($foreign_stdin, $foreign_stdout, $pid);
+ return ($foreign_stdin, $foreign_stdout, $pid);
}
-#TODO open2() forks off a child and I have not been able to locate
-#a mechanism for reaping dead children so they don't become zombies
-#CONFIRMED there is no reaping of children being done, find a safe
-#way to do it
sub _open2_for {
my $self = shift;
my ($foreign_stdin, $foreign_stdout, $pid) = $self->_start_perl(@_);
my $to_send = $self->fatnode_text;
- log_debug { my $len = length($to_send); "Sending contents of fat node to remote node; size is '$len' characters" };
+ log_debug { my $len = length($to_send); "Sending contents of fat node to remote node; size is '$len' characters" };
Object::Remote->current_loop
->watch_io(
handle => $foreign_stdin,
->unwatch_io(
handle => $foreign_stdin,
on_write_ready => 1
- );
+ );
} else {
log_trace { "Sent $len bytes of fatnode data to remote side" };
}
return ($foreign_stdin, $foreign_stdout, $pid);
}
+sub _setup_watchdog_reset {
+ my ($self, $conn) = @_;
+ my $timer_id;
+
+ return unless $self->watchdog_timeout;
+
+ Dlog_trace { "Creating Watchdog management timer for connection id $_" } $conn->_id;
+
+ weaken($conn);
+
+ $timer_id = Object::Remote->current_loop->watch_time(
+ every => $self->watchdog_timeout / 3,
+ code => sub {
+ unless(defined($conn)) {
+ log_warn { "Weak reference to connection in Watchdog was lost, terminating update timer $timer_id" };
+ Object::Remote->current_loop->unwatch_time($timer_id);
+ return;
+ }
+
+ unless($conn->is_valid) {
+ log_warn { "Watchdog timer found an invalid connection, removing the timer" };
+ Object::Remote->current_loop->unwatch_time($timer_id);
+ return;
+ }
+
+ Dlog_trace { "Reseting Watchdog for connection id $_" } $conn->_id;
+ #we do not want to block in the run loop so send the
+ #update off and ignore any result, we don't need it
+ #anyway
+ $conn->send_class_call(0, 'Object::Remote::WatchDog', 'reset');
+ }
+ );
+
+ $conn->on_close->on_ready(sub {
+ log_debug { "Removing watchdog for connection that is now closed" };
+ Object::Remote->current_loop->unwatch_time($timer_id);
+ });
+}
+
sub fatnode_text {
my ($self) = @_;
- require Object::Remote::FatNode;
+ my $connection_timeout = $self->timeout;
+ my $watchdog_timeout = $self->watchdog_timeout;
my $text = '';
- $text .= 'BEGIN { $ENV{OBJECT_REMOTE_DEBUG} = 1 }'."\n"
- if $ENV{OBJECT_REMOTE_DEBUG};
+
+ require Object::Remote::FatNode;
+
+ if (defined($connection_timeout)) {
+ $text .= "alarm($connection_timeout);\n";
+ }
+
+ if (defined($watchdog_timeout)) {
+ $text .= "my \$WATCHDOG_TIMEOUT = $watchdog_timeout;\n";
+ } else {
+ $text .= "my \$WATCHDOG_TIMEOUT = undef;\n";
+ }
+
+ $text .= '$Object::Remote::FatNode::REMOTE_NODE = "1";' . "\n";
+
$text .= <<'END';
$INC{'Object/Remote/FatNode.pm'} = __FILE__;
$Object::Remote::FatNode::DATA = <<'ENDFAT';
eval $Object::Remote::FatNode::DATA;
die $@ if $@;
END
+
$text .= "__END__\n";
return $text;
}
projects / scpubgit/Object-Remote.git / blobdiff