use CPS::Future;
use Scalar::Util qw(weaken);
-use Object::Remote::Logging qw(:log);
+use Object::Remote::Logging qw(:log :dlog);
+use POSIX;
use Moo;
has fh => (
#there is no actual data to read from the socket
sub _receive_data_from {
my ($self, $fh) = @_;
- log_trace { "Preparing to read data" };
+ Dlog_trace { "Preparing to read data from $_" } $fh;
#use Carp qw(cluck); cluck();
my $rb = $self->_receive_data_buffer;
#TODO is there a specific reason sysread() and syswrite() aren't
#a part of ::MiniLoop? It's one spot to handle errors and other
#logic involving filehandles
- #TODO why are the buffers so small? BUFSIZ is usually 32768
- my $len = sysread($fh, $$rb, 1024, length($$rb));
+ my $len = sysread($fh, $$rb, 32768, length($$rb));
my $err = defined($len) ? '' : ": $!";
if (defined($len) and $len > 0) {
log_trace { "Read $len bytes of data" };
while (my $cb = $self->on_line_call and $$rb =~ s/^(.*)\n//) {
$cb->(my $line = $1);
}
- } else {
+ #TODO this isn't compatible with Windows but would be if
+ #EAGAIN was set to something that could never match
+ #if on Windows
+ } elsif ($! != EAGAIN) {
log_trace { "Got EOF or error, this read channel is done" };
Object::Remote->current_loop
->unwatch_io(