first attempt at fixing ssh/sh escaping problem with perl_command - works but isn...

[scpubgit/Object-Remote.git] / lib / Object / Remote / Connector / SSH.pm

diff --git a/lib/Object/Remote/Connector/SSH.pm b/lib/Object/Remote/Connector/SSH.pm
index 7d6142c..fcfb445 100644 (file)
--- a/lib/Object/Remote/Connector/SSH.pm
+++ b/lib/Object/Remote/Connector/SSH.pm
@@ -1,42 +1,53 @@
 package Object::Remote::Connector::SSH;
 
-use Object::Remote::FatNode;
 use Object::Remote::ModuleSender;
 use Object::Remote::Handle;
-use IPC::Open2;
 use Moo;
 
-with 'Object::Remote::Role::Connector';
+with 'Object::Remote::Role::Connector::PerlInterpreter';
 
-sub _open2_for {
-  my $self = shift;
-  my $pid = open2(my $ssh_stdout, my $ssh_stdin, 'ssh', $_[0], 'perl', '-')
-    or die "Failed to start ssh connection: $!";;
-  print $ssh_stdin $Object::Remote::FatNode::DATA, "__END__\n";
-  return ($ssh_stdin, $ssh_stdout, $pid);
+has ssh_to => (is => 'ro', required => 1);
+
+has ssh_perl_command => (is => 'lazy');
+
+has ssh_options => (is => 'ro', default => sub { [ '-A' ] });
+
+has ssh_command => (is => 'ro', default => sub { 'ssh' });
+
+#TODO properly integrate if this works
+BEGIN { $ENV{TERM} = 'dumb'; } 
+
+sub _escape_shell_arg { 
+    my ($self, $str) = (@_);
+    $str =~ s/((?:^|[^\\])(?:\\\\)*)'/$1\\'/g;
+    return "$str";
 }
 
-around connect => sub {
-  my ($orig, $self) = (shift, shift);
-  my $conn = $self->$orig(@_);
-  Object::Remote::Handle->new(
-    connection => $conn,
-    class => 'Object::Remote::ModuleLoader',
-    args => { module_sender => Object::Remote::ModuleSender->new }
-  )->disarm_free;
-  return $conn;
-};
 
-sub _ssh_object_for {
-  my ($self, $on) = @_;
-  $self->ssh_masters->{$on} ||= Net::OpenSSH->new($on);
+sub _build_ssh_perl_command {
+  my ($self) = @_;
+  my $perl_command = join('', @{$self->perl_command});
+  
+  #TODO non-trivial to escape properly for ssh and shell
+  #this "works" but is not right, needs to be replaced
+  #after testing
+  return [
+    do { my $c = $self->ssh_command; ref($c) ? @$c : $c },
+    @{$self->ssh_options}, $self->ssh_to,
+    $self->_escape_shell_arg($perl_command),
+  ];
 }
 
+sub final_perl_command { shift->ssh_perl_command }
+
+no warnings 'once';
+
 push @Object::Remote::Connection::Guess, sub { 
   for ($_[0]) {
     # 0-9 a-z _ - first char, those or . subsequent - hostnamish
-    if (defined and !ref and /^(?:.*?\@)?[\w\-][\w\-\.]*/) {
-      return __PACKAGE__->new->connect($_[0]);
+    if (defined and !ref and /^(?:.*?\@)?[\w\-][\w\-\.]/) {
+      my $host = shift(@_);
+      return __PACKAGE__->new(@_, ssh_to => $host);
     }
   }
   return;