From: Karen Etheridge Date: Thu, 12 Sep 2013 16:20:23 +0000 (-0700) Subject: use $Config{path_sep} in tests, not : X-Git-Tag: 1.008014~2 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2Flocal-lib.git;a=commitdiff_plain;h=6ba49accd2619a5c11944ac946ae5fc58bced0c1 use $Config{path_sep} in tests, not : --- diff --git a/t/bad_variables.t b/t/bad_variables.t index c8bbb63..4aa0229 100644 --- a/t/bad_variables.t +++ b/t/bad_variables.t @@ -2,6 +2,7 @@ use strict; use warnings; use Test::More tests => 5; use File::Temp 'tempdir'; +use Config; use local::lib (); # remember the original value of this, in case we are already running inside a @@ -13,22 +14,22 @@ my $dir2 = tempdir('test_local_lib-XXXXX', DIR => Cwd::abs_path('t'), CLEANUP => my $dir3 = tempdir('test_local_lib-XXXXX', DIR => Cwd::abs_path('t'), CLEANUP => 1); ok(!(grep { $dir1 eq $_ } @INC), 'new dir is not already in @INC'); -ok(!(grep { $dir1 eq $_ } split /:/, ($ENV{PERL5LIB}||'')), 'new dir is not already in PERL5LIB'); +ok(!(grep { $dir1 eq $_ } split /\Q$Config{path_sep}\E/, ($ENV{PERL5LIB}||'')), 'new dir is not already in PERL5LIB'); local::lib->import($dir1); local::lib->import($dir2); # we have junk in here now -$ENV{PERL_LOCAL_LIB_ROOT} .= ':' . $dir3; +$ENV{PERL_LOCAL_LIB_ROOT} .= $Config{path_sep} . $dir3; local::lib->import($dir1); is( $ENV{PERL_LOCAL_LIB_ROOT}, - join(':', (grep { $_ } $orig_llr, $dir2, $dir1)), + join($Config{path_sep}, (grep { $_ } $orig_llr, $dir2, $dir1)), 'dir1 should have been removed and added back in at the top', ); ok((grep { /\Q$dir1\E/ } @INC), 'new dir has been added to @INC'); -ok((grep { /\Q$dir1\E/ } split /:/, $ENV{PERL5LIB}), 'new dir has been added to PERL5LIB'); +ok((grep { /\Q$dir1\E/ } split /\Q$Config{path_sep}\E/, $ENV{PERL5LIB}), 'new dir has been added to PERL5LIB');