test that junk added to ROOT doesn't end up in active_paths

[p5sagit/local-lib.git] / t / bad_variables.t

diff --git a/t/bad_variables.t b/t/bad_variables.t
index a7ba32b..6a8a139 100644 (file)
--- a/t/bad_variables.t
+++ b/t/bad_variables.t
@@ -1,15 +1,13 @@
 use strict;
 use warnings;
-use Test::More tests => 5;
+use Test::More tests => 6;
 use File::Temp 'tempdir';
 use Config;
 use local::lib ();
 
 use lib 't/lib'; use TempDir;
 
-# remember the original value of this, in case we are already running inside a
-# local::lib
-my $orig_llr = $ENV{PERL_LOCAL_LIB_ROOT} || '';
+delete $ENV{PERL_LOCAL_LIB_ROOT};
 
 my $dir1 = mk_temp_dir('test_local_lib-XXXXX');
 my $dir2 = mk_temp_dir('test_local_lib-XXXXX');
@@ -22,16 +20,18 @@ local::lib->import($dir1);
 local::lib->import($dir2);
 
 # we have junk in here now
-$ENV{PERL_LOCAL_LIB_ROOT} .= $Config{path_sep} . $dir3;
+$ENV{PERL_LOCAL_LIB_ROOT} = $dir3 . $Config{path_sep} . $ENV{PERL_LOCAL_LIB_ROOT};
 
 local::lib->import($dir1);
 
 is(
     $ENV{PERL_LOCAL_LIB_ROOT},
-    join($Config{path_sep}, (grep { $_ } $orig_llr, $dir2, $dir1)),
-    'dir1 should have been removed and added back in at the top',
+    join($Config{path_sep}, (grep { defined $_ and $_ ne '' } $dir1, $dir3, $dir2)),
+    'dir1 should have been removed and added back in at the top'
 );
 
+ok((!grep { $_ eq $dir3 } local::lib->active_paths), 'junk dir added not included in active_paths');
+
 ok((grep { /\Q$dir1\E/ } @INC), 'new dir has been added to @INC');
 ok((grep { /\Q$dir1\E/ } split /\Q$Config{path_sep}\E/, $ENV{PERL5LIB}), 'new dir has been added to PERL5LIB');