From: Peter Rabbitson Date: Tue, 12 Mar 2013 22:49:20 +0000 (+0100) Subject: Drop Test::Builder dep - subtests are overkill here X-Git-Tag: v0.001009~5 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FSub-Exporter-Progressive.git;a=commitdiff_plain;h=35a1e2d4843a0ea9746ad76353c7a65538fb0b2b Drop Test::Builder dep - subtests are overkill here --- diff --git a/Makefile.PL b/Makefile.PL index 2bbacae..65e5fd1 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -10,7 +10,7 @@ my %deps = ( }, ); my $key = eval { ExtUtils::MakeMaker->VERSION(6.56) } ? 'BUILD_REQUIRES' : 'PREREQ_PM' ; -$deps{$key}{'Test::More'} = '0.96'; +$deps{$key}{'Test::More'} = '0.88'; WriteMakefile( NAME => 'Sub-Exporter-Progressive', diff --git a/t/all.t b/t/all.t index fda725b..bf6fad5 100644 --- a/t/all.t +++ b/t/all.t @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More 0.89; +use Test::More; use List::Util 'first'; use lib 't/lib'; use A::JunkAll; diff --git a/t/basic.t b/t/basic.t index b6937e6..5a841d1 100644 --- a/t/basic.t +++ b/t/basic.t @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More 0.89; +use Test::More; use List::Util 'first'; use lib 't/lib'; use A::Junk 'junk1'; diff --git a/t/default.t b/t/default.t index 522bc22..f7eb327 100644 --- a/t/default.t +++ b/t/default.t @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More 0.89; +use Test::More; use List::Util 'first'; use lib 't/lib'; use A::Junk; diff --git a/t/sex.t b/t/sex.t index 7445705..103b0d1 100644 --- a/t/sex.t +++ b/t/sex.t @@ -2,7 +2,7 @@ use strict; use warnings; -use Test::More 0.89; +use Test::More; BEGIN { plan skip_all => 'Sub::Exporter not installed' unless eval { require Sub::Exporter }; diff --git a/t/tags.t b/t/tags.t index dd0a20d..5af34c6 100644 --- a/t/tags.t +++ b/t/tags.t @@ -1,7 +1,7 @@ use strict; use warnings; -use Test::More 0.96; +use Test::More; use List::Util 'first'; use Carp; use lib 't/lib'; @@ -34,24 +34,18 @@ BEGIN { }; my $i = 0; -sub check_tag -{ +sub check_tag { my ($tag, $should, $shouldnt) = @_; my $pkg = 'Local::Importer' . ++$i; - subtest "test the '$tag' tag" => sub - { - plan tests => 1 + @$should + @$shouldnt; - local $@ = undef; - - ok(eval qq{ - package $pkg; - use Local::Exporter qw( $tag ); - 1; - }, "$pkg compiled") or diag $@; - - ok( $pkg->can($_), "$pkg\->can(\"$_\")") for @$should; - ok(!$pkg->can($_), "$pkg\->can't(\"$_\")") for @$shouldnt; - } + + ok(eval qq{ + package $pkg; + use Local::Exporter qw( $tag ); + 1; + }, "'$tag' tag: $pkg compiled") or diag $@; + + ok( $pkg->can($_), "'$tag' tag: $pkg\->can(\"$_\")") for @$should; + ok(!$pkg->can($_), "'$tag' tag: $pkg\->can't(\"$_\")") for @$shouldnt; } check_tag(':default', [qw/foo/], [qw/bar baz/]);