the module uses Cpanel::JSON::XS no matter what its version, so we should upgrade...

diff --git a/Changes b/Changes
index 226a2d9..b49c56c 100644 (file)
--- a/Changes
+++ b/Changes
@@ -1,5 +1,8 @@
 Revision history for JSON-MaybeXS
 
+ - ensure an old Cpanel::JSON::XS is upgraded if it is too old, as it will
+   always be used in preference to JSON::XS
+
 1.003002 - 2014-11-16
  - correctly fix boolean interoperability with older Cpanel::JSON::MaybeXS
 

diff --git a/Makefile.PL b/Makefile.PL
index 8bb9ae0..f316895 100644 (file)
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -74,8 +74,8 @@ for (qw(configure build test runtime)) {
 # (we also always recommend Cpanel::JSON::XS, just to make sure.)
 $WriteMakefileArgs{PREREQ_PM}{'Cpanel::JSON::XS'} = '2.3310'
     if not parse_args()->{PUREPERL_ONLY}
-        and not eval { require JSON::XS; 1; }
-        and can_xs();
+        and ((eval { require Cpanel::JSON::XS; 1 } and not eval { Cpanel::JSON::XS->VERSION('2.3310'); 1 })
+            or (not eval { require JSON::XS; 1; } and can_xs()));
 
 $WriteMakefileArgs{MIN_PERL_VERSION} = delete $WriteMakefileArgs{PREREQ_PM}{perl} || 0;