X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FImport-Into.git;a=blobdiff_plain;f=lib%2FImport%2FInto.pm;h=7ca9d0bc8062618649b0bcd90c12a01cc28d3ee1;hp=c2ddbf8720a8f77fdfdb6d3b73c6dda0b6d6900d;hb=7a9ec1de996eb32a6fb07c942ae3c03744a82a17;hpb=06bd142d875a918529a7e006cbddcd3cbddc11b9

diff --git a/lib/Import/Into.pm b/lib/Import/Into.pm
index c2ddbf8..7ca9d0b 100644
--- a/lib/Import/Into.pm
+++ b/lib/Import/Into.pm
@@ -2,13 +2,14 @@ package Import::Into;
 
 use strict;
 use warnings FATAL => 'all';
+use Module::Runtime;
 
-our $VERSION = '1.001001'; # 1.1.1
+our $VERSION = '1.002004';
 
 sub _prelude {
   my $target = shift;
   my ($package, $file, $line, $level)
-    = ref $target         ? @{$target}{qw(package filename line)}
+    = ref $target         ? @{$target}{qw(package filename line level)}
     : $target =~ /[^0-9]/ ? ($target)
                           : (undef, undef, undef, $target);
   if (defined $level) {
@@ -24,8 +25,13 @@ sub _prelude {
 sub _make_action {
   my ($action, $target) = @_;
   my $version = ref $target && $target->{version};
-  my $ver_check = $version ? '$_[0]->VERSION($version);' : '';
-  eval _prelude($target).qq{sub { $ver_check shift->$action(\@_) }}
+  eval _prelude($target)
+    . q[sub {]
+    . q[  my $module = shift;]
+    . q[  Module::Runtime::require_module($module);]
+    . (ref $target && exists $target->{version} ? q[  $module->VERSION($version);] : q[])
+    . q[  $module->].$action.q[(@_);]
+    . q[}]
     or die "Failed to build action sub to ${action} for ${target}: $@";
 }
 
@@ -40,10 +46,12 @@ sub unimport::out_of {
 }
 
 1;
- 
+
+__END__
+
 =head1 NAME
 
-Import::Into - import packages into other packages
+Import::Into - Import packages into other packages
 
 =head1 SYNOPSIS
 
@@ -51,9 +59,6 @@ Import::Into - import packages into other packages
 
   use Import::Into;
 
-  use Thing1 ();
-  use Thing2 ();
-
   # simple
   sub import {
     Thing1->import::into(scalar caller);
@@ -83,11 +88,10 @@ Import::Into - import packages into other packages
     Thing1->unimport::out_of(scalar caller);
   }
 
-You don't need to do anything more clever than this provided you
-document that people wanting to re-export your module should also be using
-L<Import::Into>.
+People wanting to re-export your module should also be using L<Import::Into>.
+Any exporter or pragma will work seamlessly.
 
-Note: You do B<not> need to make ayny changes to Thing1 to be able to call
+Note: You do B<not> need to make any changes to Thing1 to be able to call
 C<import::into> on it. This is a global method, and is callable on any
 package (and in fact on any object as well, although it's rarer that you'd
 want to do that).
@@ -108,10 +112,11 @@ C<Import::Into> provides global methods to make this painless.
 
 =head2 $package->import::into( $target, @arguments );
 
-A global method, callable on any package.  Imports the given package into
-C<$target>.  C<@arguments> are passed along to the package's import method.
+A global method, callable on any package.  Loads and imports the given package
+into C<$target>.  C<@arguments> are passed along to the package's import method.
 
-C<$target> can be an package name to export to, an integer for the caller level to export to, or a hashref with the following options:
+C<$target> can be an package name to export to, an integer for the
+caller level to export to, or a hashref with the following options:
 
 =over 4
 
@@ -121,25 +126,32 @@ The target package to export to.
 
 =item filename
 
-The apparent filename to export to.  Some exporting modules, such as L<autodie> or L<strictures>, care about the filename they are being imported to.
+The apparent filename to export to.  Some exporting modules, such as
+L<autodie> or L<strictures>, care about the filename they are being imported
+to.
 
 =item line
 
-The apparent line number to export to.  To be combined with the C<filename> option.
+The apparent line number to export to.  To be combined with the C<filename>
+option.
 
 =item level
 
-The caller level to export to.  This will automatically populate the C<package>, C<filename>, and C<line> options, making it the easiest most constent option.
+The caller level to export to.  This will automatically populate the
+C<package>, C<filename>, and C<line> options, making it the easiest most
+constent option.
 
 =item version
 
-A version number to check for the module.  The equivalent of specifying the version number on a C<use> line.
+A version number to check for the module.  The equivalent of specifying the
+version number on a C<use> line.
 
 =back
 
 =head2 $package->unimport::out_of( $target, @arguments );
 
-Equivalent to C<import::into>, but dispatches to C<$package>'s C<unimport> method instead of C<import>.
+Equivalent to C<import::into>, but dispatches to C<$package>'s C<unimport>
+method instead of C<import>.
 
 =head1 WHY USE THIS MODULE
 
@@ -183,7 +195,8 @@ an exporter and a pragma.
 
 So, a solution for that is:
 
-  my $sub = eval "package $target; sub { shift->import(\@_) }";
+  use Module::Runtime;
+  my $sub = eval "package $target; sub { use_module(shift)->import(\@_) }";
   $sub->($thing, @import_args);
 
 which means that import is called from the right place for pragmas to take
@@ -200,12 +213,12 @@ in the directive then need to be fetched using C<caller>:
   my $sub = eval qq{
     package $target;
   #line $line "$file"
-    sub { shift->import(\@_) }
+    sub { use_module(shift)->import(\@_) }
   };
   $sub->($thing, @import_args);
 
 And you need to switch between these implementations depending on if you are
-targetting a specific package, or something in your call stack.
+targeting a specific package, or something in your call stack.
 
 Remembering all this, however, is excessively irritating. So I wrote a module
 so I didn't have to anymore. Loading L<Import::Into> creates a global method
@@ -243,15 +256,12 @@ For more craziness of this order, have a look at the article I wrote at
 L<http://shadow.cat/blog/matt-s-trout/madness-with-methods> which covers
 coderef abuse and the C<${\...}> syntax.
 
-Final note: You do still need to ensure that you already loaded C<$thing> - if
-you're receiving this from a parameter, I recommend using L<Module::Runtime>:
-
-  use Import::Into;
-  use Module::Runtime qw(use_module);
+And that's it.
 
-  use_module($thing)->import::into($target, @import_args);
+=head1 SEE ALSO
 
-And that's it.
+I gave a lightning talk on this module (and L<curry> and L<Safe::Isa>) at
+L<YAPC::NA 2013|https://www.youtube.com/watch?v=wFXWV2yY7gE&t=46m05s>.
 
 =head1 ACKNOWLEDGEMENTS
 
@@ -267,6 +277,8 @@ mst - Matt S. Trout (cpan:MSTROUT) <mst@shadowcat.co.uk>
 
 haarg - Graham Knop (cpan:HAARG) <haarg@haarg.org>
 
+Mithaldu - Christian Walde (cpan:MITHALDU) <walde.christian@gmail.com>
+
 =head1 COPYRIGHT
 
 Copyright (c) 2012 the Import::Into L</AUTHOR> and L</CONTRIBUTORS>
@@ -276,3 +288,5 @@ as listed above.
 
 This library is free software and may be distributed under the same terms
 as perl itself.
+
+=cut