From: Nicholas Clark Date: Sun, 24 Apr 2011 21:07:24 +0000 (+0100) Subject: SvOK() && SvROK() is a tautology - SvROK() true has always implied SvOK() true. X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-Size.git;a=commitdiff_plain;h=f76b99c2b19270e6e362a45b305cc58a69a2eb48 SvOK() && SvROK() is a tautology - SvROK() true has always implied SvOK() true. So no need to check SvOK() first on 5.10 or earlier. --- diff --git a/Size.xs b/Size.xs index 7ff7761..9a54522 100644 --- a/Size.xs +++ b/Size.xs @@ -759,15 +759,9 @@ CODE: /* If they passed us a reference then dereference it. This is the only way we can check the sizes of arrays and hashes */ -#if (PERL_VERSION < 11) - if (SvOK(thing) && SvROK(thing)) { - thing = SvRV(thing); - } -#else if (SvROK(thing)) { thing = SvRV(thing); } -#endif sv_size(aTHX_ st, thing, ix); RETVAL = st->total_size;