Correctly handle SvOOK scalars. 5.12 and later don't use SvIVX().

[p5sagit/Devel-Size.git] / t / basic.t

diff --git a/t/basic.t b/t/basic.t
index 8073e01..e39799a 100644 (file)
--- a/t/basic.t
+++ b/t/basic.t
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -w
 
-use Test::More tests => 15;
+use Test::More tests => 19;
 use strict;
 use Devel::Size qw(size total_size);
 use Scalar::Util qw(weaken);
@@ -11,7 +11,7 @@ can_ok ('Devel::Size', qw/
   /);
 
 die ("Uhoh, test uses an outdated version of Devel::Size")
-    unless is ($Devel::Size::VERSION, '0.74_51', 'VERSION MATCHES');
+    unless is ($Devel::Size::VERSION, '0.75_52', 'VERSION MATCHES');
 
 #############################################################################
 # some basic checks:
@@ -68,18 +68,6 @@ my($c1,$c2); $c2 = \$c1; $c1 = \$c2;
 
 is (total_size($c1), total_size($c2), 'circular references');
 
-#############################################################################
-# GLOBS
-
-cmp_ok(total_size(*foo), '>', 0, 'total_size(*foo) > 0');
-
-#############################################################################
-# CODE ref
-
-my $code = sub { '1' };
-
-cmp_ok(total_size($code), '>', 0, 'total_size($code) > 0');
-
 ##########################################################
 # RT#14849 (& RT#26781 and possibly RT#29238?)
 cmp_ok( total_size( sub{ do{ my $t=0 }; } ), '>', 0,
@@ -100,3 +88,28 @@ cmp_ok (total_size(\&LARGE), '>', 8192,
     is(total_size($a), total_size([]),
        'Any intial reference is dereferenced and discarded');
 }
+
+# Must call direct - avoid all copying:
+foreach(['undef', total_size(undef)],
+       ['no', total_size(1 == 0)],
+       ['yes', total_size(1 == 1)],
+       ) {
+    my ($name, $size) = @$_;
+    is($size, 0,
+       "PL_sv_$name is interpeter wide, so not counted as part of the structure's size");
+}
+
+{
+    # SvOOK stuff
+    my $uurk = "Perl Rules";
+    # This may upgrade the scalar:
+    $uurk =~ s/Perl//;
+    $uurk =~ s/^/Perl/;
+    my $before_size = total_size($uurk);
+    my $before_length = length $uurk;
+    cmp_ok($before_size, '>', $before_length, 'Size before is sane');
+    $uurk =~ s/Perl //;
+    is(total_size($uurk), $before_size,
+       "Size doesn't change because OOK is used");
+    cmp_ok(length $uurk, '<', $before_size, 'but string is shorter');
+}