Correctly handle SvOOK scalars. 5.12 and later don't use SvIVX().

[p5sagit/Devel-Size.git] / t / basic.t

diff --git a/t/basic.t b/t/basic.t
old mode 100755 (executable)
new mode 100644 (file)
index 4221cdd..e39799a
--- a/t/basic.t
+++ b/t/basic.t
@@ -1,22 +1,20 @@
-# Before `make install' is performed this script should be runnable with
-# `make test'. After `make install' it should work as `perl test.pl'
+#!/usr/bin/perl -w
 
-######################### We start with some black magic to print on failure.
-
-# Change 1..1 below to 1..last_test_to_print .
-# (It may become useful if the test is moved to ./t subdirectory.)
-
-BEGIN { $| = 1; print "1..8\n"; }
-END {print "not ok 1\n" unless $loaded;}
+use Test::More tests => 19;
+use strict;
 use Devel::Size qw(size total_size);
-$loaded = 1;
-print "ok 1\n";
+use Scalar::Util qw(weaken);
+
+can_ok ('Devel::Size', qw/
+  size
+  total_size
+  /);
 
-######################### End of black magic.
+die ("Uhoh, test uses an outdated version of Devel::Size")
+    unless is ($Devel::Size::VERSION, '0.75_52', 'VERSION MATCHES');
 
-# Insert your test code below (better if it prints "ok 13"
-# (correspondingly "not ok 13") depending on the success of chunk 13
-# of the test code):
+#############################################################################
+# some basic checks:
 
 use vars qw($foo @foo %foo);
 $foo = "12";
@@ -24,58 +22,94 @@ $foo = "12";
 %foo = (a => 1, b => 2);
 
 my $x = "A string";
-my $y = "A longer string";
-if (size($x) < size($y)) {
-    print "ok 2\n";
-} else {
-    print "not ok 2\n";
-}
-
-if (total_size($x) < total_size($y)) {
-    print "ok 3\n";
-} else {
-    print "not ok 3\n";
-}
+my $y = "A much much longer string";        # need to be at least 7 bytes longer for 64 bit
+cmp_ok(size($x), '<', size($y), 'size() of strings');
+cmp_ok(total_size($x), '<', total_size($y), 'total_size() of strings');
 
 my @x = (1..4);
-my @y = (1..10);
+my @y = (1..200);
 
-if (size(\@x) < size(\@y)) {
-    print "ok 4\n";
-} else {
-    print "not ok 4\n";
-}
+my $size_1 = total_size(\@x);
+my $size_2 = total_size(\@y);
 
-if (total_size(\@x) < total_size(\@y)) {
-    print "ok 5\n";
-} else {
-    print "not ok 5\n";
-}
+cmp_ok($size_1, '<', $size_2, 'size() of array refs');
+
+# the arrays alone shouldn't be the same size
+$size_1 = size(\@x);
+$size_2 = size(\@y);
+
+isnt ( $size_1, $size_2, 'size() of array refs');
+
+#############################################################################
+# IV vs IV+PV (bug #17586)
 
+$x = 12;
+$y = 12; $y .= '';
+
+$size_1 = size($x);
+$size_2 = size($y);
+
+cmp_ok($size_1, '<', $size_2, ' ."" makes string longer');
+
+#############################################################################
 # check that the tracking_hash is working
 
 my($a,$b) = (1,2);
 my @ary1 = (\$a, \$a);
 my @ary2 = (\$a, \$b);
 
-if (total_size(\@ary1) < total_size(\@ary2)) {
-    print "ok 6\n";
-} else {
-    print "not ok 6\n";
-}
+cmp_ok(total_size(\@ary1), '<', total_size(\@ary2),
+       'the tracking hash is working');
 
+#############################################################################
 # check that circular references don't mess things up
 
 my($c1,$c2); $c2 = \$c1; $c1 = \$c2;
 
-if( total_size($c1) == total_size($c2) ) {
-    print "ok 7\n";
-} else {
-    print "not ok 7\n";
+is (total_size($c1), total_size($c2), 'circular references');
+
+##########################################################
+# RT#14849 (& RT#26781 and possibly RT#29238?)
+cmp_ok( total_size( sub{ do{ my $t=0 }; } ), '>', 0,
+       'total_size( sub{ my $t=0 } ) > 0' );
+
+# CPAN RT #58484 and #58485
+cmp_ok(total_size(\&total_size), '>', 0, 'total_size(\&total_size) > 0');
+
+use constant LARGE => 'N' x 8192;
+
+cmp_ok (total_size(\&LARGE), '>', 8192,
+        'total_size for a constant includes the constant');
+
+{
+    my $a = [];
+    my $b = \$a;
+    # making a weakref upgrades the target to PVMG and adds magic
+    is(total_size($a), total_size([]),
+       'Any intial reference is dereferenced and discarded');
+}
+
+# Must call direct - avoid all copying:
+foreach(['undef', total_size(undef)],
+       ['no', total_size(1 == 0)],
+       ['yes', total_size(1 == 1)],
+       ) {
+    my ($name, $size) = @$_;
+    is($size, 0,
+       "PL_sv_$name is interpeter wide, so not counted as part of the structure's size");
 }
 
-if (total_size(*foo)) {
-   print "ok 8\n";
-} else {
-  print "not ok 8\n";
+{
+    # SvOOK stuff
+    my $uurk = "Perl Rules";
+    # This may upgrade the scalar:
+    $uurk =~ s/Perl//;
+    $uurk =~ s/^/Perl/;
+    my $before_size = total_size($uurk);
+    my $before_length = length $uurk;
+    cmp_ok($before_size, '>', $before_length, 'Size before is sane');
+    $uurk =~ s/Perl //;
+    is(total_size($uurk), $before_size,
+       "Size doesn't change because OOK is used");
+    cmp_ok(length $uurk, '<', $before_size, 'but string is shorter');
 }