Re-instate initial dereference in total_size()

[p5sagit/Devel-Size.git] / t / basic.t

diff --git a/t/basic.t b/t/basic.t
index 5a052af..b5b0838 100644 (file)
--- a/t/basic.t
+++ b/t/basic.t
@@ -1,8 +1,9 @@
 #!/usr/bin/perl -w
 
-use Test::More tests => 14;
+use Test::More tests => 15;
 use strict;
 use Devel::Size qw(size total_size);
+use Scalar::Util qw(weaken);
 
 can_ok ('Devel::Size', qw/
   size
@@ -10,7 +11,7 @@ can_ok ('Devel::Size', qw/
   /);
 
 die ("Uhoh, test uses an outdated version of Devel::Size")
-  unless is ($Devel::Size::VERSION, '0.72_52', 'VERSION MATCHES');
+  unless is ($Devel::Size::VERSION, '0.73_50', 'VERSION MATCHES');
 
 #############################################################################
 # some basic checks:
@@ -57,8 +58,8 @@ my($a,$b) = (1,2);
 my @ary1 = (\$a, \$a);
 my @ary2 = (\$a, \$b);
 
-isnt ( total_size(\@ary2) - total_size(\@ary1), 0,
-    'total_size(\@ary1) < total_size(\@ary2)');
+cmp_ok(total_size(\@ary1), '<', total_size(\@ary2),
+       'the tracking hash is working');
 
 #############################################################################
 # check that circular references don't mess things up
@@ -70,23 +71,32 @@ is (total_size($c1), total_size($c2), 'circular references');
 #############################################################################
 # GLOBS
 
-isnt (total_size(*foo), 0, 'total_size(*foo) > 0');
+cmp_ok(total_size(*foo), '>', 0, 'total_size(*foo) > 0');
 
 #############################################################################
 # CODE ref
 
 my $code = sub { '1' };
 
-isnt (total_size($code), 0, 'total_size($code) > 0');
+cmp_ok(total_size($code), '>', 0, 'total_size($code) > 0');
 
 ##########################################################
 # RT#14849 (& RT#26781 and possibly RT#29238?)
-isnt( total_size( sub{ do{ my $t=0 }; } ), 0, 'total_size( sub{ my $t=0 } ) > 0' );
+cmp_ok( total_size( sub{ do{ my $t=0 }; } ), '>', 0,
+       'total_size( sub{ my $t=0 } ) > 0' );
 
 # CPAN RT #58484 and #58485
-isnt (total_size(\&total_size), 0, 'total_size(\&total_size) > 0');
+cmp_ok(total_size(\&total_size), '>', 0, 'total_size(\&total_size) > 0');
 
 use constant LARGE => 'N' x 8192;
 
 cmp_ok (total_size(\&LARGE), '>', 8192,
         'total_size for a constant includes the constant');
+
+{
+    my $a = [];
+    my $b = \$a;
+    # making a weakref upgrades the target to PVMG and adds magic
+    is(total_size($a), total_size([]),
+       'Any intial reference is dereferenced and discarded');
+}