From: Chris Marshall Date: Sat, 19 May 2012 18:09:39 +0000 (-0400) Subject: Revert "Fixed minor logic inverson in MultiLine/PPI.pm" X-Git-Tag: v1.003015~11 X-Git-Url: http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=p5sagit%2FDevel-REPL.git;a=commitdiff_plain;h=d954e450ff6824b77a888ce2a44019bdfe560d1b;hp=3ad5a18553aa69a6cd89a78e5d14e69fe750989b Revert "Fixed minor logic inverson in MultiLine/PPI.pm" This reverts commit d8153bec650b92d2cd68449a148c393c51e877e9. The fix made it possible to continue q{} constructs across lines but, it also allowed "q\n" to continue as well which is not valid. Reverting until further investigation can be made. --- diff --git a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm index f0f9f9a..1f23cfc 100644 --- a/lib/Devel/REPL/Plugin/MultiLine/PPI.pm +++ b/lib/Devel/REPL/Plugin/MultiLine/PPI.pm @@ -57,16 +57,12 @@ sub line_needs_continuation $line .= "\n;;"; my $document = PPI::Document->new(\$line); - unless ( defined($document) ) { - die "PPI failed to parse document '$line'\n"; - } + return 0 if !defined($document); # adding ";" to a complete document adds a PPI::Statement::Null. we added a ;; # so if it doesn't end in null then there's probably something that's # incomplete - unless ( $document->child(-1)->isa('PPI::Statement::Null') ) { - return 1; - } + return 0 if $document->child(-1)->isa('PPI::Statement::Null'); # this could use more logic, such as returning 1 on s/foo/ba my $unfinished_structure = sub